{"id":815242,"url":"http://patchwork.ozlabs.org/api/patches/815242/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170919010628.175732-6-salil.mehta@huawei.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170919010628.175732-6-salil.mehta@huawei.com>","list_archive_url":null,"date":"2017-09-19T01:06:26","name":"[net,5/7] net: hns3: fixes the ether address copy with more appropriate API","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"a16c6c2de4b840c669c04a5ea181ee4da7e04202","submitter":{"id":67454,"url":"http://patchwork.ozlabs.org/api/people/67454/?format=json","name":"Salil Mehta","email":"salil.mehta@huawei.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170919010628.175732-6-salil.mehta@huawei.com/mbox/","series":[{"id":3764,"url":"http://patchwork.ozlabs.org/api/series/3764/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3764","date":"2017-09-19T01:06:27","name":"Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC","version":1,"mbox":"http://patchwork.ozlabs.org/series/3764/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815242/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815242/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx4Xm0B97z9s78\n\tfor ;\n\tTue, 19 Sep 2017 11:09:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751476AbdISBHg (ORCPT );\n\tMon, 18 Sep 2017 21:07:36 -0400","from szxga05-in.huawei.com ([45.249.212.191]:6070 \"EHLO\n\tszxga05-in.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751431AbdISBHd (ORCPT\n\t); Mon, 18 Sep 2017 21:07:33 -0400","from 172.30.72.60 (EHLO DGGEMS411-HUB.china.huawei.com)\n\t([172.30.72.60])\n\tby dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DHO21288; Tue, 19 Sep 2017 09:07:31 +0800 (CST)","from S00293818-DELL1.china.huawei.com (10.47.92.71) by\n\tDGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP\n\tServer id 14.3.301.0; Tue, 19 Sep 2017 09:07:23 +0800"],"From":"Salil Mehta ","To":"","CC":", ,\n\t, ,\n\t, ,\n\t, ","Subject":"[PATCH net 5/7] net: hns3: fixes the ether address copy with more\n\tappropriate API","Date":"Tue, 19 Sep 2017 02:06:26 +0100","Message-ID":"<20170919010628.175732-6-salil.mehta@huawei.com>","X-Mailer":"git-send-email 2.8.3","In-Reply-To":"<20170919010628.175732-1-salil.mehta@huawei.com>","References":"<20170919010628.175732-1-salil.mehta@huawei.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-Originating-IP":"[10.47.92.71]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020206.59C06DD3.0172, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"3c0644f06c3cf8d70d8bb955b7965edf","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This patch replaces the ethernet address copy instance with more\nappropriate ether_addr_copy() function.\n\nSigned-off-by: Salil Mehta \n---\n drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\nindex eafd9c678162..8e172afd4876 100644\n--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\n+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\n@@ -1063,8 +1063,7 @@ static int hclge_configure(struct hclge_dev *hdev)\n \thdev->base_tqp_pid = 0;\n \thdev->rss_size_max = 1;\n \thdev->rx_buf_len = cfg.rx_buf_len;\n-\tfor (i = 0; i < ETH_ALEN; i++)\n-\t\thdev->hw.mac.mac_addr[i] = cfg.mac_addr[i];\n+\tether_addr_copy(hdev->hw.mac.mac_addr, cfg.mac_addr);\n \thdev->hw.mac.media_type = cfg.media_type;\n \thdev->hw.mac.phy_addr = cfg.phy_addr;\n \thdev->num_desc = cfg.tqp_desc_num;\n","prefixes":["net","5/7"]}