{"id":815183,"url":"http://patchwork.ozlabs.org/api/patches/815183/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170918214128.27896-5-f.fainelli@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918214128.27896-5-f.fainelli@gmail.com>","list_archive_url":null,"date":"2017-09-18T21:41:20","name":"[net-next,04/12] net: dsa: bcm_sf2: Defer port enabling to calling port_enable","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"6070678fd20f09d819f4d89cbc2b16875ed3a7a6","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/?format=json","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170918214128.27896-5-f.fainelli@gmail.com/mbox/","series":[{"id":3739,"url":"http://patchwork.ozlabs.org/api/series/3739/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3739","date":"2017-09-18T21:41:16","name":"net: dsa: b53/bcm_sf2 cleanups","version":1,"mbox":"http://patchwork.ozlabs.org/series/3739/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815183/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815183/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PtRpPBHY\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwzwy1gCHz9ryv\n\tfor ;\n\tTue, 19 Sep 2017 07:41:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751507AbdIRVlw (ORCPT );\n\tMon, 18 Sep 2017 17:41:52 -0400","from mail-wm0-f66.google.com ([74.125.82.66]:36543 \"EHLO\n\tmail-wm0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750872AbdIRVlu (ORCPT\n\t); Mon, 18 Sep 2017 17:41:50 -0400","by mail-wm0-f66.google.com with SMTP id r136so2126205wmf.3\n\tfor ; Mon, 18 Sep 2017 14:41:49 -0700 (PDT)","from fainelli-desktop.broadcom.com ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id\n\te34sm9242761wre.15.2017.09.18.14.41.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 14:41:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=zqJ4xIyT7Glf86R/B9fZrpCGAfYSR5lE5zKpOsX6fZg=;\n\tb=PtRpPBHYZW1bnCeHHYCHgkKrhIgMdDhIvfPIq7mfCtBmz4+Qq9SEurZhKoq9YLkose\n\tziOMN8X7BUXYENAkhq4kRGBM5unhmyklnN1qITqX7OIkf1wS7ZGZp2G2V/YORjCkSvCT\n\tClIQUoJx0x1DPs0djakWyN+ATL7AV3Wpuer56OeIvQkfx87TryoWLzxC55x0TgnMC4yn\n\thw3oOXnI0Nwc0blxGyE1+CKLAmhQtd1XIK+k8+XdTOmXYYYcMZA+42rqu6mc3pBMh2T8\n\tPzDvlkPGWH6PRnnFq2tXDJmqvWUpQC6hhACNS7FHoVwEoavRMQwieUii6b6qP+FMmA6K\n\tOnZA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=zqJ4xIyT7Glf86R/B9fZrpCGAfYSR5lE5zKpOsX6fZg=;\n\tb=uDAdNrcfk1YBTIqvRNsL/4qoRMriiCw73veF2wcQbfmLx2RdNqa67K8IzRYsCUXri6\n\tywJ/30msuRgcSQdl71yMuNYKtb6gW+7TWJgiUFuArDKnGVTg/Rcm2dPKDK0PPaXPhF+u\n\tOHVtHzrz1AZkCgABmSSyLDedHewgVW1lbl+89hDX0MNQv3svokUSkmLQIfLT7LhVbdf0\n\tjENJZ05cz6niYyERsN77vGeDHUNdThC/YJ3bHdIHIPaButZGqDmZEfDJg/LQanIbto6T\n\tlaf6iAuuE460LMAYWXH+ME6+hIDEVAdqtc8aJy8g8oLezgKSQzbbUCjt5RmfSHnodHqU\n\tECHA==","X-Gm-Message-State":"AHPjjUg2iZ/ZkG1mwZ++4bTL1W51V6bgz6xYtOsIkoV8DubG2ANJqyXm\n\t2kh0zeVdli0Ope7FaYw=","X-Google-Smtp-Source":"AOwi7QBTvaosTC+5Xc8VQ8UfdadWz3eLzoKhoP2mAgF9V4/eW/jpy7F5CmbCK0Afqhtb1gJchkX9jg==","X-Received":"by 10.28.60.8 with SMTP id j8mr9139302wma.16.1505770908642;\n\tMon, 18 Sep 2017 14:41:48 -0700 (PDT)","From":"Florian Fainelli ","To":"netdev@vger.kernel.org","Cc":"davem@davemloft.net, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,\n\tFlorian Fainelli ","Subject":"[PATCH net-next 04/12] net: dsa: bcm_sf2: Defer port enabling to\n\tcalling port_enable","Date":"Mon, 18 Sep 2017 14:41:20 -0700","Message-Id":"<20170918214128.27896-5-f.fainelli@gmail.com>","X-Mailer":"git-send-email 2.9.3","In-Reply-To":"<20170918214128.27896-1-f.fainelli@gmail.com>","References":"<20170918214128.27896-1-f.fainelli@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"There is no need to configure the enabled ports once in bcm_sf2_sw_setup() and\nthen a second time around when dsa_switch_ops::port_enable is called, just do\nit when port_enable is called which is better in terms of power consumption and\ncorrectness.\n\nSigned-off-by: Florian Fainelli \n---\n drivers/net/dsa/bcm_sf2.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c\nindex d7b53d53c116..8acbd17bc1fd 100644\n--- a/drivers/net/dsa/bcm_sf2.c\n+++ b/drivers/net/dsa/bcm_sf2.c\n@@ -890,14 +890,11 @@ static int bcm_sf2_sw_setup(struct dsa_switch *ds)\n \tstruct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds);\n \tunsigned int port;\n \n-\t/* Enable all valid ports and disable those unused */\n+\t/* Disable unused ports and configure IMP port */\n \tfor (port = 0; port < priv->hw_params.num_ports; port++) {\n-\t\t/* IMP port receives special treatment */\n-\t\tif ((1 << port) & ds->enabled_port_mask)\n-\t\t\tbcm_sf2_port_setup(ds, port, NULL);\n-\t\telse if (dsa_is_cpu_port(ds, port))\n+\t\tif (dsa_is_cpu_port(ds, port))\n \t\t\tbcm_sf2_imp_setup(ds, port);\n-\t\telse\n+\t\telse if (!((1 << port) & ds->enabled_port_mask))\n \t\t\tbcm_sf2_port_disable(ds, port, NULL);\n \t}\n \n","prefixes":["net-next","04/12"]}