{"id":815181,"url":"http://patchwork.ozlabs.org/api/patches/815181/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170918214128.27896-3-f.fainelli@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918214128.27896-3-f.fainelli@gmail.com>","list_archive_url":null,"date":"2017-09-18T21:41:18","name":"[net-next,02/12] net: dsa: b53: Make b53_enable_cpu_port() take a port argument","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"c399d08f0259532527b5454ea01fa4da6fb2e9ac","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/?format=json","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170918214128.27896-3-f.fainelli@gmail.com/mbox/","series":[{"id":3739,"url":"http://patchwork.ozlabs.org/api/series/3739/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3739","date":"2017-09-18T21:41:16","name":"net: dsa: b53/bcm_sf2 cleanups","version":1,"mbox":"http://patchwork.ozlabs.org/series/3739/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815181/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815181/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"OwuAp993\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwzwq2FT5z9ryv\n\tfor ;\n\tTue, 19 Sep 2017 07:41:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751488AbdIRVlo (ORCPT );\n\tMon, 18 Sep 2017 17:41:44 -0400","from mail-wm0-f68.google.com ([74.125.82.68]:37576 \"EHLO\n\tmail-wm0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751462AbdIRVlm (ORCPT\n\t); Mon, 18 Sep 2017 17:41:42 -0400","by mail-wm0-f68.google.com with SMTP id f4so2120286wmh.4\n\tfor ; Mon, 18 Sep 2017 14:41:41 -0700 (PDT)","from fainelli-desktop.broadcom.com ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id\n\te34sm9242761wre.15.2017.09.18.14.41.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 14:41:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=SC9TLbQQasxciAhq6sIMsfdL5zUjogiYOMhBRxL8RQ4=;\n\tb=OwuAp993HUXmD9SzKTkRVDSsCDQVvZPXu5flLIHXpEsutbdq+Yr46hnwIHL2xa6XZJ\n\taSyV6M4M9PE/T+8L9/fq1o0ImLr3iOfYTIYnSI5Da0YH8iZJIDoD5fMLjSGKeeZhVMQd\n\tyZxPaCsI8EK8EJs8WOfnLFffe5y+mHf8WthKviQ4KNlEpMyAfxoxWCNYh/HRNoaTrZZE\n\t1FWXW14sbbypNg+hv1d8nUlGPm/oaH+AsJ9RnnIKHwOrknc+DMw0kqq8BxZXTrxQuJwE\n\twIsJshcKYMhlfS6nt6yFcsAXiDjWjvx+BB+IpXCpd5j/tocSUmg/y/w5zsByC1jpxtHn\n\tuUlg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=SC9TLbQQasxciAhq6sIMsfdL5zUjogiYOMhBRxL8RQ4=;\n\tb=GhWVSLmQBUj31rXHc2A9ZphqTPZY3b2UtI7C2c9Dg9eGRuZj4V3uSVCV906fhg8ZVC\n\tJuC6pKV4L56IcdedWMNoYnPuCg6XNjq0FsZgYwxoFVxZyFGk1mGun3vyefy8ujD/9k0h\n\tCX7CgtV0TeHMNYN3TSGrFH8XEwuwjVJyGJ3B2RLgrmROFA2kbajCSTcyB7nR7nea09R9\n\t9WFrlayav5QfYRjaibxli5eHV8Z/iVH5y3bJ+BcJTQxm7M61vL6j7Ir0S+/bWPxFaFNR\n\tMTHTsKXE2anAijXv94+uXbES3TzKgexOSNI3p7qYA91bwtIcYEllthun1PkFuINUvL8r\n\tNxpw==","X-Gm-Message-State":"AHPjjUjns236f7LGi5wKLbDot8uE1SaGlBCFNP1OhotmmHND5MDMFk5N\n\tH7jQW/jeCeleCTATrHY=","X-Google-Smtp-Source":"AOwi7QC9pPLBiqxT+jO3gWaRHwlLb9N011BY/FbIg1d3f3+X2pq8lrXJ9Cq6IGS4K6/6LE7eUiedXg==","X-Received":"by 10.28.135.5 with SMTP id j5mr11014960wmd.21.1505770900935;\n\tMon, 18 Sep 2017 14:41:40 -0700 (PDT)","From":"Florian Fainelli ","To":"netdev@vger.kernel.org","Cc":"davem@davemloft.net, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,\n\tFlorian Fainelli ","Subject":"[PATCH net-next 02/12] net: dsa: b53: Make b53_enable_cpu_port()\n\ttake a port argument","Date":"Mon, 18 Sep 2017 14:41:18 -0700","Message-Id":"<20170918214128.27896-3-f.fainelli@gmail.com>","X-Mailer":"git-send-email 2.9.3","In-Reply-To":"<20170918214128.27896-1-f.fainelli@gmail.com>","References":"<20170918214128.27896-1-f.fainelli@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"In preparation for future changes allowing the configuring of multiple\nCPU ports, make b53_enable_cpu_port() take a port argument.\n\nSigned-off-by: Florian Fainelli \n---\n drivers/net/dsa/b53/b53_common.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c\nindex 274f3679f33d..d8bc54cfcfbe 100644\n--- a/drivers/net/dsa/b53/b53_common.c\n+++ b/drivers/net/dsa/b53/b53_common.c\n@@ -538,19 +538,18 @@ static void b53_disable_port(struct dsa_switch *ds, int port,\n \tb53_write8(dev, B53_CTRL_PAGE, B53_PORT_CTRL(port), reg);\n }\n \n-static void b53_enable_cpu_port(struct b53_device *dev)\n+static void b53_enable_cpu_port(struct b53_device *dev, int port)\n {\n-\tunsigned int cpu_port = dev->cpu_port;\n \tu8 port_ctrl;\n \n \t/* BCM5325 CPU port is at 8 */\n-\tif ((is5325(dev) || is5365(dev)) && cpu_port == B53_CPU_PORT_25)\n-\t\tcpu_port = B53_CPU_PORT;\n+\tif ((is5325(dev) || is5365(dev)) && port == B53_CPU_PORT_25)\n+\t\tport = B53_CPU_PORT;\n \n \tport_ctrl = PORT_CTRL_RX_BCST_EN |\n \t\t PORT_CTRL_RX_MCST_EN |\n \t\t PORT_CTRL_RX_UCST_EN;\n-\tb53_write8(dev, B53_CTRL_PAGE, B53_PORT_CTRL(cpu_port), port_ctrl);\n+\tb53_write8(dev, B53_CTRL_PAGE, B53_PORT_CTRL(port), port_ctrl);\n }\n \n static void b53_enable_mib(struct b53_device *dev)\n@@ -820,7 +819,7 @@ static int b53_setup(struct dsa_switch *ds)\n \t\tif (BIT(port) & ds->enabled_port_mask)\n \t\t\tb53_enable_port(ds, port, NULL);\n \t\telse if (dsa_is_cpu_port(ds, port))\n-\t\t\tb53_enable_cpu_port(dev);\n+\t\t\tb53_enable_cpu_port(dev, port);\n \t\telse\n \t\t\tb53_disable_port(ds, port, NULL);\n \t}\n","prefixes":["net-next","02/12"]}