{"id":815160,"url":"http://patchwork.ozlabs.org/api/patches/815160/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505767187-4596-6-git-send-email-roy.pledge@nxp.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1505767187-4596-6-git-send-email-roy.pledge@nxp.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1505767187-4596-6-git-send-email-roy.pledge@nxp.com/","date":"2017-09-18T20:39:40","name":"[v5,05/12] soc/fsl/qbman: Drop set/clear_bits usage","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"e015d8ba2ccf0f6b92a18e372c1848a6ad14db6f","submitter":{"id":70252,"url":"http://patchwork.ozlabs.org/api/people/70252/?format=json","name":"Roy Pledge","email":"roy.pledge@nxp.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505767187-4596-6-git-send-email-roy.pledge@nxp.com/mbox/","series":[{"id":3731,"url":"http://patchwork.ozlabs.org/api/series/3731/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=3731","date":"2017-09-18T20:39:38","name":"soc/fsl/qbman: Enable QBMan on ARM Platforms","version":5,"mbox":"http://patchwork.ozlabs.org/series/3731/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815160/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815160/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwylC5qKKz9s7m\n\tfor ;\n\tTue, 19 Sep 2017 06:48:23 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xwylC4zFQzDqXs\n\tfor ;\n\tTue, 19 Sep 2017 06:48:23 +1000 (AEST)","from NAM01-BY2-obe.outbound.protection.outlook.com\n\t(mail-by2nam01on0048.outbound.protection.outlook.com [104.47.34.48])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xwyYX12BczDq5k\n\tfor ;\n\tTue, 19 Sep 2017 06:39:59 +1000 (AEST)","from BN6PR03CA0054.namprd03.prod.outlook.com (10.173.137.16) by\n\tCO2PR03MB2359.namprd03.prod.outlook.com (10.166.93.19) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.56.11; Mon, 18 Sep 2017 20:39:56 +0000","from BL2FFO11FD052.protection.gbl (2a01:111:f400:7c09::100) by\n\tBN6PR03CA0054.outlook.office365.com (2603:10b6:404:4c::16) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8 via\n\tFrontend Transport; Mon, 18 Sep 2017 20:39:55 +0000","from tx30smr01.am.freescale.net (192.88.168.50) by\n\tBL2FFO11FD052.mail.protection.outlook.com (10.173.161.214) with\n\tMicrosoft\n\tSMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id\n\t15.20.35.14 via Frontend Transport; Mon, 18 Sep 2017 20:39:55 +0000","from otc-sw1.am.freescale.net (otc-sw1.am.freescale.net\n\t[10.29.200.182])\n\tby tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id\n\tv8IKdn2q025841; Mon, 18 Sep 2017 13:39:54 -0700"],"Authentication-Results":["ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nxp.com\n\t(client-ip=104.47.34.48;\n\thelo=nam01-by2-obe.outbound.protection.outlook.com; \n\tenvelope-from=roy.pledge@nxp.com; receiver=)","spf=fail (sender IP is 192.88.168.50)\n\tsmtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed)\n\theader.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com;"],"Received-SPF":"Fail (protection.outlook.com: domain of nxp.com does not\n\tdesignate 192.88.168.50 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;","From":"Roy Pledge ","To":", ,\n\t, ,\n\t","Subject":"[v5 05/12] soc/fsl/qbman: Drop set/clear_bits usage","Date":"Mon, 18 Sep 2017 16:39:40 -0400","Message-ID":"<1505767187-4596-6-git-send-email-roy.pledge@nxp.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1505767187-4596-1-git-send-email-roy.pledge@nxp.com>","References":"<1505767187-4596-1-git-send-email-roy.pledge@nxp.com>","X-EOPAttributedMessage":"0","X-Matching-Connectors":"131502407957683659;\n\t(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()","X-Forefront-Antispam-Report":"CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(336005)(376002)(346002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(5660300001)(316002)(8936002)(77096006)(81156014)(81166006)(48376002)(8676002)(7416002)(50466002)(2950100002)(106466001)(6666003)(68736007)(54906002)(4326008)(5003940100001)(16586007)(97736004)(104016004)(47776003)(36756003)(53936002)(33646002)(43066003)(76176999)(50986999)(356003)(305945005)(2201001)(3450700001)(86362001)(189998001)(85426001)(498600001)(50226002)(8656003)(105606002)(2906002)(110136005)(2101003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2359;\n\tH:tx30smr01.am.freescale.net; \n\tFPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; ","X-Microsoft-Exchange-Diagnostics":["1; BL2FFO11FD052;\n\t1:OhkxbYzbVpKvqfq429EU29TmGZCcEdrppQbQVJrl9Q/P9UdGz9629jFUmCyRP4M0wnZxsoIGDU7o9ckrF1lZW2Mi2/Rs2un1CYKGjpJrpxWQQMx0wBJKPB9E0Z0jYEOl","1; CO2PR03MB2359;\n\t3:MswmVmtnP4MOHdysrUFeqbefAmY4i1RHZYMoGnEx892S7lonkwLbinxH/pqhw5nQBGUm1RcFB+JOW2p/b10uTWbo3FRim1VOD6tr0IIEWILvzpOcLwiDlhmQu98MB8acfuWnzqwe0ymSGKzrliygXLAO61K4C6rb/ba9haoI+8BQt9hAPI5eaBK8LQ3tOXH2Zn8MMC4atrvaYJrmLlxdUAoY/Jp6arBZUzcZK2b/4zz01dArGXeiv4qdX8WrnKTcnRDsTFBtzymeSD5XLYQzMyhGH4T2AsmnUTgDVcNRQPEfUciSxZ2aMmVhcPQgweH04VJAjHF0qmvObaps95VFeS+7GsXKHa4YMoHVeTvfusA=;\n\t25:3LzTlDPVZY+KnRgTdkonXS1y3Lb6xDGOpBn0GYjnNeq+KjaHjyIemE8f1PNlokx20KmZ2hd2G9t0F2dfLSHqp6IGgpquVCqOSHllR+lTfy9KvV/d1UL8h1ZsTu+aj1eGj8zfw/k8s83eeTeIK0otMwwp0LD7FT0TmvftIDcrqYYHZblrIxX+P3QCp8VpSbI+9aZhLPNRZGe6PHTvM85//rargQERksFwyqZCCeJ7UyYeO2tpEyvkmkdmg+csN/5ZseYWf4nk9tJCsLJDRZNlx4p8ajv6+kePjDqdBR9xjVq74RWQwZpRDBG7WEtr+aNRKPI1QwoPDQtvxA1g/LxR2w==","1; CO2PR03MB2359;\n\t31:fGxIE4QaROsj6vVnrUxDiInKG6pNOR1veYjX3FcJaAms5Vvx7Wo8v2RhdWs/4Mj+IrP8jHoypbykYRNAKT8KA1MUao9yD7/UILYZGkjrQdb9YwNyBSM9skq+m0kZ9Ud1OznUZw+eKEXIuXW1fugc2wRiUBdOHvYbnveMaaiNqen66DA9bnwRuuls4F+GDjaYIoaz2M5XnGSmJDdNTOeh75Amf46FgxEsn/AwPM/kij8=;\n\t4:pDmZh8x8vuSlF3XZ97FhlqrYKIVgBDeoI4U8Ed/lrH8pIoAaTm/6J6kfE98oQq25EQZDECe0krkKH8Wd4j9O10GPFGbwL7Lu6doSck6I9WZfi3vP371j4N+XtaLmw1k3mDHRK5zJYRZG0QBCRLbTRfCBQHvJdh2jh/PkELk1XaRP5feTCqVGnSS3vM47gAUY/FguOxb97wVMpLVeCXe9BwDxb4e+Y8mA1GZyxO9mwaLW7ntrC9hcwVASvT69RmIjCldp7W7Zve8aWMATKq9t+vTDsiZ0FVyh66RQ1bCqjUvazbQJQCHq9FjVYHlIdN2SS/PXsGR7z/mY1JYgyLe39Q==","=?us-ascii?Q?1; CO2PR03MB2359;\n\t23:8NR/Yo7M5j9+lFl5br3H/l4ifvlahkvNGuxTPdmn6?=\n\tHxL/fYYUvGgvNwg4O4towvp0tXJ+xHwlia0iuK5ROLulM45IM8PVaa6GKDhDOnJtdm9ccjli2lLzkflQKztjrLdicam4vnNFDBW1phMOaPuLH6QFcAbVISJNJB+JRptSKoYIBAYsEx5EnQfNC4Ntp3K0k5dHxlENK+Ft9dQrh3FNreZxzQzoWHOCdScQVUiIPBc44+JqVJlgY3zpeN8ErhdmnuOYbx3cxsZDabn63FL7Ffkh7mgm4dVlEL0i2K6ftSTKu/OqNBWbAN0hRx5i/NJO/BPGExw+FGr/NNRKO7OpCdSj41lZpUw7TuhZ6ZuGC7gPsnnz8S7XAgnunXZAizIOzjL/m20gcXm+UEATiJe+/bAOgR5j8kod1XBI/rKXr3pGzHH7FG25OZXzBrhddnJvicQMH+gSmkWLqjB1PL7hPQsm1z0KV14V9CK3lFGdN7kYhKw6ijT8TSaQVKNQ1noZ1xg1dMyRD00S+l/WCHujBz8jZ6u7d2OVO60OoixmI6E3XiNq4+369W7SjAgpCKv5N59Gznln0o5+KqEAV4jmrTgt46egtd0AWRykO3uXH8+0EUrbYJaw6of+7ii1VGZtVcjoYgAp9qkYVmxX6i5ipIJxjxZIebpBevg/onnlK7X6GCQYw5BK54AvviG6xt+lhjwOi6aYcuJxVQxMKzZOfmB2hQ3hOjl3dxdXhXyLwR8yCDVaeYXO6J7EmDsXlPOtxPIZaMD9mfZ9ApNA3uNSMsmfJRUog2BsFjT1R4DQzD46tLviI2OEzsf/SqkVEBHcSOPoP+CdssSg8UVThXESDJebACcRQGExf2c4T9B2ACaLIC6uf3w5LBxjpXRP1LiaK63qKxDWxvtA5yUOCMQr1Gh3gEC6yMFKUCv51rEp/tz9jnZyeSv0BQvn6QVMcCYiJSBb/qTTGPDnHK3fIglLEAqJc0lvXhZVDz0cvp+bGwjAT/eUi7UdCT9v5Pw1P/TFFU7CbOpbxqPOKW7QlNgcU3fY9rMOwOtec0y87a5Kzc3pfX/jKH3kiq0WA2dORd2hZeB84fnb6rgSFEbfByre6qhgO+ET8cvN1Wp32PfOKtblK0F2UOYqJXFVAZgh/wdsZmLrLe4s39ogmeFMc1Mxl612XrySe9Ph/aXZyS1qjFXp4tN+lHM4W4B2ZmUzAt8sJtivwo7BxypTyQRe5TyQHEzJIOBbAef0IlT7yXEYvo=","1; CO2PR03MB2359;\n\t6:PD8OHA8vFW/cHt8dee3qERnjyi0SU4UiYSBjsXd5wk9DWOvJ11FjVrQIudeLZz7PXWsO89bSnhp6pVA/C1FnNd2RAiKkJU/9K0zf5Hnvt2Jvjk1DQjqAKey+OIBhVNMPY0ye55PXhXzO6mfAInKD6so25yFpRitBStR/HVZlOVgwKcBofx35D1QukA6ZB77oPkeZM/Y/T1CeURiv6aj4G/WQFKjQnkFhxpORppsOpiAVEoBU9xy6Wj73FEMGSKvjPAOkedcBCKI/NprU7jUHSbeS9IKJH0Qm5pMoKX/ToFWebaYNUbZO7/kKElRHVtDi75lUNmUl/k+HqTnuaSQJQQ==;\n\t5:qqH+XKopK140fB1KHi90Ya7bpdtL4eX7rhn3C+yzZEjhLv/e2FLVAx1h/XLx8YwdraA9So0YIwZuJ1Ze2CtZY58goVRotivoR0X4hYLW1n3NRRccph1YxBpKtuadDoOBv0WEX3yJImPrdwUzBPVnTw==;\n\t24:ive3cGDysFjFOOATa/KETaMy/VR7aa3w6JZvkX3v6BrCfQTaQPMz93qq94HZSdTI5KHiGPqLTWT7sTTPq9unG38CpjVgoCZsA6W0kt+MC0A=;\n\t7:UZqWtl3CfTS8hr3q7JEmifacQXQ/KDRlNXLWJpQNqp1ZOCpY168MoPMVs6apqA1RMnI2kE+5C1o6WDdnrjDkzFImuyd+CmD4aiXbluBooT99LombxQnmlPgM7OpZbDntj4yDfwmxen1orWqjPCZtq7Tuqhv2TmpcNtlVjZ22vh8TjJkPREyI8URhAqU8S9t/GbgoPqHVdMN08YxiHmMIocIHmT121fTjoVCs0DvNKpk="],"MIME-Version":"1.0","Content-Type":"text/plain","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"5d120855-4d97-49a6-bc6c-08d4fed56be1","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CO2PR03MB2359; ","X-MS-TrafficTypeDiagnostic":"CO2PR03MB2359:","X-Exchange-Antispam-Report-Test":"UriScan:(185117386973197)(788757137089);","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6096035)(20161123559100)(20161123563025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123565025)(20161123556025)(20161123561025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CO2PR03MB2359; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CO2PR03MB2359; ","X-Forefront-PRVS":"04347F8039","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"18 Sep 2017 20:39:55.5811\n\t(UTC)","X-MS-Exchange-CrossTenant-Id":"5afe0b00-7697-4969-b663-5eab37d5f47e","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[192.88.168.50]; \n\tHelo=[tx30smr01.am.freescale.net]","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CO2PR03MB2359","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"roy.pledge@nxp.com","Cc":"mark.rutland@arm.com, arnd@arndb.de, madalin.bucur@nxp.com,\n\tcatalin.marinas@arm.com, Roy Pledge ,\n\tlinux@armlinux.org.uk, oss@buserror.net,\n\tClaudiu Manoil ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"From: Madalin Bucur \n\nReplace PPC specific set/clear_bits API with standard\nbit twiddling so driver is portalable outside PPC.\n\nSigned-off-by: Madalin Bucur \nSigned-off-by: Claudiu Manoil \nSigned-off-by: Roy Pledge \n---\n drivers/soc/fsl/qbman/bman.c | 2 +-\n drivers/soc/fsl/qbman/qman.c | 8 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/soc/fsl/qbman/bman.c b/drivers/soc/fsl/qbman/bman.c\nindex 604e45c..ff8998f 100644\n--- a/drivers/soc/fsl/qbman/bman.c\n+++ b/drivers/soc/fsl/qbman/bman.c\n@@ -616,7 +616,7 @@ int bman_p_irqsource_add(struct bman_portal *p, u32 bits)\n \tunsigned long irqflags;\n \n \tlocal_irq_save(irqflags);\n-\tset_bits(bits & BM_PIRQ_VISIBLE, &p->irq_sources);\n+\tp->irq_sources |= bits & BM_PIRQ_VISIBLE;\n \tbm_out(&p->p, BM_REG_IER, p->irq_sources);\n \tlocal_irq_restore(irqflags);\n \treturn 0;\ndiff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c\nindex 1bcfc51..25419e1 100644\n--- a/drivers/soc/fsl/qbman/qman.c\n+++ b/drivers/soc/fsl/qbman/qman.c\n@@ -908,12 +908,12 @@ static inline int qm_mc_result_timeout(struct qm_portal *portal,\n \n static inline void fq_set(struct qman_fq *fq, u32 mask)\n {\n-\tset_bits(mask, &fq->flags);\n+\tfq->flags |= mask;\n }\n \n static inline void fq_clear(struct qman_fq *fq, u32 mask)\n {\n-\tclear_bits(mask, &fq->flags);\n+\tfq->flags &= ~mask;\n }\n \n static inline int fq_isset(struct qman_fq *fq, u32 mask)\n@@ -1574,7 +1574,7 @@ void qman_p_irqsource_add(struct qman_portal *p, u32 bits)\n \tunsigned long irqflags;\n \n \tlocal_irq_save(irqflags);\n-\tset_bits(bits & QM_PIRQ_VISIBLE, &p->irq_sources);\n+\tp->irq_sources |= bits & QM_PIRQ_VISIBLE;\n \tqm_out(&p->p, QM_REG_IER, p->irq_sources);\n \tlocal_irq_restore(irqflags);\n }\n@@ -1597,7 +1597,7 @@ void qman_p_irqsource_remove(struct qman_portal *p, u32 bits)\n \t */\n \tlocal_irq_save(irqflags);\n \tbits &= QM_PIRQ_VISIBLE;\n-\tclear_bits(bits, &p->irq_sources);\n+\tp->irq_sources &= ~bits;\n \tqm_out(&p->p, QM_REG_IER, p->irq_sources);\n \tier = qm_in(&p->p, QM_REG_IER);\n \t/*\n","prefixes":["v5","05/12"]}