{"id":815055,"url":"http://patchwork.ozlabs.org/api/patches/815055/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170918174801.31792-1-robdclark@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918174801.31792-1-robdclark@gmail.com>","list_archive_url":null,"date":"2017-09-18T17:47:58","name":"[U-Boot] efi_loader: EFI entry point should be EFIAPI","commit_ref":null,"pull_url":null,"state":"deferred","archived":false,"hash":"1ea42b189201166e7f96cfa2d0728dd2cecba08f","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/?format=json","name":"Rob Clark","email":"robdclark@gmail.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170918174801.31792-1-robdclark@gmail.com/mbox/","series":[{"id":3690,"url":"http://patchwork.ozlabs.org/api/series/3690/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3690","date":"2017-09-18T17:47:58","name":"[U-Boot] efi_loader: EFI entry point should be EFIAPI","version":1,"mbox":"http://patchwork.ozlabs.org/series/3690/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815055/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815055/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vOck9m86\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwtlS127pz9s06\n\tfor ;\n\tTue, 19 Sep 2017 03:48:18 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 8CCF3C21C62; Mon, 18 Sep 2017 17:48:11 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id AE64FC21C4C;\n\tMon, 18 Sep 2017 17:48:08 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7C21EC21C41; Mon, 18 Sep 2017 17:48:07 +0000 (UTC)","from mail-qk0-f195.google.com (mail-qk0-f195.google.com\n\t[209.85.220.195])\n\tby lists.denx.de (Postfix) with ESMTPS id F2C4AC21C2B\n\tfor ; Mon, 18 Sep 2017 17:48:06 +0000 (UTC)","by mail-qk0-f195.google.com with SMTP id r66so782548qke.4\n\tfor ; Mon, 18 Sep 2017 10:48:06 -0700 (PDT)","from localhost ([144.121.20.163]) by smtp.gmail.com with ESMTPSA id\n\ts66sm5370335qkc.8.2017.09.18.10.48.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 18 Sep 2017 10:48:04 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=iaO37GZ8kOoy7iC1VbXK+uUgHlF2EzPzkl6DgLQz0LQ=;\n\tb=vOck9m86ZICWUWAKyNEGGo1bdfXc5Scq5EO41QoBmPzFEI2T2wK8+L9ym7gkx/H/W7\n\t/8JbFuK5xQTdarqvjKGU3pNKMI2jutiLr1aTr1kU4UTSIcjhuR/eBx/gQUbF9mU+bFWs\n\tjhr0mS94j4jKVwXG6OW5qekt/lR3JVNijPNHd4Vav9nThuymvCVBaPaPf1nXh4PMBsfC\n\tK9w7sk6ZjDwo/YWqu08f4kFiuMZ+ZmXx5b4swmDIQ+C6z/KzFQpKb5uv28NPPa3IpxLj\n\tzTMSrXOWsgCKw+wJoDKTSIG1TNxt36O+LQQGJC4lLsQVavB99xpq0ilfWqjX1P8FxolB\n\t75Rw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=iaO37GZ8kOoy7iC1VbXK+uUgHlF2EzPzkl6DgLQz0LQ=;\n\tb=jZv8yEK5z0PGNh+AtLj1WYSUB/u8ycAEvyaAfCbpgQHhum+XJWU/8Zzp8f03MHoUAR\n\tURR058XmNp5eAc/cCDM507WCnw8jptRqeI3mIYSTfn2pg7KCIMF/grPqz4jez8kvCGyV\n\tZYtiJRQsSc9iNDImtCRBUk+TY7lD378fpsotqnd0Ym/RpQyXZttdVjxijIzZysBvLS/B\n\t9baSdE1yV2dmZgjZXVDsk8yg89FjgHustktntiWUwS9qGBMrOtS1MHoSg+hd2QYsXi3P\n\tAciRvW9fCn68Q6B/4hgZq8iyPe6Vrn0KFKrSgOFufdTUXcAVSCiqwG1+rSOGsNY6ypgB\n\tc09g==","X-Gm-Message-State":"AHPjjUgUJjhR4/hvlNab/4A8L7UjHNGAKX9RmxlxcWxb/uCCCSde2f83\n\tPyB821P56s5udOdUWWE=","X-Google-Smtp-Source":"AOwi7QDQ1O835RyQH/NcVekDjCb7bzQi933PwHsmXVD9761pldk9xLBxKXilPv4ElytOELTY1aTuEg==","X-Received":"by 10.55.39.193 with SMTP id n184mr19987027qkn.273.1505756885269;\n\tMon, 18 Sep 2017 10:48:05 -0700 (PDT)","From":"Rob Clark ","To":"U-Boot Mailing List ","Date":"Mon, 18 Sep 2017 13:47:58 -0400","Message-Id":"<20170918174801.31792-1-robdclark@gmail.com>","X-Mailer":"git-send-email 2.13.5","Cc":"Heinrich Schuchardt ","Subject":"[U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"This is needed to run 'bootefi' from sandbox. I suspect StartImage()\nmust have been broken too on x86.\n\nSigned-off-by: Rob Clark \n---\n cmd/bootefi.c | 2 +-\n include/efi.h | 2 +-\n lib/efi_loader/efi_boottime.c | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/cmd/bootefi.c b/cmd/bootefi.c\nindex fb8ba9be6a..3c9a466e20 100644\n--- a/cmd/bootefi.c\n+++ b/cmd/bootefi.c\n@@ -96,7 +96,7 @@ static void *copy_fdt(void *fdt)\n \n static ulong efi_do_enter(void *image_handle,\n \t\t\t struct efi_system_table *st,\n-\t\t\t asmlinkage ulong (*entry)(void *image_handle,\n+\t\t\t EFIAPI ulong (*entry)(void *image_handle,\n \t\t\t\tstruct efi_system_table *st))\n {\n \tefi_status_t ret = EFI_LOAD_ERROR;\ndiff --git a/include/efi.h b/include/efi.h\nindex 04e83220b4..47c2c8f398 100644\n--- a/include/efi.h\n+++ b/include/efi.h\n@@ -19,7 +19,7 @@\n #include \n #include \n \n-#ifdef CONFIG_EFI_STUB_64BIT\n+#if defined(CONFIG_EFI_STUB_64BIT) || defined(CONFIG_SANDBOX)\n /* EFI uses the Microsoft ABI which is not the default for GCC */\n #define EFIAPI __attribute__((ms_abi))\n #else\ndiff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\nindex 22bb95d738..3e10e6f6b5 100644\n--- a/lib/efi_loader/efi_boottime.c\n+++ b/lib/efi_loader/efi_boottime.c\n@@ -950,7 +950,7 @@ static efi_status_t EFIAPI efi_start_image(efi_handle_t image_handle,\n \t\t\t\t\t unsigned long *exit_data_size,\n \t\t\t\t\t s16 **exit_data)\n {\n-\tulong (*entry)(void *image_handle, struct efi_system_table *st);\n+\tEFIAPI ulong (*entry)(void *image_handle, struct efi_system_table *st);\n \tstruct efi_loaded_image *info = image_handle;\n \n \tEFI_ENTRY(\"%p, %p, %p\", image_handle, exit_data_size, exit_data);\n","prefixes":["U-Boot"]}