{"id":815046,"url":"http://patchwork.ozlabs.org/api/patches/815046/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170918171149.23792-2-swarren@wwwdotorg.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918171149.23792-2-swarren@wwwdotorg.org>","list_archive_url":null,"date":"2017-09-18T17:11:48","name":"[U-Boot,2/3] test/py: provide more information about test skip reason","commit_ref":"d5170448ae79581af973f447ba6077118999c963","pull_url":null,"state":"accepted","archived":false,"hash":"f0b4d24d3f7991ec7eb217dca066869ff8c62e2d","submitter":{"id":12517,"url":"http://patchwork.ozlabs.org/api/people/12517/?format=json","name":"Stephen Warren","email":"swarren@wwwdotorg.org"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170918171149.23792-2-swarren@wwwdotorg.org/mbox/","series":[{"id":3685,"url":"http://patchwork.ozlabs.org/api/series/3685/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3685","date":"2017-09-18T17:11:47","name":"[U-Boot,1/3] test/py: Document required tools/packages","version":1,"mbox":"http://patchwork.ozlabs.org/series/3685/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815046/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815046/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwsyP36dYz9s7M\n\tfor ;\n\tTue, 19 Sep 2017 03:12:45 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 32C2FC21C57; Mon, 18 Sep 2017 17:12:15 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 18E2AC21D5F;\n\tMon, 18 Sep 2017 17:11:56 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid AA601C21C41; Mon, 18 Sep 2017 17:11:54 +0000 (UTC)","from avon.wwwdotorg.org (avon.wwwdotorg.org [104.237.132.123])\n\tby lists.denx.de (Postfix) with ESMTPS id 2A80BC21C2B\n\tfor ; Mon, 18 Sep 2017 17:11:54 +0000 (UTC)","from swarren-lx1.nvidia.com (thunderhill.nvidia.com\n\t[216.228.112.22])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby avon.wwwdotorg.org (Postfix) with ESMTPSA id 9544B1C0361;\n\tMon, 18 Sep 2017 11:11:52 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","X-Virus-Status":"Clean","X-Virus-Scanned":"clamav-milter 0.99.2 at avon.wwwdotorg.org","From":"Stephen Warren ","To":"Tom Rini ","Date":"Mon, 18 Sep 2017 11:11:48 -0600","Message-Id":"<20170918171149.23792-2-swarren@wwwdotorg.org>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170918171149.23792-1-swarren@wwwdotorg.org>","References":"<20170918171149.23792-1-swarren@wwwdotorg.org>","X-NVConfidentiality":"public","Cc":"Alison Chaiken , u-boot@lists.denx.de,\n\tStephen Warren ","Subject":"[U-Boot] [PATCH 2/3] test/py: provide more information about test\n\tskip reason","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"From: Stephen Warren \n\nWhen skipping tests, explicitly mention the board type or config option\nthat caused the skip. This will help people understand/fix any issues.\n\nSigned-off-by: Stephen Warren \n---\n test/py/conftest.py | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/test/py/conftest.py b/test/py/conftest.py\nindex 65e1d75626cf..e2fc7fd7ef78 100644\n--- a/test/py/conftest.py\n+++ b/test/py/conftest.py\n@@ -429,12 +429,12 @@ def setup_boardspec(item):\n for board in mark.args:\n if board.startswith('!'):\n if ubconfig.board_type == board[1:]:\n- pytest.skip('board not supported')\n+ pytest.skip('board \"%s\" not supported' % ubconfig.board_type)\n return\n else:\n required_boards.append(board)\n if required_boards and ubconfig.board_type not in required_boards:\n- pytest.skip('board not supported')\n+ pytest.skip('board \"%s\" not supported' % ubconfig.board_type)\n \n def setup_buildconfigspec(item):\n \"\"\"Process any 'buildconfigspec' marker for a test.\n@@ -455,7 +455,7 @@ def setup_buildconfigspec(item):\n return\n for option in mark.args:\n if not ubconfig.buildconfig.get('config_' + option.lower(), None):\n- pytest.skip('.config feature not enabled')\n+ pytest.skip('.config feature \"%s\" not enabled' % option.lower())\n \n def start_test_section(item):\n anchors[item.name] = log.start_section(item.name)\n","prefixes":["U-Boot","2/3"]}