{"id":815035,"url":"http://patchwork.ozlabs.org/api/patches/815035/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170918220225.3767-3-Nisar.Sayed@microchip.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918220225.3767-3-Nisar.Sayed@microchip.com>","list_archive_url":null,"date":"2017-09-18T22:02:24","name":"[v4,net,2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"3cbd4a6dc2884752e97d9c61b958fb58b41f46e2","submitter":{"id":71648,"url":"http://patchwork.ozlabs.org/api/people/71648/?format=json","name":"Nisar Sayed","email":"Nisar.Sayed@microchip.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170918220225.3767-3-Nisar.Sayed@microchip.com/mbox/","series":[{"id":3678,"url":"http://patchwork.ozlabs.org/api/series/3678/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3678","date":"2017-09-18T22:02:22","name":"lan78xx: This series of patches are for lan78xx driver.","version":4,"mbox":"http://patchwork.ozlabs.org/series/3678/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815035/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815035/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwsDZ3tJ6z9s72\n\tfor ;\n\tTue, 19 Sep 2017 02:39:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932826AbdIRQjz (ORCPT );\n\tMon, 18 Sep 2017 12:39:55 -0400","from esa2.microchip.iphmx.com ([68.232.149.84]:58591 \"EHLO\n\tesa2.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932672AbdIRQjz (ORCPT\n\t); Mon, 18 Sep 2017 12:39:55 -0400","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa2.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t18 Sep 2017 09:39:54 -0700","from ungdev1-OptiPlex-990.microchip.com (10.10.76.4) by\n\tchn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server\n\tid 14.3.352.0; Mon, 18 Sep 2017 09:39:53 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,413,1500966000\"; d=\"scan'208\";a=\"7081964\"","From":"Nisar Sayed ","To":"","CC":", ","Subject":"[PATCH v4 net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","Date":"Tue, 19 Sep 2017 03:32:24 +0530","Message-ID":"<20170918220225.3767-3-Nisar.Sayed@microchip.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170918220225.3767-1-Nisar.Sayed@microchip.com>","References":"<20170918220225.3767-1-Nisar.Sayed@microchip.com>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Allow EEPROM write for less than MAX_EEPROM_SIZE\n\nFixes: 55d7de9de6c3 (\"Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver\")\nSigned-off-by: Nisar Sayed \n---\n drivers/net/usb/lan78xx.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c\nindex fcf85ae37435..3292f56ffe02 100644\n--- a/drivers/net/usb/lan78xx.c\n+++ b/drivers/net/usb/lan78xx.c\n@@ -1290,11 +1290,10 @@ static int lan78xx_ethtool_set_eeprom(struct net_device *netdev,\n \tif (ret)\n \t\treturn ret;\n \n-\t/* Allow entire eeprom update only */\n-\tif ((ee->magic == LAN78XX_EEPROM_MAGIC) &&\n-\t (ee->offset == 0) &&\n-\t (ee->len == 512) &&\n-\t (data[0] == EEPROM_INDICATOR))\n+\t/* Invalid EEPROM_INDICATOR at offset zero will result in fail to\n+\t * load data from EEPROM\n+\t */\n+\tif (ee->magic == LAN78XX_EEPROM_MAGIC)\n \t\tret = lan78xx_write_raw_eeprom(dev, ee->offset, ee->len, data);\n \telse if ((ee->magic == LAN78XX_OTP_MAGIC) &&\n \t\t (ee->offset == 0) &&\n","prefixes":["v4","net","2/3"]}