{"id":815031,"url":"http://patchwork.ozlabs.org/api/patches/815031/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1505752137-15522-2-git-send-email-jbacik@fb.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505752137-15522-2-git-send-email-jbacik@fb.com>","list_archive_url":null,"date":"2017-09-18T16:28:55","name":"[1/3] net: set tb->fast_sk_family","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"c63e54edafa778ec020c44d28372a8571a28fae3","submitter":{"id":72383,"url":"http://patchwork.ozlabs.org/api/people/72383/?format=json","name":"Josef Bacik","email":"josef@toxicpanda.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1505752137-15522-2-git-send-email-jbacik@fb.com/mbox/","series":[{"id":3676,"url":"http://patchwork.ozlabs.org/api/series/3676/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3676","date":"2017-09-18T16:28:56","name":"fix reuseaddr regression","version":1,"mbox":"http://patchwork.ozlabs.org/series/3676/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815031/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815031/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=toxicpanda-com.20150623.gappssmtp.com\n\theader.i=@toxicpanda-com.20150623.gappssmtp.com\n\theader.b=\"ENe2GYhk\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xws1Z2WBrz9s78\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 19 Sep 2017 02:30:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932528AbdIRQaN (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 18 Sep 2017 12:30:13 -0400","from mail-qk0-f196.google.com ([209.85.220.196]:36680 \"EHLO\n\tmail-qk0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1756128AbdIRQ3H (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 18 Sep 2017 12:29:07 -0400","by mail-qk0-f196.google.com with SMTP id i14so652663qke.3\n\tfor <netdev@vger.kernel.org>; Mon, 18 Sep 2017 09:29:07 -0700 (PDT)","from localhost ([2606:a000:4381:1201:225:22ff:feb3:e51a])\n\tby smtp.gmail.com with ESMTPSA id\n\tk2sm5391850qth.39.2017.09.18.09.29.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 09:29:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=toxicpanda-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ODHOSh6qUo5hELVhTe8eR0nzAZGayCpVsYmm8L/WRYo=;\n\tb=ENe2GYhkGM4Il80mssfcqrqzQSZPDH2Xa0ebb06V1ZqcccFxSC7a5LpUB7IkKNefkT\n\tTZyuI+aF4S2uLsHd/tPXfxmsQBvdD/eALqo1B56G0ZjFtkz2ph33rt7QRWGodJHPyee/\n\t3GPxAJgQQHXqxUsWuSltwwzppZZ+J7J327QSQqO9yS6K9egg7GQxrf6dxh00Wa55dIcP\n\t03NlT1mnNxoQLvi56oFV1JiX/uwa6lT71XHLmtogSq7U8s8S10qNvbFsFhFfybn6UXJy\n\t7IbH+/w3C7A9z7fZQVeDkOE9Xxu/rdtFYhTL1kqqPYh1QoJYAmoTjDKJMVPmGeDHbHJI\n\tC8Ag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=ODHOSh6qUo5hELVhTe8eR0nzAZGayCpVsYmm8L/WRYo=;\n\tb=iIKm7kENZgOf97y8ajgoofG5iX3X/CEPewUk//zQJOIjuKvEvURFEP8/EMMLyB7JGt\n\tIGeIFi4q/pho0ltiG6tZzYM3AL1w491lhPZjMTCGY3yB9sz7aw6pU8kvM9zc5hpgJZA3\n\tDJagBPdxuSeB97GEKYjNjmBXeJFU2O00EHy2pDq6AeDmfF8iK3dyCOLBhyz2in5CYM8c\n\tIEjujgPXz+og20JlejZMVWnxia1u5yMfokqJ0Eh+mrLwttWqoXDAKPLyA2T9y+0LFd54\n\tLWx5yu+Ucb3144uHp7fcxylLa7yAdNoJqy7q1sWHx4YiN9yF5dma4VAoflOMOZ55xbFF\n\tTk5w==","X-Gm-Message-State":"AHPjjUheXdavXGwZJzrDEwF349Qxa/ZnTTmOrnfShChshtQvZ19DH6nj\n\t+Mdpx409DprOzRj8","X-Google-Smtp-Source":"AOwi7QAuxfJvy3r7jyUd57ynObSsn0+hfsRrwzMj7mgjZm7nl6+qi+hVIo0j9U+OP9IBDMjkCvJjKA==","X-Received":"by 10.55.167.135 with SMTP id\n\tq129mr20574530qke.311.1505752147013; \n\tMon, 18 Sep 2017 09:29:07 -0700 (PDT)","From":"josef@toxicpanda.com","X-Google-Original-From":"jbacik@fb.com","To":"davem@davemloft.net, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, crobinso@redhat.com,\n\tlabbott@redhat.com, kernel-team@fb.com","Cc":"Josef Bacik <jbacik@fb.com>, stable@vger.kernel.org","Subject":"[PATCH 1/3] net: set tb->fast_sk_family","Date":"Mon, 18 Sep 2017 12:28:55 -0400","Message-Id":"<1505752137-15522-2-git-send-email-jbacik@fb.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","References":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Josef Bacik <jbacik@fb.com>\n\nWe need to set the tb->fast_sk_family properly so we can use the proper\ncomparison function for all subsequent reuseport bind requests.\n\nCc: stable@vger.kernel.org\nFixes: 637bc8bbe6c0 (\"inet: reset tb->fastreuseport when adding a reuseport sk\")\nReported-and-tested-by: Cole Robinson <crobinso@redhat.com>\nSigned-off-by: Josef Bacik <jbacik@fb.com>\n---\n net/ipv4/inet_connection_sock.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c\nindex b9c64b40a83a..f87f4805e244 100644\n--- a/net/ipv4/inet_connection_sock.c\n+++ b/net/ipv4/inet_connection_sock.c\n@@ -328,6 +328,7 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum)\n \t\t\ttb->fastuid = uid;\n \t\t\ttb->fast_rcv_saddr = sk->sk_rcv_saddr;\n \t\t\ttb->fast_ipv6_only = ipv6_only_sock(sk);\n+\t\t\ttb->fast_sk_family = sk->sk_family;\n #if IS_ENABLED(CONFIG_IPV6)\n \t\t\ttb->fast_v6_rcv_saddr = sk->sk_v6_rcv_saddr;\n #endif\n@@ -354,6 +355,7 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum)\n \t\t\t\ttb->fastuid = uid;\n \t\t\t\ttb->fast_rcv_saddr = sk->sk_rcv_saddr;\n \t\t\t\ttb->fast_ipv6_only = ipv6_only_sock(sk);\n+\t\t\t\ttb->fast_sk_family = sk->sk_family;\n #if IS_ENABLED(CONFIG_IPV6)\n \t\t\t\ttb->fast_v6_rcv_saddr = sk->sk_v6_rcv_saddr;\n #endif\n","prefixes":["1/3"]}