{"id":815029,"url":"http://patchwork.ozlabs.org/api/patches/815029/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1505752137-15522-4-git-send-email-jbacik@fb.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505752137-15522-4-git-send-email-jbacik@fb.com>","list_archive_url":null,"date":"2017-09-18T16:28:57","name":"[3/3] inet: fix improper empty comparison","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"d395fd825056714e5558638dd77e41ef771a6bf7","submitter":{"id":72383,"url":"http://patchwork.ozlabs.org/api/people/72383/?format=json","name":"Josef Bacik","email":"josef@toxicpanda.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1505752137-15522-4-git-send-email-jbacik@fb.com/mbox/","series":[{"id":3676,"url":"http://patchwork.ozlabs.org/api/series/3676/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3676","date":"2017-09-18T16:28:56","name":"fix reuseaddr regression","version":1,"mbox":"http://patchwork.ozlabs.org/series/3676/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815029/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815029/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=toxicpanda-com.20150623.gappssmtp.com\n\theader.i=@toxicpanda-com.20150623.gappssmtp.com\n\theader.b=\"ekVuIHzi\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xws0V29gwz9s78\n\tfor ;\n\tTue, 19 Sep 2017 02:29:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932340AbdIRQ32 (ORCPT );\n\tMon, 18 Sep 2017 12:29:28 -0400","from mail-qt0-f195.google.com ([209.85.216.195]:35457 \"EHLO\n\tmail-qt0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1756173AbdIRQ3K (ORCPT\n\t); Mon, 18 Sep 2017 12:29:10 -0400","by mail-qt0-f195.google.com with SMTP id l25so680855qtf.2\n\tfor ; Mon, 18 Sep 2017 09:29:09 -0700 (PDT)","from localhost ([2606:a000:4381:1201:225:22ff:feb3:e51a])\n\tby smtp.gmail.com with ESMTPSA id\n\tz22sm2474536qti.36.2017.09.18.09.29.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 09:29:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=toxicpanda-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=0rcRClRC3qnl2/rom1PyTyohoWPGq9jysd+zMNEJRXo=;\n\tb=ekVuIHzizfgfF427R7uJEF4gX14ZjRitED7aUCPRqYnbB3Zcgw3HI0II2/vZL5cpEE\n\tm/oFiNpV79138Y1skwcIOdJU0wBn0whKK3Yu08U2fsTwwOHQB1+7IVU5yyTnpespY6Mt\n\tme+gZ9SVaJTy7CmgTRMP866uFA3E5fH8dawQhWLdBby4JYzkXs3zond0G3IWSC3RPlWg\n\tbV5oW9l/aWV/qucv144oIED1Tn+jBv5sVC7IQXAQhss3S3LFI/8QU6WvqyV5Z5HrovcJ\n\t782nRHynFZtotiuaeXlcl9kRJpju5vS94f2SH14kT87KLUhsilx2mNJCk79a6FtTjGZk\n\tAgEQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=0rcRClRC3qnl2/rom1PyTyohoWPGq9jysd+zMNEJRXo=;\n\tb=HT/Fycxnz0yXXFMaulcSoAiVAxZbVmJJ6VNqtDbjVvMdKckdk1X1JOnH3EoEvpSywT\n\tLEgjHs5xdap9lFO2mOhiMuwkMl4N/w7LM2XfPC6vChyQQDEymrqO6eLMcQS3JINhnsyF\n\toPyapdNsutHsxvTAU11Xurcx+YTm11kw0bdUu9Wz1hwFjj4VLVt3cQyytnFjP8Kq0UAF\n\tqYLXo2W1KN8RSg69tMpZnuhp/phvWw5WhwiLfmX+UgJbf04beKlDClWosCkQSBrBy+h2\n\taGPvFzR79Qg5W4jmeN4C/M8AtyopMYKK8/hUhyB0YqktuphhY6oUhSu7qOSqku/aQNKz\n\tHvAQ==","X-Gm-Message-State":"AHPjjUgpc8GTbKDIaAfV9+wwjC4ThPqTJ4eJOIpcbrBQM9lyM5VumA7Y\n\t2R3Wc9TmXWlT9wlJ","X-Google-Smtp-Source":"AOwi7QDS5+QDiLuRKKsIvjAsuqz+2aQEqJl1VMB2DNMEZKi0I51UdvY/+3LuqzOvDhfQ1IHKHJ6I4Q==","X-Received":"by 10.200.17.23 with SMTP id c23mr31692634qtj.74.1505752149318; \n\tMon, 18 Sep 2017 09:29:09 -0700 (PDT)","From":"josef@toxicpanda.com","X-Google-Original-From":"jbacik@fb.com","To":"davem@davemloft.net, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, crobinso@redhat.com,\n\tlabbott@redhat.com, kernel-team@fb.com","Cc":"Josef Bacik , stable@vger.kernel.org","Subject":"[PATCH 3/3] inet: fix improper empty comparison","Date":"Mon, 18 Sep 2017 12:28:57 -0400","Message-Id":"<1505752137-15522-4-git-send-email-jbacik@fb.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","References":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Josef Bacik \n\nWhen doing my reuseport rework I screwed up and changed a\n\nif (hlist_empty(&tb->owners))\n\nto\n\nif (!hlist_empty(&tb->owners))\n\nThis is obviously bad as all of the reuseport/reuse logic was reversed,\nwhich caused weird problems like allowing an ipv4 bind conflict if we\nopened an ipv4 only socket on a port followed by an ipv6 only socket on\nthe same port.\n\nCc: stable@vger.kernel.org\nFixes: b9470c27607b (\"inet: kill smallest_size and smallest_port\")\nReported-by: Cole Robinson \nSigned-off-by: Josef Bacik \n---\n net/ipv4/inet_connection_sock.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c\nindex a1bf30438bc5..c039c937ba90 100644\n--- a/net/ipv4/inet_connection_sock.c\n+++ b/net/ipv4/inet_connection_sock.c\n@@ -321,7 +321,7 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum)\n \t\t\tgoto fail_unlock;\n \t}\n success:\n-\tif (!hlist_empty(&tb->owners)) {\n+\tif (hlist_empty(&tb->owners)) {\n \t\ttb->fastreuse = reuse;\n \t\tif (sk->sk_reuseport) {\n \t\t\ttb->fastreuseport = FASTREUSEPORT_ANY;\n","prefixes":["3/3"]}