{"id":815028,"url":"http://patchwork.ozlabs.org/api/patches/815028/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1505752137-15522-3-git-send-email-jbacik@fb.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505752137-15522-3-git-send-email-jbacik@fb.com>","list_archive_url":null,"date":"2017-09-18T16:28:56","name":"[2/3] net: use inet6_rcv_saddr to compare sockets","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"4ff6389534adf26c6945ad693ea5f341bfb6b04a","submitter":{"id":72383,"url":"http://patchwork.ozlabs.org/api/people/72383/?format=json","name":"Josef Bacik","email":"josef@toxicpanda.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1505752137-15522-3-git-send-email-jbacik@fb.com/mbox/","series":[{"id":3676,"url":"http://patchwork.ozlabs.org/api/series/3676/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3676","date":"2017-09-18T16:28:56","name":"fix reuseaddr regression","version":1,"mbox":"http://patchwork.ozlabs.org/series/3676/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815028/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815028/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=toxicpanda-com.20150623.gappssmtp.com\n\theader.i=@toxicpanda-com.20150623.gappssmtp.com\n\theader.b=\"rEBJ6YA6\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xws0N0yDCz9s78\n\tfor ;\n\tTue, 19 Sep 2017 02:29:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932242AbdIRQ3K (ORCPT );\n\tMon, 18 Sep 2017 12:29:10 -0400","from mail-qk0-f194.google.com ([209.85.220.194]:37024 \"EHLO\n\tmail-qk0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1756168AbdIRQ3I (ORCPT\n\t); Mon, 18 Sep 2017 12:29:08 -0400","by mail-qk0-f194.google.com with SMTP id r66so646927qke.4\n\tfor ; Mon, 18 Sep 2017 09:29:08 -0700 (PDT)","from localhost ([2606:a000:4381:1201:225:22ff:feb3:e51a])\n\tby smtp.gmail.com with ESMTPSA id\n\tz192sm5288781qka.91.2017.09.18.09.29.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 09:29:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=toxicpanda-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Vhnzd/4WAbdv6NuJHquUj0iLDFDznzqNv4gLtqcmNek=;\n\tb=rEBJ6YA6LtVJ3Vs6VbKiU/KWlYYi6hfiRkcJYGbqclmOjYI052r6008sP6utdA0nqz\n\tOak88Px0LZXzSccJNQ/SmToqcZvZhV9hZMp0xupxGunVHdip02f5q9rKpvzCl8u8qxZI\n\tGovUmQD3STkiQeIDfV/q49Jw71lFROBEjCU+SJh/K6/vitg9IBdVTHmiLsRKV0aalOQS\n\tWGHxUn4OmdottTIjAkghnJPwj6ji/Geo82wFrtal1EuYmoRln/O6mExGMhEX//KN3U/9\n\tHDo+OUKGEWz3rTEXb831MMZcM8zmIbsrEqK2Dqm7OhKFlKtY8lBTyWRG5WtLzgpdwtMT\n\tSKTQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Vhnzd/4WAbdv6NuJHquUj0iLDFDznzqNv4gLtqcmNek=;\n\tb=Yzk2jSS+bH3eyFm5tNGDci51yfcg/vwHwQiQoTy4qiptPNBnnW9JWUmp9B5wFl5Kku\n\t+WpP1sFEc62orEa4lC0gKwwwynmJygyOQIYguTYNjCHCs+Fs0VL451QwYXjxnYeBZ8Fz\n\tmRZk7N585nl/4ZO6L0DVEf06iTsn9ptePYgykf9ScvplnvrHELfqwCv/Ov7LoXWG5qLo\n\tZ8/S2FC+A8N6zykg7e4Fjc065FPz/v7YhKJ/8lFI1tLikSwChIO8erQUAWMjUoLVU99W\n\t4uVzGW33fXPl0IX9WTARA0UJUKqlFnWI5DnoIUDXYumRA5YoWBrI+OzcIwosWZQeuM+G\n\tNo3g==","X-Gm-Message-State":"AHPjjUjTc2BZQWTD5rXpUrsETt5Sx2JTqr6beKtuvLAUeD9sbEHBsnv2\n\tYW/5Jcb5Bci7EPDanDp6yA==","X-Google-Smtp-Source":"AOwi7QA8TxbvQQnM8H7VBhy9a9KrOzZk3nKucCauGFkdHhAyMuaol5WCh/fQSqwLjaFOSj/7UreKNA==","X-Received":"by 10.55.167.135 with SMTP id\n\tq129mr20574616qke.311.1505752148156; \n\tMon, 18 Sep 2017 09:29:08 -0700 (PDT)","From":"josef@toxicpanda.com","X-Google-Original-From":"jbacik@fb.com","To":"davem@davemloft.net, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, crobinso@redhat.com,\n\tlabbott@redhat.com, kernel-team@fb.com","Cc":"Josef Bacik , stable@vger.kernel.org","Subject":"[PATCH 2/3] net: use inet6_rcv_saddr to compare sockets","Date":"Mon, 18 Sep 2017 12:28:56 -0400","Message-Id":"<1505752137-15522-3-git-send-email-jbacik@fb.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","References":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Josef Bacik \n\nIn ipv6_rcv_saddr_equal() we need to use inet6_rcv_saddr(sk) for the\nipv6 compare with the fast socket information to make sure we're doing\nthe proper comparisons.\n\nCc: stable@vger.kernel.org\nFixes: 637bc8bbe6c0 (\"inet: reset tb->fastreuseport when adding a reuseport sk\")\nReported-and-tested-by: Cole Robinson \nSigned-off-by: Josef Bacik \n---\n net/ipv4/inet_connection_sock.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c\nindex f87f4805e244..a1bf30438bc5 100644\n--- a/net/ipv4/inet_connection_sock.c\n+++ b/net/ipv4/inet_connection_sock.c\n@@ -266,7 +266,7 @@ static inline int sk_reuseport_match(struct inet_bind_bucket *tb,\n #if IS_ENABLED(CONFIG_IPV6)\n \tif (tb->fast_sk_family == AF_INET6)\n \t\treturn ipv6_rcv_saddr_equal(&tb->fast_v6_rcv_saddr,\n-\t\t\t\t\t &sk->sk_v6_rcv_saddr,\n+\t\t\t\t\t inet6_rcv_saddr(sk),\n \t\t\t\t\t tb->fast_rcv_saddr,\n \t\t\t\t\t sk->sk_rcv_saddr,\n \t\t\t\t\t tb->fast_ipv6_only,\n","prefixes":["2/3"]}