{"id":815007,"url":"http://patchwork.ozlabs.org/api/patches/815007/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918160012.4317-8-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918160012.4317-8-david@redhat.com>","list_archive_url":null,"date":"2017-09-18T15:59:52","name":"[v1,07/27] s390x/tcg: STOPPED cpus can never wake up","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3a0f3fc8ba7d4350fa0585c5b05e19218e1d88e8","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918160012.4317-8-david@redhat.com/mbox/","series":[{"id":3672,"url":"http://patchwork.ozlabs.org/api/series/3672/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3672","date":"2017-09-18T15:59:45","name":"s390x: SMP for TCG (+ cleanups)","version":1,"mbox":"http://patchwork.ozlabs.org/series/3672/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815007/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815007/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwrbX3vcHz9s78\n\tfor ;\n\tTue, 19 Sep 2017 02:11:20 +1000 (AEST)","from localhost ([::1]:37623 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtydg-0006qh-MO\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 12:11:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37422)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtyTw-0006yU-QY\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:01:17 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtyTt-0007rd-2T\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:01:12 -0400","from mx1.redhat.com ([209.132.183.28]:43622)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtyTs-0007rE-TC\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:01:09 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D16DA3B752;\n\tMon, 18 Sep 2017 16:01:07 +0000 (UTC)","from t460s.redhat.com (unknown [10.36.118.72])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A35505D6A8;\n\tMon, 18 Sep 2017 16:01:03 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D16DA3B752","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","Date":"Mon, 18 Sep 2017 17:59:52 +0200","Message-Id":"<20170918160012.4317-8-david@redhat.com>","In-Reply-To":"<20170918160012.4317-1-david@redhat.com>","References":"<20170918160012.4317-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 18 Sep 2017 16:01:08 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v1 07/27] s390x/tcg: STOPPED cpus can never\n\twake up","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tdavid@redhat.com, cohuck@redhat.com, Richard Henderson\n\t, Alexander Graf ,\n\tborntraeger@de.ibm.com, \tIgor Mammedov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Interrupts can't wake such CPUs up. SIGP from other CPUs has to be used\nto toggle the state.\n\nSigned-off-by: David Hildenbrand \n---\n target/s390x/cpu.c | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c\nindex f42e28ea25..64db086702 100644\n--- a/target/s390x/cpu.c\n+++ b/target/s390x/cpu.c\n@@ -58,6 +58,12 @@ static bool s390_cpu_has_work(CPUState *cs)\n S390CPU *cpu = S390_CPU(cs);\n CPUS390XState *env = &cpu->env;\n \n+ /* STOPPED cpus can never wake up */\n+ if (s390_cpu_get_state(cpu) != CPU_STATE_LOAD &&\n+ s390_cpu_get_state(cpu) != CPU_STATE_OPERATING) {\n+ return false;\n+ }\n+\n return (cs->interrupt_request & CPU_INTERRUPT_HARD) &&\n (env->psw.mask & PSW_MASK_EXT);\n }\n","prefixes":["v1","07/27"]}