{"id":815003,"url":"http://patchwork.ozlabs.org/api/patches/815003/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918160012.4317-2-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918160012.4317-2-david@redhat.com>","list_archive_url":null,"date":"2017-09-18T15:59:46","name":"[v1,01/27] s390x: raise CPU hotplug irq after really hotplugged","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5255545b492c3f13e1a9e1a774b7fc6aab74a03d","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918160012.4317-2-david@redhat.com/mbox/","series":[{"id":3672,"url":"http://patchwork.ozlabs.org/api/series/3672/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3672","date":"2017-09-18T15:59:45","name":"s390x: SMP for TCG (+ cleanups)","version":1,"mbox":"http://patchwork.ozlabs.org/series/3672/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815003/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815003/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwrXK4SBGz9s78\n\tfor ;\n\tTue, 19 Sep 2017 02:08:32 +1000 (AEST)","from localhost ([::1]:37609 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtyb0-0004VU-U6\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 12:08:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37208)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtyTe-0006j5-Uf\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:01:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtyTZ-0007iQ-7J\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:00:55 -0400","from mx1.redhat.com ([209.132.183.28]:52076)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtyTZ-0007i8-1O\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:00:49 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CF4A32CE918;\n\tMon, 18 Sep 2017 16:00:47 +0000 (UTC)","from t460s.redhat.com (unknown [10.36.118.72])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9AAE75D6A8;\n\tMon, 18 Sep 2017 16:00:30 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CF4A32CE918","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","Date":"Mon, 18 Sep 2017 17:59:46 +0200","Message-Id":"<20170918160012.4317-2-david@redhat.com>","In-Reply-To":"<20170918160012.4317-1-david@redhat.com>","References":"<20170918160012.4317-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tMon, 18 Sep 2017 16:00:48 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v1 01/27] s390x: raise CPU hotplug irq after\n\treally hotplugged","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tdavid@redhat.com, cohuck@redhat.com, Richard Henderson\n\t, Alexander Graf ,\n\tborntraeger@de.ibm.com, \tIgor Mammedov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Let's move it into the machine, so we trigger the IRQ after setting\nms->possible_cpus (which SCLP uses to construct the list of\nonline CPUs).\n\nSigned-off-by: David Hildenbrand \n---\n hw/s390x/s390-virtio-ccw.c | 4 ++++\n target/s390x/cpu.c | 8 --------\n 2 files changed, 4 insertions(+), 8 deletions(-)","diff":"diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\nindex 0471407187..d5a12a2472 100644\n--- a/hw/s390x/s390-virtio-ccw.c\n+++ b/hw/s390x/s390-virtio-ccw.c\n@@ -327,6 +327,10 @@ static void s390_cpu_plug(HotplugHandler *hotplug_dev,\n \n g_assert(!ms->possible_cpus->cpus[cpu->env.core_id].cpu);\n ms->possible_cpus->cpus[cpu->env.core_id].cpu = OBJECT(dev);\n+\n+ if (dev->hotplugged) {\n+ raise_irq_cpu_hotplug();\n+ }\n }\n \n static void s390_machine_reset(void)\ndiff --git a/target/s390x/cpu.c b/target/s390x/cpu.c\nindex 34538c3ab9..4920da3625 100644\n--- a/target/s390x/cpu.c\n+++ b/target/s390x/cpu.c\n@@ -41,7 +41,6 @@\n #include \"hw/hw.h\"\n #include \"sysemu/arch_init.h\"\n #include \"sysemu/sysemu.h\"\n-#include \"hw/s390x/sclp.h\"\n #endif\n \n #define CR0_RESET 0xE0UL\n@@ -227,13 +226,6 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n #endif\n \n scc->parent_realize(dev, &err);\n-\n-#if !defined(CONFIG_USER_ONLY)\n- if (dev->hotplugged) {\n- raise_irq_cpu_hotplug();\n- }\n-#endif\n-\n out:\n error_propagate(errp, err);\n }\n","prefixes":["v1","01/27"]}