{"id":815000,"url":"http://patchwork.ozlabs.org/api/patches/815000/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918160012.4317-14-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918160012.4317-14-david@redhat.com>","list_archive_url":null,"date":"2017-09-18T15:59:58","name":"[v1,13/27] target/s390x: proper cpu->be convertion in s390_store_status()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"37207ca2c67c6cb30b7718b67916ebd18ab38a3c","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918160012.4317-14-david@redhat.com/mbox/","series":[{"id":3672,"url":"http://patchwork.ozlabs.org/api/series/3672/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3672","date":"2017-09-18T15:59:45","name":"s390x: SMP for TCG (+ cleanups)","version":1,"mbox":"http://patchwork.ozlabs.org/series/3672/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815000/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815000/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwrT35p82z9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Sep 2017 02:05:43 +1000 (AEST)","from localhost ([::1]:37594 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dtyYH-0001rI-Sm\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 12:05:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37675)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dtyUL-0007Mp-Jt\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:01:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dtyUG-00084L-2K\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:01:37 -0400","from mx1.redhat.com ([209.132.183.28]:55370)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dtyUF-000841-TA\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:01:32 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CF4A12D0FAC;\n\tMon, 18 Sep 2017 16:01:30 +0000 (UTC)","from t460s.redhat.com (unknown [10.36.118.72])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 01EA35D6A8;\n\tMon, 18 Sep 2017 16:01:23 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CF4A12D0FAC","From":"David Hildenbrand <david@redhat.com>","To":"qemu-devel@nongnu.org","Date":"Mon, 18 Sep 2017 17:59:58 +0200","Message-Id":"<20170918160012.4317-14-david@redhat.com>","In-Reply-To":"<20170918160012.4317-1-david@redhat.com>","References":"<20170918160012.4317-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tMon, 18 Sep 2017 16:01:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v1 13/27] target/s390x: proper cpu->be\n\tconvertion in s390_store_status()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tdavid@redhat.com, cohuck@redhat.com, Richard Henderson\n\t<richard.henderson@linaro.org>, Alexander Graf <agraf@suse.de>,\n\tborntraeger@de.ibm.com, \tIgor Mammedov <imammedo@redhat.com>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n\tAurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"Necessary so TCG can also use it.\n\nSigned-off-by: David Hildenbrand <david@redhat.com>\n---\n target/s390x/helper.c | 27 +++++++++++++++++----------\n 1 file changed, 17 insertions(+), 10 deletions(-)","diff":"diff --git a/target/s390x/helper.c b/target/s390x/helper.c\nindex 09468f85fa..e44d54b932 100644\n--- a/target/s390x/helper.c\n+++ b/target/s390x/helper.c\n@@ -267,17 +267,24 @@ int s390_store_status(S390CPU *cpu, hwaddr addr, bool store_arch)\n         cpu_physical_memory_write(offsetof(LowCore, ar_access_id), &ar_id, 1);\n     }\n     for (i = 0; i < 16; ++i) {\n-        *((uint64_t *)mem + i) = get_freg(&cpu->env, i)->ll;\n+        *((uint64_t *)mem + i) = cpu_to_be64(get_freg(&cpu->env, i)->ll);\n+    }\n+    for (i = 0; i < 16; ++i) {\n+        *((uint64_t *)(mem + 128) + i) = cpu_to_be64(cpu->env.regs[i]);\n+    }\n+    *((uint64_t *)(mem + 256)) = cpu_to_be64(get_psw_mask(&cpu->env));\n+    *((uint64_t *)(mem + 264)) = cpu_to_be64(cpu->env.psw.addr);\n+    *((uint32_t *)(mem + 280)) = cpu_to_be32(cpu->env.psa);\n+    *((uint32_t *)(mem + 284)) = cpu_to_be32(cpu->env.fpc);\n+    *((uint32_t *)(mem + 292)) = cpu_to_be32(cpu->env.todpr);\n+    *((uint64_t *)(mem + 296)) = cpu_to_be64(cpu->env.cputm);\n+    *((uint64_t *)(mem + 304)) = cpu_to_be64(ckc);\n+    for (i = 0; i < 16; ++i) {\n+        *((uint32_t *)(mem + 320) + i) = cpu_to_be32(cpu->env.aregs[i]);\n+    }\n+    for (i = 0; i < 16; ++i) {\n+        *((uint64_t *)(mem + 384) + i) = cpu_to_be64(cpu->env.cregs[i]);\n     }\n-    memcpy(mem + 128, &cpu->env.regs, 128);\n-    memcpy(mem + 256, &cpu->env.psw, 16);\n-    memcpy(mem + 280, &cpu->env.psa, 4);\n-    memcpy(mem + 284, &cpu->env.fpc, 4);\n-    memcpy(mem + 292, &cpu->env.todpr, 4);\n-    memcpy(mem + 296, &cpu->env.cputm, 8);\n-    memcpy(mem + 304, &ckc, 8);\n-    memcpy(mem + 320, &cpu->env.aregs, 64);\n-    memcpy(mem + 384, &cpu->env.cregs, 128);\n \n     cpu_physical_memory_unmap(mem, len, 1, len);\n \n","prefixes":["v1","13/27"]}