{"id":814976,"url":"http://patchwork.ozlabs.org/api/patches/814976/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170918153049.44185-8-mika.westerberg@linux.intel.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918153049.44185-8-mika.westerberg@linux.intel.com>","list_archive_url":null,"date":"2017-09-18T15:30:40","name":"[07/16] thunderbolt: Configure interrupt throttling for all interrupts","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"a33a7a50e412fd547c87930fde8730bd82b51dab","submitter":{"id":14534,"url":"http://patchwork.ozlabs.org/api/people/14534/?format=json","name":"Mika Westerberg","email":"mika.westerberg@linux.intel.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170918153049.44185-8-mika.westerberg@linux.intel.com/mbox/","series":[{"id":3664,"url":"http://patchwork.ozlabs.org/api/series/3664/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3664","date":"2017-09-18T15:30:47","name":"Thunderbolt networking","version":1,"mbox":"http://patchwork.ozlabs.org/series/3664/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814976/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814976/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwqks6rlPz9s78\n\tfor ;\n\tTue, 19 Sep 2017 01:32:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932780AbdIRPc3 (ORCPT );\n\tMon, 18 Sep 2017 11:32:29 -0400","from mga14.intel.com ([192.55.52.115]:30122 \"EHLO mga14.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S932354AbdIRPb2 (ORCPT );\n\tMon, 18 Sep 2017 11:31:28 -0400","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Sep 2017 08:31:27 -0700","from black.fi.intel.com ([10.237.72.28])\n\tby fmsmga002.fm.intel.com with ESMTP; 18 Sep 2017 08:31:24 -0700","by black.fi.intel.com (Postfix, from userid 1001)\n\tid B21393AF; Mon, 18 Sep 2017 18:30:49 +0300 (EEST)"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,413,1500966000\"; d=\"scan'208\";a=\"1220360025\"","From":"Mika Westerberg ","To":"Greg Kroah-Hartman ,\n\t\"David S . Miller\" ","Cc":"Andreas Noever ,\n\tMichael Jamet ,\n\tYehezkel Bernat ,\n\tAmir Levy ,\n\tMario.Limonciello@dell.com, Lukas Wunner ,\n\tAndy Shevchenko ,\n\tMika Westerberg ,\n\tlinux-kernel@vger.kernel.org, netdev@vger.kernel.org","Subject":"[PATCH 07/16] thunderbolt: Configure interrupt throttling for all\n\tinterrupts","Date":"Mon, 18 Sep 2017 18:30:40 +0300","Message-Id":"<20170918153049.44185-8-mika.westerberg@linux.intel.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170918153049.44185-1-mika.westerberg@linux.intel.com>","References":"<20170918153049.44185-1-mika.westerberg@linux.intel.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This will keep the interrupt delivery rate reasonable. The value used\nhere (128 us) is a recommendation from the hardware people.\n\nThis code is based on the work done by Amir Levy and Michael Jamet.\n\nSigned-off-by: Michael Jamet \nSigned-off-by: Mika Westerberg \nReviewed-by: Yehezkel Bernat \n---\n drivers/thunderbolt/nhi.c | 22 +++++++++++++++++++---\n drivers/thunderbolt/nhi_regs.h | 2 ++\n 2 files changed, 21 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c\nindex 05af126a2435..bc44cbaaf05a 100644\n--- a/drivers/thunderbolt/nhi.c\n+++ b/drivers/thunderbolt/nhi.c\n@@ -651,6 +651,21 @@ static int nhi_suspend_noirq(struct device *dev)\n \treturn tb_domain_suspend_noirq(tb);\n }\n \n+static void nhi_enable_int_throttling(struct tb_nhi *nhi)\n+{\n+\tu32 throttle = DIV_ROUND_UP(128 * NSEC_PER_USEC, 256);\n+\tunsigned int i;\n+\n+\t/*\n+\t * Configure interrupt throttling for all vectors even if we\n+\t * only use few.\n+\t */\n+\tfor (i = 0; i < MSIX_MAX_VECS; i++) {\n+\t\tu32 reg = REG_INT_THROTTLING_RATE + i * 4;\n+\t\tiowrite32(throttle, nhi->iobase + reg);\n+\t}\n+}\n+\n static int nhi_resume_noirq(struct device *dev)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n@@ -663,6 +678,8 @@ static int nhi_resume_noirq(struct device *dev)\n \t */\n \tif (!pci_device_is_present(pdev))\n \t\ttb->nhi->going_away = true;\n+\telse\n+\t\tnhi_enable_int_throttling(tb->nhi);\n \n \treturn tb_domain_resume_noirq(tb);\n }\n@@ -717,6 +734,8 @@ static int nhi_init_msi(struct tb_nhi *nhi)\n \t/* In case someone left them on. */\n \tnhi_disable_interrupts(nhi);\n \n+\tnhi_enable_int_throttling(nhi);\n+\n \tida_init(&nhi->msix_ida);\n \n \t/*\n@@ -796,9 +815,6 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id)\n \n \tpci_set_master(pdev);\n \n-\t/* magic value - clock related? */\n-\tiowrite32(3906250 / 10000, nhi->iobase + 0x38c00);\n-\n \ttb = icm_probe(nhi);\n \tif (!tb)\n \t\ttb = tb_probe(nhi);\ndiff --git a/drivers/thunderbolt/nhi_regs.h b/drivers/thunderbolt/nhi_regs.h\nindex 09ed574e92ff..46eff69b19ad 100644\n--- a/drivers/thunderbolt/nhi_regs.h\n+++ b/drivers/thunderbolt/nhi_regs.h\n@@ -95,6 +95,8 @@ struct ring_desc {\n #define REG_RING_INTERRUPT_BASE\t0x38200\n #define RING_INTERRUPT_REG_COUNT(nhi) ((31 + 2 * nhi->hop_count) / 32)\n \n+#define REG_INT_THROTTLING_RATE\t0x38c00\n+\n /* Interrupt Vector Allocation */\n #define REG_INT_VEC_ALLOC_BASE\t0x38c40\n #define REG_INT_VEC_ALLOC_BITS\t4\n","prefixes":["07/16"]}