{"id":814961,"url":"http://patchwork.ozlabs.org/api/patches/814961/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/bbac9b87b76e8e54837d427f9d0f2cd520f34c09.1505737465.git.maozy.fnst@cn.fujitsu.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-18T14:05:18","name":"[v3,6/6] dev-storage: Fix the unusual function name","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"925e83e1e192ad019b66dd26643501d6956c56d2","submitter":{"id":71231,"url":"http://patchwork.ozlabs.org/api/people/71231/?format=json","name":"Mao Zhongyi","email":"maozy.fnst@cn.fujitsu.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/bbac9b87b76e8e54837d427f9d0f2cd520f34c09.1505737465.git.maozy.fnst@cn.fujitsu.com/mbox/","series":[{"id":3655,"url":"http://patchwork.ozlabs.org/api/series/3655/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3655","date":"2017-09-18T14:05:14","name":"Convert to realize and improve error handling","version":3,"mbox":"http://patchwork.ozlabs.org/series/3655/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814961/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814961/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwp933CxTz9s7F\n\tfor ;\n\tTue, 19 Sep 2017 00:21:43 +1000 (AEST)","from localhost ([::1]:36934 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtwvd-0003KX-81\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 10:21:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42926)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtwiU-0000hH-Kz\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:08:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtwiP-0006PI-Pz\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:08:06 -0400","from mail.cn.fujitsu.com ([183.91.158.132]:20177\n\thelo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtwiP-0006OH-El\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:08:01 -0400","from localhost (HELO cn.fujitsu.com) ([10.167.33.5])\n\tby heian.cn.fujitsu.com with ESMTP; 18 Sep 2017 22:07:50 +0800","from G08CNEXCHPEKD03.g08.fujitsu.local (unknown [10.167.33.85])\n\tby cn.fujitsu.com (Postfix) with ESMTP id 8A21A47CA461;\n\tMon, 18 Sep 2017 22:07:49 +0800 (CST)","from maozy.g08.fujitsu.local (10.167.225.76) by\n\tG08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP\n\tServer (TLS) id 14.3.361.1; Mon, 18 Sep 2017 22:07:52 +0800"],"X-IronPort-AV":"E=Sophos;i=\"5.42,413,1500912000\"; d=\"scan'208\";a=\"26773970\"","From":"Mao Zhongyi ","To":"","Date":"Mon, 18 Sep 2017 22:05:18 +0800","Message-ID":"","X-Mailer":"git-send-email 2.9.4","MIME-Version":"1.0","In-Reply-To":"","References":"","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8bit","X-Originating-IP":"[10.167.225.76]","X-yoursite-MailScanner-ID":"8A21A47CA461.AA569","X-yoursite-MailScanner":"Found to be clean","X-yoursite-MailScanner-From":"maozy.fnst@cn.fujitsu.com","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"183.91.158.132","Subject":"[Qemu-devel] [PATCH v3 6/6] dev-storage: Fix the unusual function\n\tname","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Gerd Hoffmann ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"The function name of usb_msd_{realize,unrealize}_*,\nusb_msd_class_initfn_* are unusual. Rename it to\nusb_msd_*_{realize,unrealize}, usb_msd_class_*_initfn.\n\nCc: Gerd Hoffmann \n\nSigned-off-by: Mao Zhongyi \nReviewed-by: Philippe Mathieu-Daudé \n---\n hw/usb/dev-storage.c | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c\nindex 801f552..2a05cd5 100644\n--- a/hw/usb/dev-storage.c\n+++ b/hw/usb/dev-storage.c\n@@ -596,7 +596,7 @@ static void usb_msd_unrealize_storage(USBDevice *dev, Error **errp)\n object_unref(OBJECT(&s->bus));\n }\n \n-static void usb_msd_realize_storage(USBDevice *dev, Error **errp)\n+static void usb_msd_storage_realize(USBDevice *dev, Error **errp)\n {\n MSDState *s = USB_STORAGE_DEV(dev);\n BlockBackend *blk = s->conf.blk;\n@@ -643,14 +643,14 @@ static void usb_msd_realize_storage(USBDevice *dev, Error **errp)\n s->scsi_dev = scsi_dev;\n }\n \n-static void usb_msd_unrealize_bot(USBDevice *dev, Error **errp)\n+static void usb_msd_bot_unrealize(USBDevice *dev, Error **errp)\n {\n MSDState *s = USB_STORAGE_DEV(dev);\n \n object_unref(OBJECT(&s->bus));\n }\n \n-static void usb_msd_realize_bot(USBDevice *dev, Error **errp)\n+static void usb_msd_bot_realize(USBDevice *dev, Error **errp)\n {\n MSDState *s = USB_STORAGE_DEV(dev);\n DeviceState *d = DEVICE(dev);\n@@ -764,12 +764,12 @@ static void usb_msd_class_initfn_common(ObjectClass *klass, void *data)\n dc->vmsd = &vmstate_usb_msd;\n }\n \n-static void usb_msd_class_initfn_storage(ObjectClass *klass, void *data)\n+static void usb_msd_class_storage_initfn(ObjectClass *klass, void *data)\n {\n DeviceClass *dc = DEVICE_CLASS(klass);\n USBDeviceClass *uc = USB_DEVICE_CLASS(klass);\n \n- uc->realize = usb_msd_realize_storage;\n+ uc->realize = usb_msd_storage_realize;\n uc->unrealize = usb_msd_unrealize_storage;\n dc->props = msd_properties;\n }\n@@ -828,26 +828,26 @@ static void usb_msd_instance_init(Object *obj)\n object_property_set_int(obj, -1, \"bootindex\", NULL);\n }\n \n-static void usb_msd_class_initfn_bot(ObjectClass *klass, void *data)\n+static void usb_msd_class_bot_initfn(ObjectClass *klass, void *data)\n {\n USBDeviceClass *uc = USB_DEVICE_CLASS(klass);\n \n- uc->realize = usb_msd_realize_bot;\n- uc->unrealize = usb_msd_unrealize_bot;\n+ uc->realize = usb_msd_bot_realize;\n+ uc->unrealize = usb_msd_bot_unrealize;\n uc->attached_settable = true;\n }\n \n static const TypeInfo msd_info = {\n .name = \"usb-storage\",\n .parent = TYPE_USB_STORAGE,\n- .class_init = usb_msd_class_initfn_storage,\n+ .class_init = usb_msd_class_storage_initfn,\n .instance_init = usb_msd_instance_init,\n };\n \n static const TypeInfo bot_info = {\n .name = \"usb-bot\",\n .parent = TYPE_USB_STORAGE,\n- .class_init = usb_msd_class_initfn_bot,\n+ .class_init = usb_msd_class_bot_initfn,\n };\n \n static void usb_msd_register_types(void)\n","prefixes":["v3","6/6"]}