{"id":814954,"url":"http://patchwork.ozlabs.org/api/patches/814954/?format=json","web_url":"http://patchwork.ozlabs.org/project/swupdate/patch/1505743744-24674-1-git-send-email-sbabic@denx.de/","project":{"id":58,"url":"http://patchwork.ozlabs.org/api/projects/58/?format=json","name":"swupdate development","link_name":"swupdate","list_id":"swupdate.googlegroups.com","list_email":"swupdate@googlegroups.com","web_url":"https://github.com/sbabic/swupdate","scm_url":"git://github.com/sbabic/swupdate","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505743744-24674-1-git-send-email-sbabic@denx.de>","list_archive_url":null,"date":"2017-09-18T14:09:04","name":"hawkbit: wrong action when checking during download","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8896ae03794f0129cfd748598ba6b86d79ee6da8","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/?format=json","name":"Stefano Babic","email":"sbabic@denx.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/swupdate/patch/1505743744-24674-1-git-send-email-sbabic@denx.de/mbox/","series":[{"id":3656,"url":"http://patchwork.ozlabs.org/api/series/3656/?format=json","web_url":"http://patchwork.ozlabs.org/project/swupdate/list/?series=3656","date":"2017-09-18T14:09:04","name":"hawkbit: wrong action when checking during download","version":1,"mbox":"http://patchwork.ozlabs.org/series/3656/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814954/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814954/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:400c:c0c::23f;\n\thelo=mail-wr0-x23f.google.com;\n\tenvelope-from=swupdate+bncbaabbc5h77gqkgqe6cr342i@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"M+LXmrT9\"; dkim-atps=neutral"],"Received":["from mail-wr0-x23f.google.com (mail-wr0-x23f.google.com\n\t[IPv6:2a00:1450:400c:c0c::23f])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwntl0tn1z9s7G\n\tfor ;\n\tTue, 19 Sep 2017 00:09:18 +1000 (AEST)","by mail-wr0-x23f.google.com with SMTP id w12sf65006wrc.2\n\tfor ;\n\tMon, 18 Sep 2017 07:09:18 -0700 (PDT)","by 10.28.143.66 with SMTP id r63ls1545453wmd.7.canary-gmail;\n\tMon, 18 Sep 2017 07:09:15 -0700 (PDT)","from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.10])\n\tby gmr-mx.google.com with ESMTPS id\n\tk18si54915wmd.1.2017.09.18.07.09.15 for \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 07:09:15 -0700 (PDT)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xwntg0YGWz1rbRJ;\n\tMon, 18 Sep 2017 16:09:15 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xwntg0Hwyz1qqkc;\n\tMon, 18 Sep 2017 16:09:15 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 0t_FnAcF6dXP; Mon, 18 Sep 2017 16:09:14 +0200 (CEST)","from babic.homelinux.org\n\t(host-88-217-136-221.customer.m-online.net [88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tMon, 18 Sep 2017 16:09:14 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id E4357454058B;\n\tMon, 18 Sep 2017 16:09:13 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id PtTnaKRKQh2m; Mon, 18 Sep 2017 16:09:11 +0200 (CEST)","from papero.fritz.box (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 86014454016E;\n\tMon, 18 Sep 2017 16:09:11 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; t=1505743755; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=qACUZDOxvS9LGhT/GjzgNFCiZcGB8bECqBF65Gj+Qlwz2pgJa5NbxIIQ1eZpiCnFGR\n\ttq6Es7IH2pYfd3OPbEppbVZ4e4W6hObxQ9PNBBRUPCdi4Ow0gECd8u/ajLY5NDRBkC+V\n\tMN/JkK4Q1aN2zKjFW75ZrafYB8rW8TsmW0vDlmk6R2R5ZKMe/8p0znDjZ2ybdY7Idt/5\n\tMkh1ZljKFXDxSdPD7IUrAg4/0x04XwckuXXRuXi07TqnbqA1edsi0KwgTFG4i5jV0Cat\n\tu9pTNBBPlqr12iqDRRjKeB8hZLJZDHOa99gcq7QMs//keLXtxuTyfebRSHWBgsEZiq9C\n\tCT+Q==","i=1; a=rsa-sha256; t=1505743755; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=niBxd4Z3+D8deXdaN3H9NlADmnnL9Jnp9djECCffoVTFm4dqz8AD0sfiugYkYnhYkd\n\tjt5jF/GP8g/R6IiWluzjx7vqG4Y75fzRjGKHnE4HH5ztcDE1Y5OmtVltfBUjxz1a6Jro\n\tU9raQjMuEs5F7zkV2JQm5K5gjtiedmKf5KszjQttB4dgg6xk2g/iDOnw0etvxboOGbYf\n\tnWeIeGpPZkM/CgocLdZsbPwUCd0qqODwC2bLeXRlXBgUrY+gknDuWelFhgXWCYL6aX+3\n\tOVG/XlIsXbtwtg8MCGVFjfOKj6LLJaebhOhQqlO0JFy5T2annRUMBmBQl0gDR2cxOEpD\n\tywJA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:message-id:date:subject:cc:to:from\n\t:arc-authentication-results:arc-message-signature:mime-version\n\t:sender:dkim-signature:arc-authentication-results;\n\tbh=/tviZwvtUQZ9Coa294DNQWyM+dZqzHQrFHbZ90MfbF8=;\n\tb=Cc+j/32GqMMOFa5f+0cg5btfkiYAfWvYVywLXSbWD75VJRfF7uO/9enzsUPhrIrNAv\n\tUoSB+Aejm8GAm4Ig4jMPvs7+dORKKwRyxDi0SgHFbBNEl5vuMobgUZ0kHuarKYHSpIwe\n\trEzS06aBJz/QdLUbuzPz19UA1ZotzF63FO/Sne2+PoUCiNNQfv4lwgQPuRJ12T8Y3Fjt\n\tIjcJncrmzOgKC3w5LTvPsVue55oEk3EAckyUsWmXUfcuPnp4e+7P2MJB3fd7P7ybhIki\n\tXPtZDcJ2Df9YQttucPYP9xB6XLhqXOI1jKD/s0XAbtQbwlS1gajlfPUYzCqrctEKDrEJ\n\tfoKw==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=message-id:date:subject:cc:to:from:arc-authentication-results;\n\tbh=zQhtXq3HJrWdHGGMufo0+eTPWT/Ot5XxTxRCM4ftGgc=;\n\tb=IL3bEft1Wrq5ODyItLzzMVTC35bMVd787CsTbvI0Wib34T2Ay2fiWYvk+3C7ZkJ0Cx\n\tOS6962AGSLxv38aiYH9anTEgFqgUoGwDT7WWPWXECgku2ET+cms+gXG2YVtoQCQaiLLT\n\tQL0wsJs31k4r7C3kGnGw1wMaJr7d8qFVUA944/d4Okr5PwxwpzfSRIG3WBVfquQy95Ek\n\tBzSdsdWe/s/m1tggwo4sT25j2elxUTDedr7wHuHf9Jj6l9mv74QUjmQTmH/P+CKfD5KT\n\to+FQs0msvrXY2x4FvgbXk2PhHFy1Kjy0AItcR7abhQcOo+WY58NVd46HDBfTP1voUo82\n\tOskA=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 212.18.0.10 is neither permitted nor denied\n\tby best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 212.18.0.10 is neither permitted nor denied\n\tby best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:mime-version:from:to:cc:subject:date:message-id\n\t:x-original-sender:x-original-authentication-results:precedence\n\t:mailing-list:list-id:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=/tviZwvtUQZ9Coa294DNQWyM+dZqzHQrFHbZ90MfbF8=;\n\tb=M+LXmrT9O6uFeTwYtB31cBsOwrDdkLvI1hFl9lBDywDA4lSl1UrEprDJ2eDe1UyK3z\n\tOPnNPdUQj6WAp188TW81cIzZnXkXmLKtcVx55d6xczRqXX9/OcE+kziyDyKLncFCetDv\n\tzcQQtb2wxLEumYFZceBC8h5updjoXole4bgcdFy2Gv+mWqMhDzdcBxbH1FO45JpJP159\n\tHrNOzm6Xtenp1y7CD5ROCF4BVDayBU3Tff4nJ2hkDs3J0pZQ+XmUaWJi/C70UNMR1mAC\n\tx02tZesPnGBu0IfC7hkGUu9zE5K/bsVQseifmAIjR3N2Iw/lAyMLU/+H7DNXuyn9oxT1\n\t2gqA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:mime-version:from:to:cc:subject:date\n\t:message-id:x-original-sender:x-original-authentication-results\n\t:precedence:mailing-list:list-id:x-spam-checked-in-group:list-post\n\t:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=/tviZwvtUQZ9Coa294DNQWyM+dZqzHQrFHbZ90MfbF8=;\n\tb=hGhB516M1Asccv7qXrLckdTed/3+rS2sOzu+3ijsLIE9+dCb0DD7oSItug1TIm8KmX\n\tiRw3cSSCtdoRkxzzLNuSyIQRaUSuxm+Cv5/YKoCybtTkHTkzOxG7w5HA0ngT8vG/wJK1\n\tJmvuxW93yUQEcRf57vOvemBMjYPum4pJdfsVa2kBi2YNKt0A4dKi4VHM7zdg96VoAju/\n\tnzUQ+GOKZFKXGQs2valn/rM+fRLIKmFcHMXYgsK6gPFMVY13d8Xl9i7FRhXOE8AY9pfw\n\tilardhE3N+nv357YSM10hj3Ei3+EawdCc5MREEnD+0K6JNJMQAwG9lNymsIIFgWT82Wy\n\tL8Jw==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHPjjUjPPj4GveKe2nYP/c7v7Tcka/+Lx44tMQ7kGEyEeH1hTf98giU4\n\ta3rVSdCtpPJvsqsiKGE5G0U=","X-Google-Smtp-Source":"AOwi7QDV4X5Qu9Y1pRwL+8ZYCctn/1Smlu35pgc6wN79ddF0s77hSeWrGzmsi1JKp3hT+iIvhjqIZw==","X-Received":["by 10.28.95.86 with SMTP id t83mr21583wmb.24.1505743755759;\n\tMon, 18 Sep 2017 07:09:15 -0700 (PDT)","by 10.28.138.195 with SMTP id m186mr1069038wmd.9.1505743755398; \n\tMon, 18 Sep 2017 07:09:15 -0700 (PDT)"],"MIME-Version":"1.0","X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 212.18.0.10 is neither permitted nor\n\tdenied by best guess record for domain of sbabic@denx.de)\n\tclient-ip=212.18.0.10; ","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"From":"Stefano Babic ","To":"swupdate@googlegroups.com","Cc":"Stefano Babic ","Subject":"[swupdate] [PATCH] hawkbit: wrong action when checking during\n\tdownload","Date":"Mon, 18 Sep 2017 16:09:04 +0200","Message-Id":"<1505743744-24674-1-git-send-email-sbabic@denx.de>","X-Mailer":"git-send-email 2.7.4","X-Original-Sender":"sbabic@denx.de","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 212.18.0.10 is neither permitted nor denied by best\n\tguess record\n\tfor domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"},"content":"When the backend is polled during a download, the following error\nhappens:\n\n\tServer delivered empty. 'update' skipping\n\nThe cause is that the json resource is freed before evaluating the update action.\nRearrange the function and frees the JSON object with json_object_put just before returning.\n\nSigned-off-by: Stefano Babic \n---\n suricatta/server_hawkbit.c | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)","diff":"diff --git a/suricatta/server_hawkbit.c b/suricatta/server_hawkbit.c\nindex 4603803..243db4f 100644\n--- a/suricatta/server_hawkbit.c\n+++ b/suricatta/server_hawkbit.c\n@@ -759,18 +759,24 @@ static int server_check_during_dwl(void)\n \t */\n \tserver_op_res_t result =\n \t server_get_deployment_info(channel, &channel_data, &action_id);\n-\tif (channel_data.json_reply != NULL &&\n-\t json_object_put(channel_data.json_reply) != JSON_OBJECT_FREED) {\n-\t\tERROR(\"JSON object should be freed but was not.\\n\");\n-\t}\n \tif (result == SERVER_UPDATE_CANCELED) {\n \t\t/* Mark that an update was cancelled by the server */\n \t\tserver_hawkbit.cancelDuringUpdate = true;\n \t\tret = -1;\n \t}\n \tupdate_action = json_get_deployment_update_action(channel_data.json_reply);\n+\n+\t/* if the deployment is skipped then stop downloading */\n+\tif (update_action == deployment_update_action.skip)\n+\t\tret = -1;\n+\n \tcheck_action_changed(action_id, update_action);\n \n+\t/* Cleanup and free resources */\n+\tif (channel_data.json_reply != NULL &&\n+\t json_object_put(channel_data.json_reply) != JSON_OBJECT_FREED) {\n+\t\tERROR(\"JSON object should be freed but was not.\\n\");\n+\t}\n \tchannel->close(channel);\n \tfree(channel);\n \n","prefixes":[]}