{"id":814948,"url":"http://patchwork.ozlabs.org/api/patches/814948/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918135935.255591-7-vsementsov@virtuozzo.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918135935.255591-7-vsementsov@virtuozzo.com>","list_archive_url":null,"date":"2017-09-18T13:59:34","name":"[v2,6/7] block/nbd-client: early fail nbd_read_reply_entry if s->quit is set","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2a8dd5f6925837890b7712fc90212d29d7baf99a","submitter":{"id":66592,"url":"http://patchwork.ozlabs.org/api/people/66592/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@virtuozzo.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918135935.255591-7-vsementsov@virtuozzo.com/mbox/","series":[{"id":3654,"url":"http://patchwork.ozlabs.org/api/series/3654/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3654","date":"2017-09-18T13:59:31","name":"nbd client refactoring and fixing","version":2,"mbox":"http://patchwork.ozlabs.org/series/3654/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814948/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814948/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwnlj5Z66z9s7M\n\tfor ;\n\tTue, 19 Sep 2017 00:03:13 +1000 (AEST)","from localhost ([::1]:36797 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtwdj-0004Fd-Pu\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 10:03:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38501)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtwaT-0001kX-7t\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:59:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtwaS-0001TO-Aa\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:59:49 -0400","from mailhub.sw.ru ([195.214.232.25]:19804 helo=relay.sw.ru)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtwaR-0001S7-Vc\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:59:48 -0400","from kvm.sw.ru (msk-vpn.virtuozzo.com [195.214.232.6])\n\tby relay.sw.ru (8.13.4/8.13.4) with ESMTP id v8IDxZda022049;\n\tMon, 18 Sep 2017 16:59:37 +0300 (MSK)"],"From":"Vladimir Sementsov-Ogievskiy ","To":"qemu-block@nongnu.org, qemu-devel@nongnu.org","Date":"Mon, 18 Sep 2017 16:59:34 +0300","Message-Id":"<20170918135935.255591-7-vsementsov@virtuozzo.com>","X-Mailer":"git-send-email 2.11.1","In-Reply-To":"<20170918135935.255591-1-vsementsov@virtuozzo.com>","References":"<20170918135935.255591-1-vsementsov@virtuozzo.com>","X-detected-operating-system":"by eggs.gnu.org: OpenBSD 3.x [fuzzy]","X-Received-From":"195.214.232.25","Subject":"[Qemu-devel] [PATCH v2 6/7] block/nbd-client: early fail\n\tnbd_read_reply_entry if s->quit is set","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, vsementsov@virtuozzo.com, mreitz@redhat.com,\n\tden@openvz.org, pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Do not continue any operation if s->quit is set in parallel.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \n---\n block/nbd-client.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)","diff":"diff --git a/block/nbd-client.c b/block/nbd-client.c\nindex 280147e6a7..f80a4c5564 100644\n--- a/block/nbd-client.c\n+++ b/block/nbd-client.c\n@@ -81,7 +81,7 @@ static coroutine_fn void nbd_read_reply_entry(void *opaque)\n if (ret < 0) {\n error_report_err(local_err);\n }\n- if (ret <= 0) {\n+ if (ret <= 0 || s->quit) {\n break;\n }\n \n@@ -105,9 +105,8 @@ static coroutine_fn void nbd_read_reply_entry(void *opaque)\n assert(qiov != NULL);\n assert(s->requests[i].request->len ==\n iov_size(qiov->iov, qiov->niov));\n- if (qio_channel_readv_all(s->ioc, qiov->iov, qiov->niov,\n- NULL) < 0)\n- {\n+ ret = qio_channel_readv_all(s->ioc, qiov->iov, qiov->niov, NULL);\n+ if (ret < 0 || s->quit) {\n s->requests[i].ret = -EIO;\n break;\n }\n","prefixes":["v2","6/7"]}