{"id":814931,"url":"http://patchwork.ozlabs.org/api/patches/814931/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1505742050-5697-8-git-send-email-bmeng.cn@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505742050-5697-8-git-send-email-bmeng.cn@gmail.com>","list_archive_url":null,"date":"2017-09-18T13:40:43","name":"[U-Boot,07/14] usb: Read device descriptor after device is addressed for xHCI","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b3d17e8d3491792aad9a42fb3950aa9cd8ec1933","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/?format=json","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"delegate":{"id":1699,"url":"http://patchwork.ozlabs.org/api/users/1699/?format=json","username":"marex","first_name":"Marek","last_name":"Vasut","email":"marek.vasut@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1505742050-5697-8-git-send-email-bmeng.cn@gmail.com/mbox/","series":[{"id":3647,"url":"http://patchwork.ozlabs.org/api/series/3647/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3647","date":"2017-09-18T13:40:36","name":"usb: xhci: Add interrupt transfer support and full speed device support","version":1,"mbox":"http://patchwork.ozlabs.org/series/3647/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814931/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814931/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bD67X/wO\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwnJw6S7xz9s4s\n\tfor ;\n\tMon, 18 Sep 2017 23:43:28 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid AD6CDC21F61; Mon, 18 Sep 2017 13:38:49 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 34355C21F33;\n\tMon, 18 Sep 2017 13:37:13 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid DAA80C21F28; Mon, 18 Sep 2017 13:36:42 +0000 (UTC)","from mail-io0-f194.google.com (mail-io0-f194.google.com\n\t[209.85.223.194])\n\tby lists.denx.de (Postfix) with ESMTPS id F0F23C21F37\n\tfor ; Mon, 18 Sep 2017 13:36:38 +0000 (UTC)","by mail-io0-f194.google.com with SMTP id g32so1096613ioj.1\n\tfor ; Mon, 18 Sep 2017 06:36:38 -0700 (PDT)","from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com.\n\t[147.11.156.139]) by smtp.gmail.com with ESMTPSA id\n\t193sm2528740ion.83.2017.09.18.06.36.36\n\t(version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 18 Sep 2017 06:36:36 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=NzwY9qWMK77jWueDYF/crK8fOTqwT3TZfjv00T2Z3rI=;\n\tb=bD67X/wORN135iPYrMI+/ADbeo8S7YMlvjXfKzI1TuMIwV/ZzpHpT21k3HEJkl2Eoz\n\tk0O6+6Jpc86bJ5UPxV3yJY+RPpKVCASJcwiV+8spiPxdCzjpVVHQYRkD0lpzDYUwGQYD\n\tPyG2rt6q/a1LwI1A0NxBrdqFQAeoWM0be6AOzft4dxWOKxjCgmNWuCHpxH4XLWzt2I2H\n\tGgrcdyOvYmoqgePLG+/w3buzKj9xu7TfTiC462gdR1FfQnehuRzoLDXBskUUn9HqkS4g\n\timJ6MFNbZhF8dflr02dKTTp1450YEmS8+lnZSvs+YKSugBSa4shTV+KIgFQRh5wlbiVl\n\t7xjw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=NzwY9qWMK77jWueDYF/crK8fOTqwT3TZfjv00T2Z3rI=;\n\tb=QycSa/6RdMn57PrmJXrZ7C4FoTbzOFq/EA/XrpKbWoTxqYfXSVpeQyUwvEuadiTa4h\n\tXxT0zy6tSfEWELYOXokwfSfe+1Yx/IIsNZmHnDfocoiwLYLWum8EQ9CdHeFYxAbE7lIg\n\tJzMoR41o6JHcVUBtI+bufDMd77FnUuxRytzcHnZGwiRlCMoz1fv+XFkj+PKrd7Lg6oIr\n\txflZ4Kibs4n17niWWXqukBKyyD2VyChWXh/+a1o1k9Oc5bod2+8CfBtXqibSNPyGA7FJ\n\tXIijMpdDv3A0Q0tClG5UlK2QcD/KkDnOOO2s3oq8LcXdlGbAcPjgk/Deig7zSiGkZYAI\n\tjBVA==","X-Gm-Message-State":"AHPjjUgccg/ryHfJCYc09r9twbBHANdKbEb4sEk4GU3c1N+zx1EZXxij\n\tIh75hVlnb6Bqqw==","X-Google-Smtp-Source":"AOwi7QB11uP9WeuoyumuhGZLVDZzfa1MrckCEK77OTWQu29hhcYb2nmbeNWQ7PK6Laar4zhLEBJtyQ==","X-Received":"by 10.107.20.215 with SMTP id 206mr19428954iou.116.1505741797932;\n\tMon, 18 Sep 2017 06:36:37 -0700 (PDT)","From":"Bin Meng ","To":"Marek Vasut , U-Boot Mailing List ","Date":"Mon, 18 Sep 2017 06:40:43 -0700","Message-Id":"<1505742050-5697-8-git-send-email-bmeng.cn@gmail.com>","X-Mailer":"git-send-email 1.7.9.5","In-Reply-To":"<1505742050-5697-1-git-send-email-bmeng.cn@gmail.com>","References":"<1505742050-5697-1-git-send-email-bmeng.cn@gmail.com>","Cc":"Stefan Roese ","Subject":"[U-Boot] [PATCH 07/14] usb: Read device descriptor after device is\n\taddressed for xHCI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"For xHCI it is not possible to read a device descriptor before it\nhas been assigned an address. That's why usb_setup_descriptor()\nwas called with 'do_read' being false. But we really need try to\nread the device descriptor before starting any real communication\nwith the default control endpoint.\n\nSigned-off-by: Bin Meng \n---\n\n common/usb.c | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/common/usb.c b/common/usb.c\nindex 88cee81..8d27bc7 100644\n--- a/common/usb.c\n+++ b/common/usb.c\n@@ -1052,6 +1052,17 @@ static int usb_prepare_device(struct usb_device *dev, int addr, bool do_read,\n \n \tmdelay(10);\t/* Let the SET_ADDRESS settle */\n \n+\t/*\n+\t * If we haven't read device descriptor before, read it here\n+\t * after device is assigned an address. This is only applicable\n+\t * to xHCI so far.\n+\t */\n+\tif (!do_read) {\n+\t\terr = usb_setup_descriptor(dev, true);\n+\t\tif (err)\n+\t\t\treturn err;\n+\t}\n+\n \treturn 0;\n }\n \n","prefixes":["U-Boot","07/14"]}