{"id":814929,"url":"http://patchwork.ozlabs.org/api/patches/814929/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1505742050-5697-10-git-send-email-bmeng.cn@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505742050-5697-10-git-send-email-bmeng.cn@gmail.com>","list_archive_url":null,"date":"2017-09-18T13:40:45","name":"[U-Boot,09/14] usb: hub: Clear port reset before usb_hub_port_connect_change()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ecdef216532c3e8b12af399e30dd1864c6994e61","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/?format=json","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"delegate":{"id":1699,"url":"http://patchwork.ozlabs.org/api/users/1699/?format=json","username":"marex","first_name":"Marek","last_name":"Vasut","email":"marek.vasut@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1505742050-5697-10-git-send-email-bmeng.cn@gmail.com/mbox/","series":[{"id":3647,"url":"http://patchwork.ozlabs.org/api/series/3647/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3647","date":"2017-09-18T13:40:36","name":"usb: xhci: Add interrupt transfer support and full speed device support","version":1,"mbox":"http://patchwork.ozlabs.org/series/3647/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814929/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814929/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FIw0WXUT\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwnHy51S5z9s4s\n\tfor ;\n\tMon, 18 Sep 2017 23:42:38 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 70866C21F1C; Mon, 18 Sep 2017 13:39:19 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 621F7C21F3A;\n\tMon, 18 Sep 2017 13:37:27 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 3A73DC21E21; Mon, 18 Sep 2017 13:36:45 +0000 (UTC)","from mail-io0-f194.google.com (mail-io0-f194.google.com\n\t[209.85.223.194])\n\tby lists.denx.de (Postfix) with ESMTPS id EA742C21DD9\n\tfor ; Mon, 18 Sep 2017 13:36:41 +0000 (UTC)","by mail-io0-f194.google.com with SMTP id d16so1094211ioj.2\n\tfor ; Mon, 18 Sep 2017 06:36:41 -0700 (PDT)","from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com.\n\t[147.11.156.139]) by smtp.gmail.com with ESMTPSA id\n\t193sm2528740ion.83.2017.09.18.06.36.39\n\t(version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 18 Sep 2017 06:36:40 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=bF5jXaOiobIo4XbZ6i9AHRL97s/JCm1cT6fVLHRdsbk=;\n\tb=FIw0WXUT3KVvYiRGm5e758Y7ZrHZAXqG1Lu3hPAzj/5NY3Da+GvDzcXn9s8+2CGjYp\n\tBfld9WxVqxYYJu3P0Oz620EySBOOnVY9Oac6HkLfBFbk9JB/ihGuJDt2xNFSCZyP1XRn\n\taWcpH0cCe45fTN2VjQ5itfWbqIbXBDBfnOpX7m/PLSGBoD+fWC2zKV2cKSRI9FHDte29\n\twiPFNzYWiLDoRgFSW/XX8ZI5VuuG5C9GiWdU4QQizzJ6iFGGOi3YZ/a4dtFI3Ns2OWdR\n\tHH7pu9GP/vSatbL+xmqBMxmzmdvr4wgzHXd5384u8lFjgGHJY0NnbsRj9JLZ8PUbFufW\n\tZRNg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=bF5jXaOiobIo4XbZ6i9AHRL97s/JCm1cT6fVLHRdsbk=;\n\tb=HkoMXP/9bi3JuV7lZpO15aZmBYtH3DILo97VVJIKodpoT4wwzP5O69hYYjo8s2yaG2\n\t/UHYbCwjlVtR9ls/G/XrI7bPFOVbwxSKV/72G0a8MdIP3jF8KkMHL+651Nw8TMJBv+62\n\to7siBAosavM46iGAHnQJzQitOAqd0kN817jWdNC6OkA4m/UKKB/621IwWGjRMMzn5tFW\n\t44218Un1tscYzRY1vYsWq0R8BsWm2e7E5S6cbXYucckLSXZrzRhJMb8g/cqeshQ5/a1o\n\tnlk+hKPQjB4xpUa5YxB80+onjevaXTWcdO8VkCZIjS25ycFhAemvAByF99AIV8JCinx0\n\tmn1Q==","X-Gm-Message-State":"AHPjjUgrn0SEvZy8wSPyxel7jAoejfJOImbT8qNcKfFMtfoJ3fFvOIxw\n\tVCO2N7W4wPbvzw==","X-Google-Smtp-Source":"AOwi7QBFcYZiQeXmxSILApXhEYiwiYbwu7lHsEyrgSiMqIeNjVPh5ChnYM6bBCtaOPFG4ma8DZCRjQ==","X-Received":"by 10.107.81.1 with SMTP id f1mr19221968iob.17.1505741800905;\n\tMon, 18 Sep 2017 06:36:40 -0700 (PDT)","From":"Bin Meng ","To":"Marek Vasut , U-Boot Mailing List ","Date":"Mon, 18 Sep 2017 06:40:45 -0700","Message-Id":"<1505742050-5697-10-git-send-email-bmeng.cn@gmail.com>","X-Mailer":"git-send-email 1.7.9.5","In-Reply-To":"<1505742050-5697-1-git-send-email-bmeng.cn@gmail.com>","References":"<1505742050-5697-1-git-send-email-bmeng.cn@gmail.com>","Cc":"Stefan Roese ","Subject":"[U-Boot] [PATCH 09/14] usb: hub: Clear port reset before\n\tusb_hub_port_connect_change()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"During usb_hub_port_connect_change(), a port reset set feature\nrequest is issued to the port, and later a port reset clear feature\nis done to the same port before the function returns. However at\nthe end of usb_scan_port(), we attempt to clear port reset again\non a cached port status change variable, which should not be done.\n\nAdjust the call to clear port reset to right before the call to\nusb_hub_port_connect_change().\n\nSigned-off-by: Bin Meng \n---\n\n common/usb_hub.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/common/usb_hub.c b/common/usb_hub.c\nindex 86a3477..a9d21bc 100644\n--- a/common/usb_hub.c\n+++ b/common/usb_hub.c\n@@ -489,6 +489,11 @@ static int usb_scan_port(struct usb_device_scan *usb_scan)\n \t\treturn 0;\n \t}\n \n+\tif (portchange & USB_PORT_STAT_C_RESET) {\n+\t\tdebug(\"port %d reset change\\n\", i + 1);\n+\t\tusb_clear_port_feature(dev, i + 1, USB_PORT_FEAT_C_RESET);\n+\t}\n+\n \t/* A new USB device is ready at this point */\n \tdebug(\"devnum=%d port=%d: USB dev found\\n\", dev->devnum, i + 1);\n \n@@ -543,11 +548,6 @@ static int usb_scan_port(struct usb_device_scan *usb_scan)\n \t\t hub->overcurrent_count[i]);\n \t}\n \n-\tif (portchange & USB_PORT_STAT_C_RESET) {\n-\t\tdebug(\"port %d reset change\\n\", i + 1);\n-\t\tusb_clear_port_feature(dev, i + 1, USB_PORT_FEAT_C_RESET);\n-\t}\n-\n \t/*\n \t * We're done with this device, so let's remove this device from\n \t * scanning list\n","prefixes":["U-Boot","09/14"]}