{"id":814880,"url":"http://patchwork.ozlabs.org/api/patches/814880/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918101709.30421-10-aik@ozlabs.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918101709.30421-10-aik@ozlabs.ru>","list_archive_url":null,"date":"2017-09-18T10:17:05","name":"[qemu,v3,09/13] memory: Rename mem_begin/mem_commit/mem_add helpers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"29323d41ae0e3eae5cd8f52c800bfe24be5c20b4","submitter":{"id":7621,"url":"http://patchwork.ozlabs.org/api/people/7621/?format=json","name":"Alexey Kardashevskiy","email":"aik@ozlabs.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918101709.30421-10-aik@ozlabs.ru/mbox/","series":[{"id":3617,"url":"http://patchwork.ozlabs.org/api/series/3617/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3617","date":"2017-09-18T10:16:57","name":"memory: Reduce memory use","version":3,"mbox":"http://patchwork.ozlabs.org/series/3617/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814880/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814880/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwhxW1XTbz9s78\n\tfor ;\n\tMon, 18 Sep 2017 20:26:23 +1000 (AEST)","from localhost ([::1]:35633 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dttFt-0004Si-9R\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 06:26:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42022)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtt7K-0005l1-35\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:17:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtt7I-0004Ft-DR\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:17:30 -0400","from ozlabs.ru ([107.173.13.209]:35254)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtt7I-0004Dh-51\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:17:28 -0400","from vpl1.ozlabs.ibm.com (localhost [IPv6:::1])\n\tby ozlabs.ru (Postfix) with ESMTP id E97043A60055;\n\tMon, 18 Sep 2017 06:18:42 -0400 (EDT)"],"From":"Alexey Kardashevskiy ","To":"qemu-devel@nongnu.org","Date":"Mon, 18 Sep 2017 20:17:05 +1000","Message-Id":"<20170918101709.30421-10-aik@ozlabs.ru>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170918101709.30421-1-aik@ozlabs.ru>","References":"<20170918101709.30421-1-aik@ozlabs.ru>","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"107.173.13.209","Subject":"[Qemu-devel] [PATCH qemu v3 09/13] memory: Rename\n\tmem_begin/mem_commit/mem_add helpers","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"This renames some helper to reflect better what they do.\n\nSigned-off-by: Alexey Kardashevskiy \n---\nChanges:\nv3:\n* s/flatview_mem_add/flatview_add_to_dispatch/\n* s/phys_page_compact_all/address_space_dispatch_compact/\n* s/address_space_dispatch_alloc/address_space_dispatch_new/\n---\n include/exec/memory-internal.h | 6 +++---\n exec.c | 12 +++---------\n memory.c | 6 +++---\n 3 files changed, 9 insertions(+), 15 deletions(-)","diff":"diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h\nindex 1cf8ad9869..d4a35c6e96 100644\n--- a/include/exec/memory-internal.h\n+++ b/include/exec/memory-internal.h\n@@ -27,9 +27,9 @@ extern const MemoryRegionOps unassigned_mem_ops;\n bool memory_region_access_valid(MemoryRegion *mr, hwaddr addr,\n unsigned size, bool is_write);\n \n-void mem_add(FlatView *fv, MemoryRegionSection *section);\n-AddressSpaceDispatch *mem_begin(AddressSpace *as);\n-void mem_commit(AddressSpaceDispatch *d);\n+void flatview_add_to_dispatch(FlatView *fv, MemoryRegionSection *section);\n+AddressSpaceDispatch *address_space_dispatch_new(FlatView *fv);\n+void address_space_dispatch_compact(AddressSpaceDispatch *d);\n \n AddressSpaceDispatch *address_space_to_dispatch(AddressSpace *as);\n AddressSpaceDispatch *flatview_to_dispatch(FlatView *fv);\ndiff --git a/exec.c b/exec.c\nindex 3e02b82c05..b1f29d35d8 100644\n--- a/exec.c\n+++ b/exec.c\n@@ -359,7 +359,7 @@ static void phys_page_compact(PhysPageEntry *lp, Node *nodes)\n }\n }\n \n-static void phys_page_compact_all(AddressSpaceDispatch *d, int nodes_nb)\n+void address_space_dispatch_compact(AddressSpaceDispatch *d)\n {\n if (d->phys_map.skip) {\n phys_page_compact(&d->phys_map, d->map.nodes);\n@@ -1347,7 +1347,7 @@ static void register_multipage(FlatView *fv,\n phys_page_set(d, start_addr >> TARGET_PAGE_BITS, num_pages, section_index);\n }\n \n-void mem_add(FlatView *fv, MemoryRegionSection *section)\n+void flatview_add_to_dispatch(FlatView *fv, MemoryRegionSection *section)\n {\n MemoryRegionSection now = *section, remain = *section;\n Int128 page_size = int128_make64(TARGET_PAGE_SIZE);\n@@ -2673,9 +2673,8 @@ static void io_mem_init(void)\n NULL, UINT64_MAX);\n }\n \n-AddressSpaceDispatch *mem_begin(AddressSpace *as)\n+AddressSpaceDispatch *address_space_dispatch_new(FlatView *fv)\n {\n- FlatView *fv = address_space_to_flatview(as);\n AddressSpaceDispatch *d = g_new0(AddressSpaceDispatch, 1);\n uint16_t n;\n \n@@ -2699,11 +2698,6 @@ void address_space_dispatch_free(AddressSpaceDispatch *d)\n g_free(d);\n }\n \n-void mem_commit(AddressSpaceDispatch *d)\n-{\n- phys_page_compact_all(d, d->map.nodes_nb);\n-}\n-\n static void tcg_commit(MemoryListener *listener)\n {\n CPUAddressSpace *cpuas;\ndiff --git a/memory.c b/memory.c\nindex d208106032..e046f7bc2f 100644\n--- a/memory.c\n+++ b/memory.c\n@@ -906,13 +906,13 @@ static void address_space_update_topology(AddressSpace *as)\n FlatView *new_view = generate_memory_topology(as->root);\n int i;\n \n- new_view->dispatch = mem_begin(as);\n+ new_view->dispatch = address_space_dispatch_new(new_view);\n for (i = 0; i < new_view->nr; i++) {\n MemoryRegionSection mrs =\n section_from_flat_range(&new_view->ranges[i], new_view);\n- mem_add(new_view, &mrs);\n+ flatview_add_to_dispatch(new_view, &mrs);\n }\n- mem_commit(new_view->dispatch);\n+ address_space_dispatch_compact(new_view->dispatch);\n \n address_space_update_topology_pass(as, old_view, new_view, false);\n address_space_update_topology_pass(as, old_view, new_view, true);\n","prefixes":["qemu","v3","09/13"]}