{"id":814879,"url":"http://patchwork.ozlabs.org/api/patches/814879/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918101709.30421-11-aik@ozlabs.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918101709.30421-11-aik@ozlabs.ru>","list_archive_url":null,"date":"2017-09-18T10:17:06","name":"[qemu,v3,10/13] memory: Store physical root MR in FlatView","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"35957db7458b63cd7f14c8796a47801fdd7a8247","submitter":{"id":7621,"url":"http://patchwork.ozlabs.org/api/people/7621/?format=json","name":"Alexey Kardashevskiy","email":"aik@ozlabs.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918101709.30421-11-aik@ozlabs.ru/mbox/","series":[{"id":3617,"url":"http://patchwork.ozlabs.org/api/series/3617/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3617","date":"2017-09-18T10:16:57","name":"memory: Reduce memory use","version":3,"mbox":"http://patchwork.ozlabs.org/series/3617/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814879/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814879/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwhv05NV0z9s7M\n\tfor ;\n\tMon, 18 Sep 2017 20:24:12 +1000 (AEST)","from localhost ([::1]:35615 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dttDm-0002g6-PQ\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 06:24:10 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42030)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtt7K-0005lV-GH\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:17:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtt7J-0004GS-DZ\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:17:30 -0400","from ozlabs.ru ([107.173.13.209]:35254)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtt7J-0004Dh-8e\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:17:29 -0400","from vpl1.ozlabs.ibm.com (localhost [IPv6:::1])\n\tby ozlabs.ru (Postfix) with ESMTP id 0E2833A60054;\n\tMon, 18 Sep 2017 06:18:43 -0400 (EDT)"],"From":"Alexey Kardashevskiy ","To":"qemu-devel@nongnu.org","Date":"Mon, 18 Sep 2017 20:17:06 +1000","Message-Id":"<20170918101709.30421-11-aik@ozlabs.ru>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170918101709.30421-1-aik@ozlabs.ru>","References":"<20170918101709.30421-1-aik@ozlabs.ru>","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"107.173.13.209","Subject":"[Qemu-devel] [PATCH qemu v3 10/13] memory: Store physical root MR\n\tin FlatView","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Address spaces get to keep a root MR (alias or not) but FlatView stores\nthe actual MR as this is going to be used later on to decide whether to\nshare a particular FlatView or not.\n\nSigned-off-by: Alexey Kardashevskiy \n---\n memory.c | 27 ++++++++++++++++++++++-----\n 1 file changed, 22 insertions(+), 5 deletions(-)","diff":"diff --git a/memory.c b/memory.c\nindex e046f7bc2f..e18ef53cc2 100644\n--- a/memory.c\n+++ b/memory.c\n@@ -231,6 +231,7 @@ struct FlatView {\n unsigned nr;\n unsigned nr_allocated;\n struct AddressSpaceDispatch *dispatch;\n+ MemoryRegion *root;\n };\n \n typedef struct AddressSpaceOps AddressSpaceOps;\n@@ -260,12 +261,14 @@ static bool flatrange_equal(FlatRange *a, FlatRange *b)\n && a->readonly == b->readonly;\n }\n \n-static FlatView *flatview_new(void)\n+static FlatView *flatview_new(MemoryRegion *mr_root)\n {\n FlatView *view;\n \n view = g_new0(FlatView, 1);\n view->ref = 1;\n+ view->root = mr_root;\n+ memory_region_ref(mr_root);\n \n return view;\n }\n@@ -298,6 +301,7 @@ static void flatview_destroy(FlatView *view)\n memory_region_unref(view->ranges[i].mr);\n }\n g_free(view->ranges);\n+ memory_region_unref(view->root);\n g_free(view);\n }\n \n@@ -723,12 +727,25 @@ static void render_memory_region(FlatView *view,\n }\n }\n \n+static MemoryRegion *memory_region_unalias_entire(MemoryRegion *mr)\n+{\n+ while (mr->alias && !mr->alias_offset &&\n+ int128_ge(mr->size, mr->alias->size)) {\n+ /* The alias is included in its entirety. Use it as\n+ * the \"real\" root, so that we can share more FlatViews.\n+ */\n+ mr = mr->alias;\n+ }\n+\n+ return mr;\n+}\n+\n /* Render a memory topology into a list of disjoint absolute ranges. */\n static FlatView *generate_memory_topology(MemoryRegion *mr)\n {\n FlatView *view;\n \n- view = flatview_new();\n+ view = flatview_new(mr);\n \n if (mr) {\n render_memory_region(view, mr, int128_zero(),\n@@ -903,7 +920,8 @@ static void address_space_update_topology_pass(AddressSpace *as,\n static void address_space_update_topology(AddressSpace *as)\n {\n FlatView *old_view = address_space_get_flatview(as);\n- FlatView *new_view = generate_memory_topology(as->root);\n+ MemoryRegion *physmr = memory_region_unalias_entire(old_view->root);\n+ FlatView *new_view = generate_memory_topology(physmr);\n int i;\n \n new_view->dispatch = address_space_dispatch_new(new_view);\n@@ -913,7 +931,6 @@ static void address_space_update_topology(AddressSpace *as)\n flatview_add_to_dispatch(new_view, &mrs);\n }\n address_space_dispatch_compact(new_view->dispatch);\n-\n address_space_update_topology_pass(as, old_view, new_view, false);\n address_space_update_topology_pass(as, old_view, new_view, true);\n \n@@ -2644,7 +2661,7 @@ void address_space_init(AddressSpace *as, MemoryRegion *root, const char *name)\n as->ref_count = 1;\n as->root = root;\n as->malloced = false;\n- as->current_map = flatview_new();\n+ as->current_map = flatview_new(root);\n as->ioeventfd_nb = 0;\n as->ioeventfds = NULL;\n QTAILQ_INIT(&as->listeners);\n","prefixes":["qemu","v3","10/13"]}