{"id":814866,"url":"http://patchwork.ozlabs.org/api/patches/814866/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918101709.30421-5-aik@ozlabs.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918101709.30421-5-aik@ozlabs.ru>","list_archive_url":null,"date":"2017-09-18T10:17:00","name":"[qemu,v3,04/13] memory: Move FlatView allocation to a helper","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f10a6b6859d82f91802bd5d046d5bb73b8ff736c","submitter":{"id":7621,"url":"http://patchwork.ozlabs.org/api/people/7621/?format=json","name":"Alexey Kardashevskiy","email":"aik@ozlabs.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918101709.30421-5-aik@ozlabs.ru/mbox/","series":[{"id":3617,"url":"http://patchwork.ozlabs.org/api/series/3617/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3617","date":"2017-09-18T10:16:57","name":"memory: Reduce memory use","version":3,"mbox":"http://patchwork.ozlabs.org/series/3617/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814866/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814866/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwhqK6BB0z9s7c\n\tfor ;\n\tMon, 18 Sep 2017 20:21:01 +1000 (AEST)","from localhost ([::1]:35602 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dttAh-0008A0-Oq\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 06:20:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41989)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtt7I-0005kL-To\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:17:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtt7E-0004EH-I0\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:17:28 -0400","from ozlabs.ru ([107.173.13.209]:35254)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtt7E-0004Dh-CI\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:17:24 -0400","from vpl1.ozlabs.ibm.com (localhost [IPv6:::1])\n\tby ozlabs.ru (Postfix) with ESMTP id 161973A60050;\n\tMon, 18 Sep 2017 06:18:36 -0400 (EDT)"],"From":"Alexey Kardashevskiy ","To":"qemu-devel@nongnu.org","Date":"Mon, 18 Sep 2017 20:17:00 +1000","Message-Id":"<20170918101709.30421-5-aik@ozlabs.ru>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170918101709.30421-1-aik@ozlabs.ru>","References":"<20170918101709.30421-1-aik@ozlabs.ru>","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"107.173.13.209","Subject":"[Qemu-devel] [PATCH qemu v3 04/13] memory: Move FlatView allocation\n\tto a helper","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"This moves a FlatView allocation and initialization to a helper.\nWhile we are nere, replace g_new with g_new0 to not to bother if we add\nnew fields in the future.\n\nSigned-off-by: Alexey Kardashevskiy \n---\nChanges:\nv3:\n* s/flatview_alloc/flatview_new/\n---\n memory.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)","diff":"diff --git a/memory.c b/memory.c\nindex 5671757011..d3bf0da703 100644\n--- a/memory.c\n+++ b/memory.c\n@@ -258,12 +258,14 @@ static bool flatrange_equal(FlatRange *a, FlatRange *b)\n && a->readonly == b->readonly;\n }\n \n-static void flatview_init(FlatView *view)\n+static FlatView *flatview_new(void)\n {\n+ FlatView *view;\n+\n+ view = g_new0(FlatView, 1);\n view->ref = 1;\n- view->ranges = NULL;\n- view->nr = 0;\n- view->nr_allocated = 0;\n+\n+ return view;\n }\n \n /* Insert a range into a given position. Caller is responsible for maintaining\n@@ -706,8 +708,7 @@ static FlatView *generate_memory_topology(MemoryRegion *mr)\n {\n FlatView *view;\n \n- view = g_new(FlatView, 1);\n- flatview_init(view);\n+ view = flatview_new();\n \n if (mr) {\n render_memory_region(view, mr, int128_zero(),\n@@ -2622,8 +2623,7 @@ void address_space_init(AddressSpace *as, MemoryRegion *root, const char *name)\n as->ref_count = 1;\n as->root = root;\n as->malloced = false;\n- as->current_map = g_new(FlatView, 1);\n- flatview_init(as->current_map);\n+ as->current_map = flatview_new();\n as->ioeventfd_nb = 0;\n as->ioeventfds = NULL;\n QTAILQ_INIT(&as->listeners);\n","prefixes":["qemu","v3","04/13"]}