{"id":814731,"url":"http://patchwork.ozlabs.org/api/patches/814731/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170917225927.117917-12-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170917225927.117917-12-sjg@chromium.org>","list_archive_url":null,"date":"2017-09-17T22:59:22","name":"[U-Boot,11/16] Define board_quiesce_devices() in a shared location","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5f1b74c221c55120036992170740462b45f4045e","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170917225927.117917-12-sjg@chromium.org/mbox/","series":[{"id":3549,"url":"http://patchwork.ozlabs.org/api/series/3549/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3549","date":"2017-09-17T22:59:11","name":"efi: Enable basic sandbox support for EFI loader","version":1,"mbox":"http://patchwork.ozlabs.org/series/3549/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814731/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814731/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"txj57o12\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwRs63D3hz9rxm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 10:36:42 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 311AFC21EC4; Mon, 18 Sep 2017 00:36:40 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 86F49C21F09;\n\tSun, 17 Sep 2017 23:02:10 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 05353C21EA5; Sun, 17 Sep 2017 23:02:05 +0000 (UTC)","from mail-io0-f169.google.com (mail-io0-f169.google.com\n\t[209.85.223.169])\n\tby lists.denx.de (Postfix) with ESMTPS id 73FF8C21EB1\n\tfor <u-boot@lists.denx.de>; Sun, 17 Sep 2017 22:59:42 +0000 (UTC)","by mail-io0-f169.google.com with SMTP id h66so14785509ioh.11\n\tfor <u-boot@lists.denx.de>; Sun, 17 Sep 2017 15:59:42 -0700 (PDT)","from kiwi.bld.corp.google.com ([2620:0:10f2:0:50ee:364d:633f:bd4e])\n\tby smtp.gmail.com with ESMTPSA id\n\te71sm2180784oih.37.2017.09.17.15.59.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 17 Sep 2017 15:59:39 -0700 (PDT)","by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid 855081418B1; Sun, 17 Sep 2017 16:59:38 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=KOwx3kSm7zIdazlky/gYwCGDOiVfjCd/1eyvY0a/LfI=;\n\tb=txj57o12KkqVt/iCZLDx13YoIuxH4MoHNdFdxs542KtZZ/UMTGIIdkTGphCdapRq15\n\tI02j6qDyxwtLKg2cU/W4wwjikE6fWvJGuY/ejRQjvJ8DwNTiwfOyVH8xZhOB9KOsov4j\n\tG+ilO7UMjGVahYeTHzF66l337i91TXofcda2/UMhIXrLWh7/KcUhnyivVRzUnGCyEa2F\n\tmR3gimNyjDAeANuLHQwJH69uvO4UzZJ/+Gio9LA+9FASJlN27C7eEu+4GXJL9LHWPZ8V\n\tP9zeNEjZGRtSA+eEKf+MHDVTcLcXMNuHTg0DlbHo6kLzBUIuoeTWgsxP7gqJ16BXiFez\n\tCrug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=KOwx3kSm7zIdazlky/gYwCGDOiVfjCd/1eyvY0a/LfI=;\n\tb=oZMRvjnkgnmmItAb9JKW//8gjvgVa4AEvfd7nTrR38BHtBndUYpZWwyAPad/ALOff9\n\tHYE7oSWPAyesi1+9+NkvkFzkOwOnblyzLy/6GZ9I+DkUwpzX9G4XWRzJXwxul848z8dS\n\t3Z9dMXYu0FA7VvbVVS/BweRDsY3FMFbd4ZO6fOh2rK/tdx3cZ2oXWswzAEhcTOJODmQy\n\tE0PBBvO12E6VV+USXRFtHmE+AZ7VkMXND0l5LSYXUggt3p2M+X0GGXAOAocY5uaUvFeG\n\tlUc7BdkKvGczQy0Kjp2JdYferoRdN9mzmJoIYN4U/teV2ZkJng284DTGo8vB5qnCJ0Yg\n\tRMeQ==","X-Gm-Message-State":"AHPjjUjsl7ur6YpJVGlCtJ83PzwA/BOp/03zWhmVnDK2M/kNDV2C8Ilt\n\tZGVLbB1AWCoKP5aW","X-Google-Smtp-Source":"AOwi7QAqdgF7jVLFgdKnHZ9ercltp8Q0O0VwZV9O8jk0+zEIO3Z4rVgnDYrCr6ATWeYMzDcvjeQ4nw==","X-Received":"by 10.202.95.137 with SMTP id\n\tt131mr12699601oib.194.1505689181022; \n\tSun, 17 Sep 2017 15:59:41 -0700 (PDT)","From":"Simon Glass <sjg@chromium.org>","To":"U-Boot Mailing List <u-boot@lists.denx.de>","Date":"Sun, 17 Sep 2017 16:59:22 -0600","Message-Id":"<20170917225927.117917-12-sjg@chromium.org>","X-Mailer":"git-send-email 2.14.1.690.gbb1197296e-goog","In-Reply-To":"<20170917225927.117917-1-sjg@chromium.org>","References":"<20170917225927.117917-1-sjg@chromium.org>","Cc":"Andy Shevchenko <andriy.shevchenko@linux.intel.com>,\n\tHeinrich Schuchardt <xypron.glpk@gmx.de>","Subject":"[U-Boot] [PATCH 11/16] Define board_quiesce_devices() in a shared\n\tlocation","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"This undocumented function relies on arch-specific code to declare a nop\nweak version. Add the weak function in common code instead to avoid having\nto duplicate the same function in each arch.\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n arch/arm/include/asm/u-boot-arm.h | 1 -\n arch/x86/include/asm/u-boot-x86.h | 1 -\n arch/x86/lib/bootm.c              | 4 ----\n common/bootm.c                    | 4 ++++\n include/bootm.h                   | 2 ++\n lib/efi_loader/efi_boottime.c     | 4 ++++\n 6 files changed, 10 insertions(+), 6 deletions(-)","diff":"diff --git a/arch/arm/include/asm/u-boot-arm.h b/arch/arm/include/asm/u-boot-arm.h\nindex ef4fca68ee..73ccf41f8c 100644\n--- a/arch/arm/include/asm/u-boot-arm.h\n+++ b/arch/arm/include/asm/u-boot-arm.h\n@@ -38,7 +38,6 @@ int\tarch_early_init_r(void);\n \n /* board/.../... */\n int\tboard_init(void);\n-void\tboard_quiesce_devices(void);\n \n /* cpu/.../interrupt.c */\n int\tarch_interrupt_init\t(void);\ndiff --git a/arch/x86/include/asm/u-boot-x86.h b/arch/x86/include/asm/u-boot-x86.h\nindex 187fe5fd8c..d2e1426042 100644\n--- a/arch/x86/include/asm/u-boot-x86.h\n+++ b/arch/x86/include/asm/u-boot-x86.h\n@@ -85,7 +85,6 @@ static inline __attribute__((no_instrument_function)) uint64_t rdtsc(void)\n /* board/... */\n void timer_set_tsc_base(uint64_t new_base);\n uint64_t timer_get_tsc(void);\n-void board_quiesce_devices(void);\n \n void quick_ram_check(void);\n \ndiff --git a/arch/x86/lib/bootm.c b/arch/x86/lib/bootm.c\nindex ecd4f4e6c6..d9063a76d7 100644\n--- a/arch/x86/lib/bootm.c\n+++ b/arch/x86/lib/bootm.c\n@@ -33,10 +33,6 @@ int arch_fixup_fdt(void *blob)\n \treturn 0;\n }\n \n-__weak void board_quiesce_devices(void)\n-{\n-}\n-\n void bootm_announce_and_cleanup(void)\n {\n \tprintf(\"\\nStarting kernel ...\\n\\n\");\ndiff --git a/common/bootm.c b/common/bootm.c\nindex 32b3ea8e2d..f64742168c 100644\n--- a/common/bootm.c\n+++ b/common/bootm.c\n@@ -47,6 +47,10 @@ static const void *boot_get_kernel(cmd_tbl_t *cmdtp, int flag, int argc,\n \t\t\t\t   char * const argv[], bootm_headers_t *images,\n \t\t\t\t   ulong *os_data, ulong *os_len);\n \n+__weak void board_quiesce_devices(void)\n+{\n+}\n+\n #ifdef CONFIG_LMB\n static void boot_start_lmb(bootm_headers_t *images)\n {\ndiff --git a/include/bootm.h b/include/bootm.h\nindex 49813772ce..76b6ab42e6 100644\n--- a/include/bootm.h\n+++ b/include/bootm.h\n@@ -73,4 +73,6 @@ int bootm_decomp_image(int comp, ulong load, ulong image_start, int type,\n \t\t       void *load_buf, void *image_buf, ulong image_len,\n \t\t       uint unc_len, ulong *load_end);\n \n+void board_quiesce_devices(void);\n+\n #endif\ndiff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\nindex d832f48599..03b97d36ae 100644\n--- a/lib/efi_loader/efi_boottime.c\n+++ b/lib/efi_loader/efi_boottime.c\n@@ -883,6 +883,10 @@ static void efi_exit_caches(void)\n #endif\n }\n \n+__weak void board_quiesce_devices(void)\n+{\n+}\n+\n static efi_status_t EFIAPI efi_exit_boot_services(void *image_handle,\n \t\t\t\t\t\t  unsigned long map_key)\n {\n","prefixes":["U-Boot","11/16"]}