{"id":814730,"url":"http://patchwork.ozlabs.org/api/patches/814730/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170917225927.117917-15-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170917225927.117917-15-sjg@chromium.org>","list_archive_url":null,"date":"2017-09-17T22:59:25","name":"[U-Boot,14/16] efi: Add a comment about duplicated ELF constants","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"88e7a07721095d92e56cdfb451d6681895410e5e","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170917225927.117917-15-sjg@chromium.org/mbox/","series":[{"id":3549,"url":"http://patchwork.ozlabs.org/api/series/3549/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3549","date":"2017-09-17T22:59:11","name":"efi: Enable basic sandbox support for EFI loader","version":1,"mbox":"http://patchwork.ozlabs.org/series/3549/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814730/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814730/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"JKI4ADpe\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwRl71DCXz9sBZ\n\tfor ;\n\tMon, 18 Sep 2017 10:31:31 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid E507DC21EC1; Mon, 18 Sep 2017 00:31:29 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B420DC21F02;\n\tSun, 17 Sep 2017 23:02:09 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid DD4A7C21EAB; Sun, 17 Sep 2017 23:02:05 +0000 (UTC)","from mail-io0-f181.google.com (mail-io0-f181.google.com\n\t[209.85.223.181])\n\tby lists.denx.de (Postfix) with ESMTPS id 01305C21EBD\n\tfor ; Sun, 17 Sep 2017 22:59:45 +0000 (UTC)","by mail-io0-f181.google.com with SMTP id g32so14832934ioj.2\n\tfor ; Sun, 17 Sep 2017 15:59:44 -0700 (PDT)","from kiwi.bld.corp.google.com ([100.101.164.89])\n\tby smtp.gmail.com with ESMTPSA id\n\tq83sm7207512oif.4.2017.09.17.15.59.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 17 Sep 2017 15:59:42 -0700 (PDT)","by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid 7C214141F7D; Sun, 17 Sep 2017 16:59:40 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=wGTYYowmo9hkSMhGVnP9GdESvIWfF8t6XyX+g7LB3q8=;\n\tb=JKI4ADpeUtVHo3qlGN81uMBWFcKp51AJt9HEs9juatqAzurEMULfmwyL6arwbz1+gC\n\tKGOzO8W52eOIweV1eEQk5EJjyidI+EppwwhuMO19Wrx6IcZnod/ft73QmHMRAXF3aULV\n\taSy5bHrYWNjoBD6XT1SCubdYksNObY3t/897Nf85jki5NlTwchMUOQCT+GXHBCy9qiyD\n\tIy+27DrRWFj/OnVao5N6UinquS5ufIrVD2dWfv6xUC3clXKvZVuTnh05RTAfBM7J8ayP\n\tJTfbSGwhedY1RDuhncxKjr/8nh6IfTgv2ps3m2srlIJzyOOVgFxKYgqnN6eYO18oTvx8\n\td6Sw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=wGTYYowmo9hkSMhGVnP9GdESvIWfF8t6XyX+g7LB3q8=;\n\tb=qgHvcGCOtm6/j5cz7II0Yixwt5sVai00DsbQFhRXt9sfqaVKaTTKYDqvadfuYdpkDW\n\tqXFD9qd/5SqsY6H2Edkt2xUIKmSUw9iewNSckAekyWKfqFGo6ERx6N61QmEfiDO2SYOW\n\tD+yheMvPaxk3zLJvE6zMRWE/ZqGcnisP8yKKX+r5OLz+2ft3AVlNz1AyIxonlgOQvU8N\n\t6qQb3oSGSkda1op6Ygcmr9KPBhiEHVx/mGnRAzk0eECFIh3CHKrA7EEJ+OfVwv/C2bgT\n\tZDS9MUSl9MNLVW/NWiNM7VvIDC+Mvgw1wP0W4jvsS3vIm3lSzY6sw3O3YfDwx5zQbYnh\n\tdqCQ==","X-Gm-Message-State":"AHPjjUjQIREyoW/iG5oUgyHqTh5CjJ8O6oH5Dk+J04gQTpnSoiwyM08/\n\t8wtbJg2hOI46h0fr","X-Google-Smtp-Source":"AOwi7QCyvIXgHUJ//6FgVUlHuIw0fizS3zfa21rpaLmxFgMKYSfS6qdY9egnCyQS12iZTMYEuqNwFg==","X-Received":"by 10.202.79.211 with SMTP id d202mr1859839oib.42.1505689183637; \n\tSun, 17 Sep 2017 15:59:43 -0700 (PDT)","From":"Simon Glass ","To":"U-Boot Mailing List ","Date":"Sun, 17 Sep 2017 16:59:25 -0600","Message-Id":"<20170917225927.117917-15-sjg@chromium.org>","X-Mailer":"git-send-email 2.14.1.690.gbb1197296e-goog","In-Reply-To":"<20170917225927.117917-1-sjg@chromium.org>","References":"<20170917225927.117917-1-sjg@chromium.org>","Cc":"Andy Shevchenko ,\n\tHeinrich Schuchardt ","Subject":"[U-Boot] [PATCH 14/16] efi: Add a comment about duplicated ELF\n\tconstants","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"These constants are defined in arch-specific code but redefined here. Add\na TODO to clean this up.\n\nSigned-off-by: Simon Glass \n---\n\n lib/efi_loader/efi_runtime.c | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c\nindex 8ad1d2fc99..f52d8d71db 100644\n--- a/lib/efi_loader/efi_runtime.c\n+++ b/lib/efi_loader/efi_runtime.c\n@@ -37,6 +37,10 @@ static efi_status_t __efi_runtime EFIAPI efi_invalid_parameter(void);\n #define EFI_CACHELINE_SIZE 128\n #endif\n \n+/*\n+ * TODO(sjg@chromium.org): These defines and structs should come from the elf.\n+ * header for each arch (or a generic header) rather than being repeated here.\n+ */\n #if defined(CONFIG_ARM64)\n #define R_RELATIVE\t1027\n #define R_MASK\t\t0xffffffffULL\n","prefixes":["U-Boot","14/16"]}