{"id":814714,"url":"http://patchwork.ozlabs.org/api/patches/814714/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170917232010.14183-5-f4bug@amsat.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170917232010.14183-5-f4bug@amsat.org>","list_archive_url":null,"date":"2017-09-17T23:20:08","name":"[v3,4/6] mips: call cpu_mips_realize_env() from mips_cpu_realizefn()","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"173a3805a639cff3cc5778c25ccc431df20f76af","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/?format=json","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170917232010.14183-5-f4bug@amsat.org/mbox/","series":[{"id":3548,"url":"http://patchwork.ozlabs.org/api/series/3548/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3548","date":"2017-09-17T23:20:04","name":"QOMify MIPS cpu","version":3,"mbox":"http://patchwork.ozlabs.org/series/3548/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814714/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814714/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ZUM1vmY+\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwQDn3bQrz9s7G\n\tfor ;\n\tMon, 18 Sep 2017 09:23:37 +1000 (AEST)","from localhost ([::1]:33970 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtiuV-0005Mu-KJ\n\tfor incoming@patchwork.ozlabs.org; Sun, 17 Sep 2017 19:23:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42690)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dtirj-0003Oc-8x\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 19:20:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dtiri-0007aq-19\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 19:20:43 -0400","from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:37109)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtirh-0007aW-KC\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 19:20:41 -0400","by mail-qt0-x244.google.com with SMTP id u48so4698816qtc.4\n\tfor ; Sun, 17 Sep 2017 16:20:41 -0700 (PDT)","from yoga.offpageads.com ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tz75sm4132114qkb.71.2017.09.17.16.20.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 17 Sep 2017 16:20:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=NH8TvAzvRl3fTHfE/31Bx3YX3regwTO6EcNX9WiRiOQ=;\n\tb=ZUM1vmY+/rEYG9RVpHHjskygse4CXNb8Z8Tp/45hQ2q8tjdN/Aq7W9xWHOj5vujfYZ\n\tFeFxHHhJiQumcZ44gGrnRqNTY/IcynlQVX/s6PJQWIMUk1EPuahG5ja4LIRG+HKCN0WV\n\tpMkeXMgx9JLNRScqj8oT/Ns1dZlm+QYpQZdG5rUj4F5b3WFxnjA6ykk+5pPPjjDZQG7t\n\tLt9TW24UWkace+j77qndMuzDdq3Xeo53P0E8tjjMHlKB8NyZGMKuC8aNSx6Ax8daGvU5\n\tjDYvc04JSxYrXz4FGdeVQq6SnOfpktWYZsca4jo/s5h3jYKRWYEsa7M637q7/yQ1IUXs\n\tJruQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=NH8TvAzvRl3fTHfE/31Bx3YX3regwTO6EcNX9WiRiOQ=;\n\tb=uVdIBlldGINOrbYQGZPDZiqmM9IOQY+7wdmJ63EZznWhaBj9tvDggJtY5armJ2Fmj+\n\txrALekfnglc/i3jtE9AHUsIulTGGCbd9VHKtQlTV8SOIsADDqwa3obHCdXxQxmNZbU1n\n\tnc1mp67qhgwPV8MTPZAxeqIqPNj45jle2oMNDY4b/8x+hdut7C5qabOBa0AAq9JA1tC0\n\tMuz72iejrQJ++G/cQZxOyJ2eSWd1ElLpVVAk1DiXargCKjyVeigYm3UIepYgiQ/jvTdb\n\tXCmVIdaiYjCXjsRPU51+4MO6MraCODf/WRseGHU2cnDsrH2CK+HhEt0f30os7Sx/gde2\n\tJCzg==","X-Gm-Message-State":"AHPjjUjC7A2jGgW3RZXNdsRx9Rc31041MMqdOhsFg7D2XVehxjaYoU8t\n\tI6NFpBzUm38SZQ==","X-Google-Smtp-Source":"AOwi7QCnMAKyQP9OMjQd8PYD8gSHTtIJXYGp7lqooYMrtvvL3cC4hnbog8qvXC4pm/qbFxAjoDO8aA==","X-Received":"by 10.200.41.232 with SMTP id 37mr415073qtt.47.1505690441171;\n\tSun, 17 Sep 2017 16:20:41 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Igor Mammedov ,\n\tEduardo Habkost , \n\tAurelien Jarno ,\n\tYongbok Kim ,\n\tMarcel Apfelbaum ","Date":"Sun, 17 Sep 2017 20:20:08 -0300","Message-Id":"<20170917232010.14183-5-f4bug@amsat.org>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170917232010.14183-1-f4bug@amsat.org>","References":"<20170917232010.14183-1-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::244","Subject":"[Qemu-devel] [PATCH v3 4/6] mips: call cpu_mips_realize_env() from\n\tmips_cpu_realizefn()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Huth , James Hogan ,\n\t=?utf-8?q?Herv=C3=A9_Poussineau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"This changes the order between cpu_mips_realize_env() and\ncpu_exec_initfn(), but cpu_exec_initfn() don't have anything that\ndepends on cpu_mips_realize_env() being called first.\n\nSigned-off-by: Philippe Mathieu-Daudé \nTested-by: Igor Mammedov \nTested-by: James Hogan \nReviewed-by: Eduardo Habkost \n---\n target/mips/cpu.c | 3 +++\n target/mips/translate.c | 1 -\n 2 files changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/target/mips/cpu.c b/target/mips/cpu.c\nindex 68bf423e9d..e3ef835599 100644\n--- a/target/mips/cpu.c\n+++ b/target/mips/cpu.c\n@@ -123,6 +123,7 @@ static void mips_cpu_disas_set_info(CPUState *s, disassemble_info *info) {\n static void mips_cpu_realizefn(DeviceState *dev, Error **errp)\n {\n CPUState *cs = CPU(dev);\n+ MIPSCPU *cpu = MIPS_CPU(dev);\n MIPSCPUClass *mcc = MIPS_CPU_GET_CLASS(dev);\n Error *local_err = NULL;\n \n@@ -132,6 +133,8 @@ static void mips_cpu_realizefn(DeviceState *dev, Error **errp)\n return;\n }\n \n+ cpu_mips_realize_env(&cpu->env);\n+\n cpu_reset(cs);\n qemu_init_vcpu(cs);\n \ndiff --git a/target/mips/translate.c b/target/mips/translate.c\nindex 5fc7979ac5..94c38e8755 100644\n--- a/target/mips/translate.c\n+++ b/target/mips/translate.c\n@@ -20535,7 +20535,6 @@ MIPSCPU *cpu_mips_init(const char *cpu_model)\n cpu = MIPS_CPU(object_new(TYPE_MIPS_CPU));\n env = &cpu->env;\n env->cpu_model = def;\n- cpu_mips_realize_env(env);\n \n object_property_set_bool(OBJECT(cpu), true, \"realized\", NULL);\n \n","prefixes":["v3","4/6"]}