{"id":814612,"url":"http://patchwork.ozlabs.org/api/patches/814612/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/patch/20170917092028.5236-1-yann.morin.1998@free.fr/","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170917092028.5236-1-yann.morin.1998@free.fr>","list_archive_url":null,"date":"2017-09-17T09:20:28","name":"support/run-tests: export download dir","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d00b538c4d48097c417274ac2a4025ece72bb5d2","submitter":{"id":13903,"url":"http://patchwork.ozlabs.org/api/people/13903/?format=json","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/20170917092028.5236-1-yann.morin.1998@free.fr/mbox/","series":[{"id":3493,"url":"http://patchwork.ozlabs.org/api/series/3493/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/list/?series=3493","date":"2017-09-17T09:20:28","name":"support/run-tests: export download dir","version":1,"mbox":"http://patchwork.ozlabs.org/series/3493/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814612/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814612/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"n4HrwYxj\"; dkim-atps=neutral"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xw3XH5PMsz9rxm\n\tfor ;\n\tSun, 17 Sep 2017 19:20:47 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1473389A4E;\n\tSun, 17 Sep 2017 09:20:42 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LX70F2CPQQPA; Sun, 17 Sep 2017 09:20:40 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 286D3899FC;\n\tSun, 17 Sep 2017 09:20:40 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 718901C04A5\n\tfor ;\n\tSun, 17 Sep 2017 09:20:39 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6B91887EA2\n\tfor ;\n\tSun, 17 Sep 2017 09:20:39 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fwbRa3jfCVo6 for ;\n\tSun, 17 Sep 2017 09:20:38 +0000 (UTC)","from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id A096587E91\n\tfor ; Sun, 17 Sep 2017 09:20:38 +0000 (UTC)","by mail-wm0-f65.google.com with SMTP id m127so805107wmm.0\n\tfor ; Sun, 17 Sep 2017 02:20:38 -0700 (PDT)","from localhost.localdomain\n\t(2a01cb088610730059d6abb0cf94ea78.ipv6.abo.wanadoo.fr.\n\t[2a01:cb08:8610:7300:59d6:abb0:cf94:ea78])\n\tby smtp.gmail.com with ESMTPSA id\n\t55sm5718225wrw.60.2017.09.17.02.20.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 17 Sep 2017 02:20:35 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id;\n\tbh=zlxxzkg6Ikr0vypqSx4oyh5ecxK8sGlsiqiX499A+HM=;\n\tb=n4HrwYxjx972kHkImtmJB7IaEtMF64k5IN/8nd+xJUx0T1BFPj5LW/TqYik5JgyAGi\n\tFiAcHU85yTBSZqxEuHq+F984UlmpM8reLt6GuHHcdko4op3lo7JZQLZTMGvl5ix0dw60\n\t+XLYr+jYFJSxSbWGzS9f2PnpL+y8BBJeFZ2ZkUXE1XHjUujFPQBh8fk1FylkL6VdyHM/\n\tDoT1iQxH0nxDZQpqkM5jnLaTS6NzEu7p8bqPmBmZ1T1gTsT6L9Ts5GSiCOcWyOc/yme0\n\tvrv9bf0rrCRsf2qDsuAOJCX5Rik/Qk9WoAc2W85Hpl6BuWCIyD0fuAq7BnJDuNNp4mJI\n\t4Zjg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id;\n\tbh=zlxxzkg6Ikr0vypqSx4oyh5ecxK8sGlsiqiX499A+HM=;\n\tb=tmhSRlpqRoFxXTW2eGrxZuR0/LgMTkKhNS+h9qWsTJryCB/sFZBogpDM1s3FtvJ4Dj\n\tNPMUeLKzodJjMqTt/uJqdDSWfZoGZd/1Xags+l9Acnd1JauoGixyDF7/R7zG8Wp3Tiz5\n\tkloAx3DvzP6iyHMo/8S6IqIB4qmfpjReyemBVNU7eHuL9h4mcUNIPmSsqp59GZ8bAi0j\n\tOiy6ygjq1VLFLTiDfdgPjge/hw7fkgIAAiEwg8CMtiKZVbLaDmv7BYzhjPu4QeCcZxiP\n\tEt3a49jkt9ZO+vc68bxWn04Cu+G7HvHaJGG1IXys57QRfnBo6IVJ2ByS3BnFuPvn17Xb\n\t2Nxw==","X-Gm-Message-State":"AHPjjUhW1yX3U7+lyUhxwa+s1YZ7p8bIk2o3wmNaeuy6jD35nLijhAoW\n\t96BGtUgBWukOkL2M","X-Google-Smtp-Source":"AOwi7QBWB6mo5qjHlyNvcyWZtT85Sz9xN3vh04yEFA4bvrKG+ujY/Tpe0y3M/QrP1h/8+0NBeMcQfg==","X-Received":"by 10.28.155.209 with SMTP id d200mr6670314wme.138.1505640036572;\n\tSun, 17 Sep 2017 02:20:36 -0700 (PDT)","From":"\"Yann E. MORIN\" ","To":"buildroot@buildroot.org","Date":"Sun, 17 Sep 2017 11:20:28 +0200","Message-Id":"<20170917092028.5236-1-yann.morin.1998@free.fr>","X-Mailer":"git-send-email 2.11.0","Cc":"Thomas Petazzoni ,\n\t\"Yann E. MORIN\" ,\n\tRicardo Martincoski ","Subject":"[Buildroot] [PATCH] support/run-tests: export download dir","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "},"content":"Currently, the download directory, when specified with the -d option, is\nonly used to store the files downloaded by the testing infra, not those\ndownloaded by Buildroot.\n\nSo, we end up with this situation:\n\n BR2_DL_DIR | -d DIR | test downloads | BR downloads\n ------------+----------+------------------+--------------\n unset | unset | [error] | [error]\n unset | set | in $(DIR) | in $(TOP_DIR)/dl\n set | unset | in $(BR2_DL_DIR) | in $(BR2_DL_DIR)\n set | set | in $(DIR) | in $(BR2_DL_DIR)\n\nThis is not very consistent.\n\nWe change the behaviour so that the value of -d always takes precedence,\nand is used by Buildroot as well, giving this new behaviour:\n\n BR2_DL_DIR | -d DIR | test downloads | BR downloads\n ------------+----------+------------------+--------------\n unset | unset | [error] | [error]\n unset | set | in $(DIR) | in $(DIR)\n set | unset | in $(BR2_DL_DIR) | in $(BR2_DL_DIR)\n set | set | in $(DIR) | in $(DIR)\n\nSigned-off-by: \"Yann E. MORIN\" \nCc: Ricardo Martincoski \nCc: Thomas Petazzoni \n---\n support/testing/run-tests | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/support/testing/run-tests b/support/testing/run-tests\nindex ae0bd336b5..5c9897e0f5 100755\n--- a/support/testing/run-tests\n+++ b/support/testing/run-tests\n@@ -57,6 +57,7 @@ def main():\n return 1\n \n BRTest.downloaddir = os.path.abspath(args.download)\n+ os.putenv(\"BR2_DL_DIR\", BRTest.downloaddir)\n \n if args.output is None:\n print \"Missing output directory, please use -o/--output\"\n","prefixes":[]}