{"id":814588,"url":"http://patchwork.ozlabs.org/api/patches/814588/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505621128-23877-6-git-send-email-sukadev@linux.vnet.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1505621128-23877-6-git-send-email-sukadev@linux.vnet.ibm.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1505621128-23877-6-git-send-email-sukadev@linux.vnet.ibm.com/","date":"2017-09-17T04:05:23","name":"[05/10] powerpc/vas: Use helper to unpin/close window","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"c8d22217860a76a6934984148e170ba65a619272","submitter":{"id":984,"url":"http://patchwork.ozlabs.org/api/people/984/?format=json","name":"Sukadev Bhattiprolu","email":"sukadev@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505621128-23877-6-git-send-email-sukadev@linux.vnet.ibm.com/mbox/","series":[{"id":3482,"url":"http://patchwork.ozlabs.org/api/series/3482/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=3482","date":"2017-09-17T04:05:19","name":"powerpc/vas: cleanup and optimizations","version":1,"mbox":"http://patchwork.ozlabs.org/series/3482/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814588/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814588/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvwkG4p11z9s7h\n\tfor ;\n\tSun, 17 Sep 2017 14:13:58 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xvwkG3xXszDrSM\n\tfor ;\n\tSun, 17 Sep 2017 14:13:58 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xvwXs0Kf7zDrp1\n\tfor ;\n\tSun, 17 Sep 2017 14:05:49 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\tby bilbo.ozlabs.org (Postfix) with ESMTP id 3xvwXr6r6zz8t3H\n\tfor ;\n\tSun, 17 Sep 2017 14:05:48 +1000 (AEST)","by ozlabs.org (Postfix)\n\tid 3xvwXr6Fn1z9t2M; Sun, 17 Sep 2017 14:05:48 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvwXr3lKXz9t16\n\tfor ; Sun, 17 Sep 2017 14:05:48 +1000 (AEST)","from pps.filterd (m0098396.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8H44U3k091594\n\tfor ; Sun, 17 Sep 2017 00:05:46 -0400","from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d0x9q4rq3-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Sun, 17 Sep 2017 00:05:46 -0400","from localhost\n\tby e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tSat, 16 Sep 2017 22:05:46 -0600","from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19)\n\tby e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tSat, 16 Sep 2017 22:05:42 -0600","from b03ledav005.gho.boulder.ibm.com\n\t(b03ledav005.gho.boulder.ibm.com [9.17.130.236])\n\tby b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8H45ghh65601564; Sat, 16 Sep 2017 21:05:42 -0700","from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2F9EDBE03B;\n\tSat, 16 Sep 2017 22:05:42 -0600 (MDT)","from suka-w540.usor.ibm.com (unknown [9.70.94.25])\n\tby b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP id BF7BFBE039;\n\tSat, 16 Sep 2017 22:05:41 -0600 (MDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=sukadev@linux.vnet.ibm.com; receiver=)","From":"Sukadev Bhattiprolu ","To":"Michael Ellerman ","Subject":"[PATCH 05/10] powerpc/vas: Use helper to unpin/close window","Date":"Sat, 16 Sep 2017 21:05:23 -0700","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1505621128-23877-1-git-send-email-sukadev@linux.vnet.ibm.com>","References":"<1505621128-23877-1-git-send-email-sukadev@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17091704-0008-0000-0000-000008951201","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007754; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000229; SDB=6.00918138; UDB=6.00461174;\n\tIPR=6.00698363; \n\tBA=6.00005592; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017185;\n\tXFM=3.00000015; UTC=2017-09-17 04:05:44","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091704-0009-0000-0000-00004400E38F","Message-Id":"<1505621128-23877-6-git-send-email-sukadev@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-17_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709170058","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@ozlabs.org, mikey@neuling.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"Use a helper to have the hardware unpin and mark a window closed.\n\nSigned-off-by: Sukadev Bhattiprolu \n---\n arch/powerpc/platforms/powernv/vas-window.c | 22 +++++++++++++++-------\n 1 file changed, 15 insertions(+), 7 deletions(-)","diff":"diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c\nindex 8ab8a82..95622a9 100644\n--- a/arch/powerpc/platforms/powernv/vas-window.c\n+++ b/arch/powerpc/platforms/powernv/vas-window.c\n@@ -1101,6 +1101,20 @@ static void poll_window_castout(struct vas_window *window)\n }\n \n /*\n+ * Unpin and close a window so no new requests are accepted and the\n+ * hardware can evict this window from cache if necessary.\n+ */\n+static void unpin_close_window(struct vas_window *window)\n+{\n+\tu64 val;\n+\n+\tval = read_hvwc_reg(window, VREG(WINCTL));\n+\tval = SET_FIELD(VAS_WINCTL_PIN, val, 0);\n+\tval = SET_FIELD(VAS_WINCTL_OPEN, val, 0);\n+\twrite_hvwc_reg(window, VREG(WINCTL), val);\n+}\n+\n+/*\n * Close a window.\n *\n * See Section 1.12.1 of VAS workbook v1.05 for details on closing window:\n@@ -1114,8 +1128,6 @@ static void poll_window_castout(struct vas_window *window)\n */\n int vas_win_close(struct vas_window *window)\n {\n-\tu64 val;\n-\n \tif (!window)\n \t\treturn 0;\n \n@@ -1131,11 +1143,7 @@ int vas_win_close(struct vas_window *window)\n \n \tpoll_window_busy_state(window);\n \n-\t/* Unpin window from cache and close it */\n-\tval = read_hvwc_reg(window, VREG(WINCTL));\n-\tval = SET_FIELD(VAS_WINCTL_PIN, val, 0);\n-\tval = SET_FIELD(VAS_WINCTL_OPEN, val, 0);\n-\twrite_hvwc_reg(window, VREG(WINCTL), val);\n+\tunpin_close_window(window);\n \n \tpoll_window_castout(window);\n \n","prefixes":["05/10"]}