{"id":814586,"url":"http://patchwork.ozlabs.org/api/patches/814586/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505621128-23877-5-git-send-email-sukadev@linux.vnet.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1505621128-23877-5-git-send-email-sukadev@linux.vnet.ibm.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1505621128-23877-5-git-send-email-sukadev@linux.vnet.ibm.com/","date":"2017-09-17T04:05:22","name":"[04/10] powerpc/vas: Drop poll_window_cast_out().","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"5fc4a809d2beb464e95d8f51013356ffa2d1c3dc","submitter":{"id":984,"url":"http://patchwork.ozlabs.org/api/people/984/?format=json","name":"Sukadev Bhattiprolu","email":"sukadev@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505621128-23877-5-git-send-email-sukadev@linux.vnet.ibm.com/mbox/","series":[{"id":3482,"url":"http://patchwork.ozlabs.org/api/series/3482/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=3482","date":"2017-09-17T04:05:19","name":"powerpc/vas: cleanup and optimizations","version":1,"mbox":"http://patchwork.ozlabs.org/series/3482/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814586/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814586/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvwgW5mRjz9s7h\n\tfor ;\n\tSun, 17 Sep 2017 14:11:35 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xvwgW4wv6zDsMK\n\tfor ;\n\tSun, 17 Sep 2017 14:11:35 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xvwXp6FLTzDrnY\n\tfor ;\n\tSun, 17 Sep 2017 14:05:46 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\tby bilbo.ozlabs.org (Postfix) with ESMTP id 3xvwXp5dDWz8v8G\n\tfor ;\n\tSun, 17 Sep 2017 14:05:46 +1000 (AEST)","by ozlabs.org (Postfix)\n\tid 3xvwXp5C6nz9t2M; Sun, 17 Sep 2017 14:05:46 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvwXp0vkGz9t2f\n\tfor ; Sun, 17 Sep 2017 14:05:45 +1000 (AEST)","from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8H44QaQ097604\n\tfor ; Sun, 17 Sep 2017 00:05:44 -0400","from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d0wk9bae6-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Sun, 17 Sep 2017 00:05:43 -0400","from localhost\n\tby e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tSat, 16 Sep 2017 22:05:43 -0600","from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15)\n\tby e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tSat, 16 Sep 2017 22:05:41 -0600","from b03ledav005.gho.boulder.ibm.com\n\t(b03ledav005.gho.boulder.ibm.com [9.17.130.236])\n\tby b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8H45e0Z59834476; Sat, 16 Sep 2017 21:05:40 -0700","from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A8E4BBE038;\n\tSat, 16 Sep 2017 22:05:40 -0600 (MDT)","from suka-w540.usor.ibm.com (unknown [9.70.94.25])\n\tby b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP id 4F14BBE03A;\n\tSat, 16 Sep 2017 22:05:40 -0600 (MDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=sukadev@linux.vnet.ibm.com; receiver=)","From":"Sukadev Bhattiprolu ","To":"Michael Ellerman ","Subject":"[PATCH 04/10] powerpc/vas: Drop poll_window_cast_out().","Date":"Sat, 16 Sep 2017 21:05:22 -0700","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1505621128-23877-1-git-send-email-sukadev@linux.vnet.ibm.com>","References":"<1505621128-23877-1-git-send-email-sukadev@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17091704-0020-0000-0000-00000CB87755","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007754; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000229; SDB=6.00918138; UDB=6.00461173;\n\tIPR=6.00698363; \n\tBA=6.00005592; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017185;\n\tXFM=3.00000015; UTC=2017-09-17 04:05:42","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091704-0021-0000-0000-00005E29124B","Message-Id":"<1505621128-23877-5-git-send-email-sukadev@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-17_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709170058","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@ozlabs.org, mikey@neuling.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"Polling for window cast out is listed in the spec, but turns out that\nit is not strictly necessary and slows down window close. Making it a\nstub for now.\n\nSigned-off-by: Sukadev Bhattiprolu \n---\n arch/powerpc/platforms/powernv/vas-window.c | 34 ++++++++++++++---------------\n 1 file changed, 17 insertions(+), 17 deletions(-)","diff":"diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c\nindex 67ffc5d..8ab8a82 100644\n--- a/arch/powerpc/platforms/powernv/vas-window.c\n+++ b/arch/powerpc/platforms/powernv/vas-window.c\n@@ -1079,25 +1079,25 @@ static void poll_window_busy_state(struct vas_window *window)\n \t}\n }\n \n+/*\n+ * Have the hardware cast a window out of cache and wait for it to\n+ * be completed.\n+ *\n+ * NOTE: It can take a relatively long time to cast the window context\n+ *\tout of the cache. It is not strictly necessary to cast out if:\n+ *\n+ *\t- we clear the \"Pin Window\" bit (so hardware is free to evict)\n+ *\n+ *\t- we re-initialize the window context when it is reassigned.\n+ *\n+ *\tWe do the former in vas_win_close() and latter in vas_win_open().\n+ *\tSo, ignoring the cast-out for now. We can add it as needed. If\n+ *\tcasting out becomes necessary we should consider offloading the\n+ *\tjob to a worker thread, so the window close can proceed quickly.\n+ */\n static void poll_window_castout(struct vas_window *window)\n {\n-\tint cached;\n-\tu64 val;\n-\n-\t/* Cast window context out of the cache */\n-retry:\n-\tval = read_hvwc_reg(window, VREG(WIN_CTX_CACHING_CTL));\n-\tcached = GET_FIELD(VAS_WIN_CACHE_STATUS, val);\n-\tif (cached) {\n-\t\tval = 0ULL;\n-\t\tval = SET_FIELD(VAS_CASTOUT_REQ, val, 1);\n-\t\tval = SET_FIELD(VAS_PUSH_TO_MEM, val, 0);\n-\t\twrite_hvwc_reg(window, VREG(WIN_CTX_CACHING_CTL), val);\n-\n-\t\tset_current_state(TASK_UNINTERRUPTIBLE);\n-\t\tschedule_timeout(HZ);\n-\t\tgoto retry;\n-\t}\n+\t/* stub for now */\n }\n \n /*\n","prefixes":["04/10"]}