{"id":814536,"url":"http://patchwork.ozlabs.org/api/patches/814536/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/CAKwh3qim6+Twqx9tKuOh_w8o7MTEhYB0UKruKvh2=9UxwhkFkQ@mail.gmail.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-16T17:21:50","name":"[Fortran] PR 82018: -Wextra should imply -Wconversion-extra","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a9dc113b27e36dc71f931e56a8199d4dd77e1575","submitter":{"id":4401,"url":"http://patchwork.ozlabs.org/api/people/4401/?format=json","name":"Janus Weil","email":"janus@gcc.gnu.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/CAKwh3qim6+Twqx9tKuOh_w8o7MTEhYB0UKruKvh2=9UxwhkFkQ@mail.gmail.com/mbox/","series":[{"id":3461,"url":"http://patchwork.ozlabs.org/api/series/3461/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=3461","date":"2017-09-16T17:21:50","name":"[Fortran] PR 82018: -Wextra should imply -Wconversion-extra","version":1,"mbox":"http://patchwork.ozlabs.org/series/3461/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814536/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814536/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462311-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"sp2Jw7fm\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvfG90nlgz9s7p\n\tfor ;\n\tSun, 17 Sep 2017 03:22:08 +1000 (AEST)","(qmail 9722 invoked by alias); 16 Sep 2017 17:21:55 -0000","(qmail 7718 invoked by uid 89); 16 Sep 2017 17:21:54 -0000","from mail-yw0-f181.google.com (HELO mail-yw0-f181.google.com)\n\t(209.85.161.181) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tSat, 16 Sep 2017 17:21:52 +0000","by mail-yw0-f181.google.com with SMTP id p10so3046757ywh.8;\n\tSat, 16 Sep 2017 10:21:52 -0700 (PDT)","by 10.129.162.148 with HTTP; Sat, 16 Sep 2017 10:21:50 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:from:date:message-id:subject:to:content-type; q=\n\tdns; s=default; b=E9I628sIa2SpdkWYtflKZUkEf8JE/Fi+daq3m3GAP9BoJ5\n\tiDYOkzzlEBKGfT+N8abM7oZH5wvfQO/HKCWfFfHh/kgYFAACpPekxkgj/RqaTUE6\n\tit9fYmqH9vV6PvbrMVWS4RS2UpepZOG4br0aSkJvlvjkDr3cO8TmRSwa3Pb6o=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:from:date:message-id:subject:to:content-type; s=\n\tdefault; bh=Tq6ceuIFDGzhw+EIfvZq6tFtTcc=; b=sp2Jw7fmjqf4L1ZZ48wC\n\tRliMUQxIr7DYgPHM2jEyXYcaLImXEF1RHMcE4nznWXr/OrHKzmM6oP8IDVI1Aca/\n\tFMREVRTH7eTi28McEZz/H6yt1vazs4RMy27HAlC+oebi/i7wOCpWobBI9QX4mC5K\n\tqmmiUOHcw9EqBE53NrGKANI=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-14.0 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_1,\n\tGIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=Janus","X-Spam-User":"qpsmtpd, 2 recipients","X-HELO":"mail-yw0-f181.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:mime-version:sender:from:date:message-id:subject\n\t:to; bh=goZLD1mGEfltoe2j52SG3W0W/h+tMzZNFknAOKCaOEM=;\n\tb=t1+W/yUgZARMhwVAYjheJWAcTtSi+S7/O76lGpDO7pHLUoJwuwh28URbOxE2RpH70n\n\tE07szYp2Qq2dYgbCnhpHUILLF+ENep4+ShAoo2XlEnLkRCucJD8AyIqC8CF3dOnV4r6A\n\tg8/soGLKQyCM5pH67CUE8X6KKvL/iC32Id5VSVmJhp1K1GUugRi9FQZm0umrOgNWefq7\n\tjzaKt4F4dlZIKJrDMFzSamM57CkX6xpHb4RH8x7L9WpD0Iyi/jnMIGpZNIOIjxoHQ+3G\n\tunStgAEbZcxkS9CzSjcE0AVfDC9/ftBol2sZGtzzzOynvRZn6hcsb4J2M8Hlc0laOhlK\n\t5g3Q==","X-Gm-Message-State":"AHPjjUi/j46C9EdM9JnP0NikLt4N7tm9wgFHjQnd4e8S5CG4pNQsyv9U\tks4MQv3qy4AEb0wVw5Tscj4Yft5eZQKrLt3ArEm8AA==","X-Google-Smtp-Source":"AOwi7QDNX99ya07mrpkZPhAMVqEpg2OLfQeiLNMKeHKeGelpNB2GuxkWHgwOl5IeSKDB78zEByvlZwpNys5wSKK0uBk=","X-Received":"by 10.37.187.70 with SMTP id b6mr24056232ybk.170.1505582510991;\n\tSat, 16 Sep 2017 10:21:50 -0700 (PDT)","MIME-Version":"1.0","From":"Janus Weil ","Date":"Sat, 16 Sep 2017 19:21:50 +0200","Message-ID":"","Subject":"[Patch, Fortran] PR 82018: -Wextra should imply -Wconversion-extra","To":"gfortran , gcc-patches ,\n\tThomas Koenig ","Content-Type":"multipart/mixed; boundary=\"f403043d9dbcc080aa055951bee3\""},"content":"Hi all,\n\nhere is a small patch that enables -Wconversion-extra with -Wextra and\nupdates the documentation.\n\nUp to gfortran 5, the warning in the test case was enabled by\n-Wconversion, and thus with -Wall. That was changed by Thomas in\nr224190, which makes complete sense to me.\n\nHowever, I think -Wconversion-extra should be implied by -Wextra (I'm\nsure not everyone wants to see such messages, but I think they're\nstill useful).\n\nThe patch regtests cleanly on x86_64-linux-gnu. Ok for trunk?\n\nAs a sidenote, I made an observation that is not directly related to\nthe patch: The second warning in the test case, on \"i4 = i8\" shows\n[-Wconversion] when compiled with -Wall, but [-Wconversion-extra] when\ncompiled with -Wextra. Does anyone understand how that inconsistency\ncomes about?\n\nCheers,\nJanus\n\n\n\n2017-09-16 Janus Weil \n\n PR fortran/82018\n * lang.opt: Turn on -Wconversion-extra with -Wextra.\n * invoke.texi: Update documentation of -Wconversion-extra and -Wextra\n and mention both in the list of Error and Warning Options.\n\n2017-09-16 Janus Weil \n\n PR fortran/82018\n * gfortran.dg/wextra_2.f90: New test case.","diff":"Index: gcc/fortran/invoke.texi\n===================================================================\n--- gcc/fortran/invoke.texi\t(revision 252872)\n+++ gcc/fortran/invoke.texi\t(working copy)\n@@ -144,10 +144,10 @@ by type. Explanations are in the following sectio\n @item Error and Warning Options\n @xref{Error and Warning Options,,Options to request or suppress errors\n and warnings}.\n-@gccoptlist{-Waliasing -Wall -Wampersand -Wargument-mismatch -Warray-bounds\n--Wc-binding-type -Wcharacter-truncation @gol\n--Wconversion -Wfunction-elimination -Wimplicit-interface @gol\n--Wimplicit-procedure -Wintrinsic-shadow -Wuse-without-only -Wintrinsics-std @gol\n+@gccoptlist{-Waliasing -Wall -Wampersand -Wargument-mismatch -Warray-bounds @gol\n+-Wc-binding-type -Wcharacter-truncation -Wconversion -Wconversion-extra @gol\n+-Wextra -Wfunction-elimination -Wimplicit-interface -Wimplicit-procedure @gol\n+-Wintrinsic-shadow -Wuse-without-only -Wintrinsics-std @gol\n -Wline-truncation -Wno-align-commons -Wno-tabs -Wreal-q-constant @gol\n -Wsurprising -Wunderflow -Wunused-parameter -Wrealloc-lhs -Wrealloc-lhs-all @gol\n -Wtarget-lifetime -fmax-errors=@var{n} -fsyntax-only -pedantic -pedantic-errors\n@@ -884,7 +884,7 @@ the expression after conversion. Implied by @optio\n @cindex warnings, conversion\n @cindex conversion\n Warn about implicit conversions between different types and kinds. This\n-option does @emph{not} imply @option{-Wconversion}.\n+option does @emph{not} imply @option{-Wconversion}. Implied by @option{-Wextra}.\n \n @item -Wextra\n @opindex @code{Wextra}\n@@ -891,8 +891,8 @@ Warn about implicit conversions between different\n @cindex extra warnings\n @cindex warnings, extra\n Enables some warning options for usages of language features which\n-may be problematic. This currently includes @option{-Wcompare-reals}\n-and @option{-Wunused-parameter}.\n+may be problematic. This currently includes @option{-Wcompare-reals},\n+@option{-Wunused-parameter} and @option{-Wconversion-extra}.\n \n @item -Wimplicit-interface\n @opindex @code{Wimplicit-interface}\nIndex: gcc/fortran/lang.opt\n===================================================================\n--- gcc/fortran/lang.opt\t(revision 252872)\n+++ gcc/fortran/lang.opt\t(working copy)\n@@ -234,7 +234,7 @@ Fortran Var(warn_conversion) Warning LangEnabledBy\n ; Documented in C\n \n Wconversion-extra\n-Fortran Var(warn_conversion_extra) Warning\n+Fortran Var(warn_conversion_extra) Warning LangEnabledBy(Fortran,Wextra)\n Warn about most implicit conversions.\n \n Wextra\n","prefixes":["Fortran"]}