{"id":814529,"url":"http://patchwork.ozlabs.org/api/patches/814529/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505580378-9044-7-git-send-email-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505580378-9044-7-git-send-email-peter.maydell@linaro.org>","list_archive_url":null,"date":"2017-09-16T16:46:18","name":"[6/6] hw/arm/omap2.c: Don't use old_mmio","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d1507fbe3cb66713509ce63c249d0627e14b1e18","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505580378-9044-7-git-send-email-peter.maydell@linaro.org/mbox/","series":[{"id":3457,"url":"http://patchwork.ozlabs.org/api/series/3457/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3457","date":"2017-09-16T16:46:12","name":"convert some omap/palm devices from using old_mmio","version":1,"mbox":"http://patchwork.ozlabs.org/series/3457/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814529/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814529/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvdXZ2z5bz9sPk\n\tfor ;\n\tSun, 17 Sep 2017 02:49:34 +1000 (AEST)","from localhost ([::1]:57984 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtGHc-0002D9-Hh\n\tfor incoming@patchwork.ozlabs.org; Sat, 16 Sep 2017 12:49:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52548)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtGEC-0008Dn-MR\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 12:46:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtGEB-00078i-Vy\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 12:46:00 -0400","from orth.archaic.org.uk ([2001:8b0:1d0::2]:37412)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtGE9-00075o-O6; Sat, 16 Sep 2017 12:45:57 -0400","from pm215 by orth.archaic.org.uk with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dtGE2-00017U-Ru; Sat, 16 Sep 2017 17:45:50 +0100"],"From":"Peter Maydell ","To":"qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","Date":"Sat, 16 Sep 2017 17:46:18 +0100","Message-Id":"<1505580378-9044-7-git-send-email-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1505580378-9044-1-git-send-email-peter.maydell@linaro.org>","References":"<1505580378-9044-1-git-send-email-peter.maydell@linaro.org>","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:8b0:1d0::2","Subject":"[Qemu-devel] [PATCH 6/6] hw/arm/omap2.c: Don't use old_mmio","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Don't use old_mmio in the memory region ops struct.\n\nSigned-off-by: Peter Maydell \n---\n hw/arm/omap2.c | 49 +++++++++++++++++++++++++++++++++++++------------\n 1 file changed, 37 insertions(+), 12 deletions(-)","diff":"diff --git a/hw/arm/omap2.c b/hw/arm/omap2.c\nindex ece25ae..f35d265 100644\n--- a/hw/arm/omap2.c\n+++ b/hw/arm/omap2.c\n@@ -2087,19 +2087,44 @@ static void omap_sysctl_write(void *opaque, hwaddr addr,\n }\n }\n \n+static uint64_t omap_sysctl_readfn(void *opaque, hwaddr addr,\n+ unsigned size)\n+{\n+ switch (size) {\n+ case 1:\n+ return omap_sysctl_read8(opaque, addr);\n+ case 2:\n+ return omap_badwidth_read32(opaque, addr); /* TODO */\n+ case 4:\n+ return omap_sysctl_read(opaque, addr);\n+ default:\n+ g_assert_not_reached();\n+ }\n+}\n+\n+static void omap_sysctl_writefn(void *opaque, hwaddr addr,\n+ uint64_t value, unsigned size)\n+{\n+ switch (size) {\n+ case 1:\n+ omap_sysctl_write8(opaque, addr, value);\n+ break;\n+ case 2:\n+ omap_badwidth_write32(opaque, addr, value); /* TODO */\n+ break;\n+ case 4:\n+ omap_sysctl_write(opaque, addr, value);\n+ break;\n+ default:\n+ g_assert_not_reached();\n+ }\n+}\n+\n static const MemoryRegionOps omap_sysctl_ops = {\n- .old_mmio = {\n- .read = {\n- omap_sysctl_read8,\n- omap_badwidth_read32,\t/* TODO */\n- omap_sysctl_read,\n- },\n- .write = {\n- omap_sysctl_write8,\n- omap_badwidth_write32,\t/* TODO */\n- omap_sysctl_write,\n- },\n- },\n+ .read = omap_sysctl_readfn,\n+ .write = omap_sysctl_writefn,\n+ .valid.min_access_size = 1,\n+ .valid.max_access_size = 4,\n .endianness = DEVICE_NATIVE_ENDIAN,\n };\n \n","prefixes":["6/6"]}