{"id":814491,"url":"http://patchwork.ozlabs.org/api/patches/814491/?format=json","web_url":"http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20170916104220.3742-7-fancer.lancer@gmail.com/","project":{"id":37,"url":"http://patchwork.ozlabs.org/api/projects/37/?format=json","name":"Devicetree Bindings","link_name":"devicetree-bindings","list_id":"devicetree.vger.kernel.org","list_email":"devicetree@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170916104220.3742-7-fancer.lancer@gmail.com>","list_archive_url":null,"date":"2017-09-16T10:42:17","name":"[6/9,v2] usb: usb251xb: Add USB2517 LED settings","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"a2793deb2d12a65ff4d09357408adbbcb17c0967","submitter":{"id":70038,"url":"http://patchwork.ozlabs.org/api/people/70038/?format=json","name":"Serge Semin","email":"fancer.lancer@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20170916104220.3742-7-fancer.lancer@gmail.com/mbox/","series":[{"id":3430,"url":"http://patchwork.ozlabs.org/api/series/3430/?format=json","web_url":"http://patchwork.ozlabs.org/project/devicetree-bindings/list/?series=3430","date":"2017-09-16T10:42:11","name":"usb: usb251xb: Add USB2517i hub support and fix some bugs","version":2,"mbox":"http://patchwork.ozlabs.org/series/3430/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814491/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814491/checks/","tags":{},"related":[],"headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CHIYnQHX\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvTPf0w3xz9t32\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tSat, 16 Sep 2017 20:43:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751457AbdIPKmj (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tSat, 16 Sep 2017 06:42:39 -0400","from mail-lf0-f67.google.com ([209.85.215.67]:37501 \"EHLO\n\tmail-lf0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751317AbdIPKma (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Sat, 16 Sep 2017 06:42:30 -0400","by mail-lf0-f67.google.com with SMTP id q132so2324360lfe.4;\n\tSat, 16 Sep 2017 03:42:29 -0700 (PDT)","from linux.local ([95.79.181.62]) by smtp.gmail.com with ESMTPSA id\n\tf199sm553379lfg.85.2017.09.16.03.42.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 16 Sep 2017 03:42:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=bji8KRHf2ME5DEMgJMvcJgQ0iyFB4jhc5M5g8sUagtA=;\n\tb=CHIYnQHXgxHIASomD8TG0l1HgmIZhP4dKyGUyxEkFrCXo2P5lkpb1QKc8fEVZMIcl4\n\taAwMp2dTThzwEF3DpoChofsG1Fqw/olOzZVTP/3T53gRrWKVRcthWd6/YWvbxEcuyW6q\n\tJiWaGBWqn3FPxuHePM/VPUD3oNupGzDEotiyUz66QsMEx02taze5mBUYQdC4r+gfhRwD\n\tePWpyzI6OTVS1g9qXa82GetiBk4BXgMEzGwC8R/W8BSxiHJSCz1lwz0D5YbZ++4XVZml\n\tFyZd+lrl6Rd944rAD0M/xOW3YfxxRka3qfz0zv7KjfvqQIpq0Pe3/p/JtRZqoEC0RHOj\n\td52w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=bji8KRHf2ME5DEMgJMvcJgQ0iyFB4jhc5M5g8sUagtA=;\n\tb=VCtTc8ovJRW5XEzIPF7qHNgkCKrMiifFZSCIkMPavxhT44iYGhlv48cPkj9FXCLP7g\n\twTLTg4qogGf5sJVw53jl+mvKPy4vov6jCK7xzpqdJSHH4tiQ1QXwXrVvHyIpMoyQYDiG\n\tewrcxovPbWlSzh7WSj9HAAx6px4WsD6rpBgJE43mgYeNbkb4TVkyl6aEAEcJ2da7AARc\n\tjNS5xjZRI7QesxDV7IR9FWArkjZQtoAi8L9og+bhzcJD7kXAlsTEpTDU0EQ+BK+YtuLV\n\tx1rHQ5jBibKMKJokNplBQtTTz9OerwB29sK9KGM8ocq58USFwhQQjNfU7un9uckMNaKv\n\t4THQ==","X-Gm-Message-State":"AHPjjUgoqOo2U75+G/QNDDz9xi2X1ZdKWCATDcE0tsS9yiRlU75gjUqK\n\tRhLkVwF3cphHww==","X-Google-Smtp-Source":"AOwi7QCY2k7nSgeEwn4Q++neSAScANlm00BPkyBe1PfDDmEpp/TazKxwnYN9QSgLyJkM5LLuXZa6wA==","X-Received":"by 10.46.66.197 with SMTP id h66mr2387113ljf.108.1505558548530; \n\tSat, 16 Sep 2017 03:42:28 -0700 (PDT)","From":"Serge Semin <fancer.lancer@gmail.com>","To":"richard.leitner@skidata.com, gregkh@linuxfoundation.org,\n\trobh+dt@kernel.org, mark.rutland@arm.com","Cc":"Sergey.Semin@t-platforms.ru, linux-usb@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tSerge Semin <fancer.lancer@gmail.com>","Subject":"[PATCH 6/9 v2] usb: usb251xb: Add USB2517 LED settings","Date":"Sat, 16 Sep 2017 13:42:17 +0300","Message-Id":"<20170916104220.3742-7-fancer.lancer@gmail.com>","X-Mailer":"git-send-email 2.12.0","In-Reply-To":"<20170916104220.3742-1-fancer.lancer@gmail.com>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-1-fancer.lancer@gmail.com>","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"},"content":"USB2517 supports two LED modes: USB mode (default) and speed indication\nmode. The last one can be switched on by corresponding dts property.\nSince USB251xb hubs doesn't support LEDs settings, we need to ignore\nthis setting.\n\nSigned-off-by: Serge Semin <fancer.lancer@gmail.com>\n---\n Documentation/devicetree/bindings/usb/usb251xb.txt         |  1 +\n drivers/usb/misc/usb251xb.c                                | 14 +++++++++++++-\n 2 files changed, 14 insertions(+), 1 deletion(-)","diff":"diff --git a/Documentation/devicetree/bindings/usb/usb251xb.txt b/Documentation/devicetree/bindings/usb/usb251xb.txt\nindex 1682d4087..3d84626d3 100644\n--- a/Documentation/devicetree/bindings/usb/usb251xb.txt\n+++ b/Documentation/devicetree/bindings/usb/usb251xb.txt\n@@ -37,6 +37,7 @@ Optional properties :\n \tan invalid value is given, the default is used instead.\n  - compound-device : indicate the hub is part of a compound device\n  - port-mapping-mode : enable port mapping mode\n+ - speed-led-mode : led speed indiation mode selection (usb2517 only)\n  - string-support : enable string descriptor support (required for manufacturer,\n \tproduct and serial string configuration)\n  - non-removable-ports : Should specify the ports which have a non-removable\ndiff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c\nindex 0834729d1..51cc53ddc 100644\n--- a/drivers/usb/misc/usb251xb.c\n+++ b/drivers/usb/misc/usb251xb.c\n@@ -49,7 +49,7 @@\n #define USB251XB_ADDR_CONFIG_DATA_2\t0x07\n #define USB251XB_DEF_CONFIG_DATA_2\t0x20\n #define USB251XB_ADDR_CONFIG_DATA_3\t0x08\n-#define USB251XB_DEF_CONFIG_DATA_3\t0x02\n+#define USB251XB_DEF_CONFIG_DATA_3\t0x00\n \n #define USB251XB_ADDR_NON_REMOVABLE_DEVICES\t0x09\n #define USB251XB_DEF_NON_REMOVABLE_DEVICES\t0x00\n@@ -164,6 +164,7 @@ struct usb251xb {\n struct usb251xb_data {\n \tu16 product_id;\n \tu8 port_cnt;\n+\tbool led_support;\n \tbool bat_support;\n \tchar product_str[USB251XB_STRING_BUFSIZE / 2]; /* ASCII string */\n };\n@@ -171,6 +172,7 @@ struct usb251xb_data {\n static const struct usb251xb_data usb2512b_data = {\n \t.product_id = 0x2512,\n \t.port_cnt = 2,\n+\t.led_support = false,\n \t.bat_support = true,\n \t.product_str = \"USB2512B\",\n };\n@@ -178,6 +180,7 @@ static const struct usb251xb_data usb2512b_data = {\n static const struct usb251xb_data usb2512bi_data = {\n \t.product_id = 0x2512,\n \t.port_cnt = 2,\n+\t.led_support = false,\n \t.bat_support = true,\n \t.product_str = \"USB2512Bi\",\n };\n@@ -185,6 +188,7 @@ static const struct usb251xb_data usb2512bi_data = {\n static const struct usb251xb_data usb2513b_data = {\n \t.product_id = 0x2513,\n \t.port_cnt = 3,\n+\t.led_support = false,\n \t.bat_support = true,\n \t.product_str = \"USB2513B\",\n };\n@@ -192,6 +196,7 @@ static const struct usb251xb_data usb2513b_data = {\n static const struct usb251xb_data usb2513bi_data = {\n \t.product_id = 0x2513,\n \t.port_cnt = 3,\n+\t.led_support = false,\n \t.bat_support = true,\n \t.product_str = \"USB2513Bi\",\n };\n@@ -199,6 +204,7 @@ static const struct usb251xb_data usb2513bi_data = {\n static const struct usb251xb_data usb2514b_data = {\n \t.product_id = 0x2514,\n \t.port_cnt = 4,\n+\t.led_support = false,\n \t.bat_support = true,\n \t.product_str = \"USB2514B\",\n };\n@@ -206,6 +212,7 @@ static const struct usb251xb_data usb2514b_data = {\n static const struct usb251xb_data usb2514bi_data = {\n \t.product_id = 0x2514,\n \t.port_cnt = 4,\n+\t.led_support = false,\n \t.bat_support = true,\n \t.product_str = \"USB2514Bi\",\n };\n@@ -213,6 +220,7 @@ static const struct usb251xb_data usb2514bi_data = {\n static const struct usb251xb_data usb2517_data = {\n \t.product_id = 0x2517,\n \t.port_cnt = 7,\n+\t.led_support = true,\n \t.bat_support = false,\n \t.product_str = \"USB2517\",\n };\n@@ -220,6 +228,7 @@ static const struct usb251xb_data usb2517_data = {\n static const struct usb251xb_data usb2517i_data = {\n \t.product_id = 0x2517,\n \t.port_cnt = 7,\n+\t.led_support = true,\n \t.bat_support = false,\n \t.product_str = \"USB2517i\",\n };\n@@ -443,6 +452,9 @@ static int usb251xb_get_ofdata(struct usb251xb *hub,\n \tif (of_get_property(np, \"port-mapping-mode\", NULL))\n \t\thub->conf_data3 |= BIT(3);\n \n+\tif (data->led_support && of_get_property(np, \"speed-led-mode\", NULL))\n+\t\thub->conf_data3 |= BIT(1);\n+\n \tif (of_get_property(np, \"string-support\", NULL))\n \t\thub->conf_data3 |= BIT(0);\n \n","prefixes":["6/9","v2"]}