{"id":814486,"url":"http://patchwork.ozlabs.org/api/patches/814486/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/1505556666-3043-2-git-send-email-siddhesh@sourceware.org/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505556666-3043-2-git-send-email-siddhesh@sourceware.org>","list_archive_url":null,"date":"2017-09-16T10:11:05","name":"[COMMITTED,2/3] benchtests: Make compare_strings.py output a bit prettier","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fade3f026e9997dc42050cfeeb799d7be23f5713","submitter":{"id":69197,"url":"http://patchwork.ozlabs.org/api/people/69197/?format=json","name":"Siddhesh Poyarekar","email":"siddhesh@sourceware.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/1505556666-3043-2-git-send-email-siddhesh@sourceware.org/mbox/","series":[{"id":3428,"url":"http://patchwork.ozlabs.org/api/series/3428/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=3428","date":"2017-09-16T10:11:04","name":"[COMMITTED,1/3] benchtests: Use argparse to parse arguments","version":1,"mbox":"http://patchwork.ozlabs.org/series/3428/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814486/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814486/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84663-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"uPhS1lHk\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvSjK2QYXz9t2l\n\tfor ;\n\tSat, 16 Sep 2017 20:11:33 +1000 (AEST)","(qmail 13993 invoked by alias); 16 Sep 2017 10:11:22 -0000","(qmail 13919 invoked by uid 89); 16 Sep 2017 10:11:21 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=X5T3AIzZRGhOdqBIe4FPbtDJXycyRAF\n\t5Sevw9lIn21XxcjSCZ1vwbzzgdTsan/qTNYUs6G7QicSKW30NOYLhq6uHV1cUYq5\n\tUAhVuF1kjqGFLyxE05Y0zS9Rj8uBH/C1tE/MjoC72QzEYiQuCsLK4e/i7X6NbwWL\n\tLxgj87c2jEsI=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=t+BGvTON7AJcWb2OYURYEgRyjE0=; b=uPhS1\n\tlHkIF/po1OsFeHpuR7j0f9c/NlZLePY+liqKV24Z41Mq/jgDWUCRzzEDBDl0WTpz\n\tUq41h/dTnBUfGOPZCV4rz2L+xF35KL3WUxZiHg6SXOyyH3Jrd0zvglJi2XYe2Auw\n\t+Yo8tXID/n6g2D84fApFsrHVvj80i0xtjufkS0=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.6 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM,\n\tSPF_NEUTRAL autolearn=ham version=3.3.2\n\tspammy=Hx-languages-length:2273","X-HELO":"homiemail-a114.g.dreamhost.com","From":"Siddhesh Poyarekar ","To":"libc-alpha@sourceware.org","Subject":"[COMMITTED 2/3] benchtests: Make compare_strings.py output a bit\n\tprettier","Date":"Sat, 16 Sep 2017 15:41:05 +0530","Message-Id":"<1505556666-3043-2-git-send-email-siddhesh@sourceware.org>","In-Reply-To":"<1505556666-3043-1-git-send-email-siddhesh@sourceware.org>","References":"<1505556666-3043-1-git-send-email-siddhesh@sourceware.org>"},"content":"Make the column widths for the outputs fixed so that they look a\nlittle less messy. They will still look bad with lots of IFUNCs (like\non x86) but it's still a step forward.\n\n\t* benchtests/scripts/compare_strings.py (process_results):\n\tBetter spacing for output.\n---\n ChangeLog | 3 +++\n benchtests/scripts/compare_strings.py | 20 +++++++++++---------\n 2 files changed, 14 insertions(+), 9 deletions(-)","diff":"diff --git a/ChangeLog b/ChangeLog\nindex fd9cc0c..20746e6 100644\n--- a/ChangeLog\n+++ b/ChangeLog\n@@ -1,5 +1,8 @@\n 2017-09-16 Siddhesh Poyarekar \n \n+\t* benchtests/scripts/compare_strings.py (process_results):\n+\tBetter spacing for output.\n+\n \t* benchtests/scripts/compare_strings.py: Use argparse.\n \t* benchtests/README: Document existence of compare_strings.py.\n \ndiff --git a/benchtests/scripts/compare_strings.py b/benchtests/scripts/compare_strings.py\nindex 3ca9429..1f0be3b 100755\n--- a/benchtests/scripts/compare_strings.py\n+++ b/benchtests/scripts/compare_strings.py\n@@ -88,26 +88,28 @@ def process_results(results, attrs, base_func):\n \n for f in results['functions'].keys():\n print('Function: %s' % f)\n+ v = results['functions'][f]['bench-variant']\n+ print('Variant: %s' % v)\n+\n base_index = 0\n if base_func:\n base_index = results['functions'][f]['ifuncs'].index(base_func)\n \n- print('\\t'.join(results['functions'][f]['ifuncs']))\n- v = results['functions'][f]['bench-variant']\n- print('Variant: %s' % v)\n- print(\"=\" * 80)\n+ print(\"%36s%s\" % (' ', '\\t'.join(results['functions'][f]['ifuncs'])))\n+ print(\"=\" * 120)\n graph_res = {}\n for res in results['functions'][f]['results']:\n attr_list = ['%s=%s' % (a, res[a]) for a in attrs]\n i = 0\n- key = ','.join(attr_list)\n- sys.stdout.write('%s: \\t' % key)\n+ key = ', '.join(attr_list)\n+ sys.stdout.write('%36s: ' % key)\n graph_res[key] = res['timings']\n for t in res['timings']:\n- sys.stdout.write ('%.2f' % t)\n+ sys.stdout.write ('%12.2f' % t)\n if i != base_index:\n- diff = (res['timings'][base_index] - t) * 100 / res['timings'][base_index]\n- sys.stdout.write (' (%.2f%%)' % diff)\n+ base = res['timings'][base_index]\n+ diff = (base - t) * 100 / base\n+ sys.stdout.write (' (%6.2f%%)' % diff)\n sys.stdout.write('\\t')\n i = i + 1\n print('')\n","prefixes":["COMMITTED","2/3"]}