{"id":814438,"url":"http://patchwork.ozlabs.org/api/patches/814438/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-14-ehabkost@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170915233739.26860-14-ehabkost@redhat.com>","list_archive_url":null,"date":"2017-09-15T23:37:37","name":"[PULL,13/15] qemu.py: use os.path.null instead of /dev/null","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d61dedde7c62c36ef4385a13cbeb879ddbd46df5","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/?format=json","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-14-ehabkost@redhat.com/mbox/","series":[{"id":3400,"url":"http://patchwork.ozlabs.org/api/series/3400/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3400","date":"2017-09-15T23:37:24","name":"[PULL,01/15] qemu.py: Pylint/style fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/3400/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814438/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814438/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvBtz3KHRz9sMN\n\tfor ;\n\tSat, 16 Sep 2017 09:48:59 +1000 (AEST)","from localhost ([::1]:55397 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dt0Lx-0005SS-LM\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 19:48:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56683)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dt0CD-0005lN-6l\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:54 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dt0CC-0003Cq-5Z\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:53 -0400","from mx1.redhat.com ([209.132.183.28]:53588)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dt0CC-00039e-0A\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:52 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0DF1C356E3;\n\tFri, 15 Sep 2017 23:38:51 +0000 (UTC)","from localhost (ovpn-116-24.gru2.redhat.com [10.97.116.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 128EC5E1CA;\n\tFri, 15 Sep 2017 23:38:45 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0DF1C356E3","From":"Eduardo Habkost ","To":"Peter Maydell ,\n\tqemu-devel@nongnu.org","Date":"Fri, 15 Sep 2017 20:37:37 -0300","Message-Id":"<20170915233739.26860-14-ehabkost@redhat.com>","In-Reply-To":"<20170915233739.26860-1-ehabkost@redhat.com>","References":"<20170915233739.26860-1-ehabkost@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 15 Sep 2017 23:38:51 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 13/15] qemu.py: use os.path.null instead of\n\t/dev/null","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= ,\n\tAmador Pahim , Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Amador Pahim \n\nFor increased portability, let's use os.path.devnull.\n\nSigned-off-by: Amador Pahim \nMessage-Id: <20170901112829.2571-4-apahim@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé \nReviewed-by: Fam Zheng \nSigned-off-by: Eduardo Habkost \n---\n scripts/qemu.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/scripts/qemu.py b/scripts/qemu.py\nindex 8d3d24dd2b..c9bcaafe41 100644\n--- a/scripts/qemu.py\n+++ b/scripts/qemu.py\n@@ -124,7 +124,7 @@ class QEMUMachine(object):\n fd_param = [\"%s\" % self._socket_scm_helper,\n \"%d\" % self._qmp.get_sock_fd(),\n \"%s\" % fd_file_path]\n- devnull = open('/dev/null', 'rb')\n+ devnull = open(os.path.devnull, 'rb')\n proc = subprocess.Popen(fd_param, stdin=devnull, stdout=subprocess.PIPE,\n stderr=subprocess.STDOUT)\n output = proc.communicate()[0]\n@@ -186,7 +186,7 @@ class QEMUMachine(object):\n \n def launch(self):\n '''Launch the VM and establish a QMP connection'''\n- devnull = open('/dev/null', 'rb')\n+ devnull = open(os.path.devnull, 'rb')\n qemulog = open(self._qemu_log_path, 'wb')\n try:\n self._pre_launch()\n","prefixes":["PULL","13/15"]}