{"id":814437,"url":"http://patchwork.ozlabs.org/api/patches/814437/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-9-ehabkost@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170915233739.26860-9-ehabkost@redhat.com>","list_archive_url":null,"date":"2017-09-15T23:37:32","name":"[PULL,08/15] qmp.py: Avoid \"has_key\" usage","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"34eb3fbba47bc4a77fa7da5d6de3b331f9bf3fc3","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/?format=json","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-9-ehabkost@redhat.com/mbox/","series":[{"id":3400,"url":"http://patchwork.ozlabs.org/api/series/3400/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3400","date":"2017-09-15T23:37:24","name":"[PULL,01/15] qemu.py: Pylint/style fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/3400/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814437/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814437/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvBsh0kBMz9sPr\n\tfor ;\n\tSat, 16 Sep 2017 09:47:52 +1000 (AEST)","from localhost ([::1]:55395 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dt0Kr-0004rd-SI\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 19:47:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56444)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dt0Bl-0005N1-9Q\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dt0Bk-0001md-EQ\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:25 -0400","from mx1.redhat.com ([209.132.183.28]:54530)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dt0Bk-0001mM-8D\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:24 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 461DA85540;\n\tFri, 15 Sep 2017 23:38:23 +0000 (UTC)","from localhost (ovpn-116-24.gru2.redhat.com [10.97.116.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 45D4160468;\n\tFri, 15 Sep 2017 23:38:18 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 461DA85540","From":"Eduardo Habkost ","To":"Peter Maydell ,\n\tqemu-devel@nongnu.org","Date":"Fri, 15 Sep 2017 20:37:32 -0300","Message-Id":"<20170915233739.26860-9-ehabkost@redhat.com>","In-Reply-To":"<20170915233739.26860-1-ehabkost@redhat.com>","References":"<20170915233739.26860-1-ehabkost@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tFri, 15 Sep 2017 23:38:23 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 08/15] qmp.py: Avoid \"has_key\" usage","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= ,\n\tAmador Pahim , Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Lukáš Doktor \n\nThe \"has_key\" is deprecated in favor of \"__in__\" operator.\n\nSigned-off-by: Lukáš Doktor \nReviewed-by: Eduardo Habkost \nReviewed-by: Philippe Mathieu-Daudé \nMessage-Id: <20170818142613.32394-9-ldoktor@redhat.com>\nSigned-off-by: Eduardo Habkost \n---\n scripts/qmp/qmp.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py\nindex 95ff5cc39a..f2f5a9b296 100644\n--- a/scripts/qmp/qmp.py\n+++ b/scripts/qmp/qmp.py\n@@ -197,7 +197,7 @@ class QEMUMonitorProtocol(object):\n Build and send a QMP command to the monitor, report errors if any\n \"\"\"\n ret = self.cmd(cmd, kwds)\n- if ret.has_key('error'):\n+ if \"error\" in ret:\n raise Exception(ret['error']['desc'])\n return ret['return']\n \n","prefixes":["PULL","08/15"]}