{"id":814433,"url":"http://patchwork.ozlabs.org/api/patches/814433/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-6-ehabkost@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170915233739.26860-6-ehabkost@redhat.com>","list_archive_url":null,"date":"2017-09-15T23:37:29","name":"[PULL,05/15] qemu.py: Use custom exceptions rather than Exception","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9989fb998cd86b8bac9ab84d55fa2aee64d3b46f","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/?format=json","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-6-ehabkost@redhat.com/mbox/","series":[{"id":3400,"url":"http://patchwork.ozlabs.org/api/series/3400/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3400","date":"2017-09-15T23:37:24","name":"[PULL,01/15] qemu.py: Pylint/style fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/3400/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814433/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814433/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvBp73Dk1z9sPk\n\tfor ;\n\tSat, 16 Sep 2017 09:44:47 +1000 (AEST)","from localhost ([::1]:55376 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dt0Ht-000263-FI\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 19:44:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56312)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dt0BW-0005Bg-Sb\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dt0BV-0001Nd-MB\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:10 -0400","from mx1.redhat.com ([209.132.183.28]:57604)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dt0BV-0001Ms-HC\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:09 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8948D61470;\n\tFri, 15 Sep 2017 23:38:08 +0000 (UTC)","from localhost (ovpn-116-24.gru2.redhat.com [10.97.116.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1A698729C1;\n\tFri, 15 Sep 2017 23:38:07 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8948D61470","From":"Eduardo Habkost ","To":"Peter Maydell ,\n\tqemu-devel@nongnu.org","Date":"Fri, 15 Sep 2017 20:37:29 -0300","Message-Id":"<20170915233739.26860-6-ehabkost@redhat.com>","In-Reply-To":"<20170915233739.26860-1-ehabkost@redhat.com>","References":"<20170915233739.26860-1-ehabkost@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 15 Sep 2017 23:38:08 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 05/15] qemu.py: Use custom exceptions rather\n\tthan Exception","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= ,\n\tAmador Pahim , Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Lukáš Doktor \n\nThe naked Exception should not be widely used. It makes sense to be a\nbit more specific and use better-suited custom exceptions. As a benefit\nwe can store the full reply in the exception in case someone needs it\nwhen catching the exception.\n\nSigned-off-by: Lukáš Doktor \nReviewed-by: Eduardo Habkost \nMessage-Id: <20170818142613.32394-6-ldoktor@redhat.com>\nSigned-off-by: Eduardo Habkost \n---\n scripts/qemu.py | 17 +++++++++++++++--\n 1 file changed, 15 insertions(+), 2 deletions(-)","diff":"diff --git a/scripts/qemu.py b/scripts/qemu.py\nindex bde8da8fe7..7c6802609a 100644\n--- a/scripts/qemu.py\n+++ b/scripts/qemu.py\n@@ -19,6 +19,19 @@ import subprocess\n import qmp.qmp\n \n \n+class MonitorResponseError(qmp.qmp.QMPError):\n+ '''\n+ Represents erroneous QMP monitor reply\n+ '''\n+ def __init__(self, reply):\n+ try:\n+ desc = reply[\"error\"][\"desc\"]\n+ except KeyError:\n+ desc = reply\n+ super(MonitorResponseError, self).__init__(desc)\n+ self.reply = reply\n+\n+\n class QEMUMachine(object):\n '''A QEMU VM\n \n@@ -213,9 +226,9 @@ class QEMUMachine(object):\n '''\n reply = self.qmp(cmd, conv_keys, **args)\n if reply is None:\n- raise Exception(\"Monitor is closed\")\n+ raise qmp.qmp.QMPError(\"Monitor is closed\")\n if \"error\" in reply:\n- raise Exception(reply[\"error\"][\"desc\"])\n+ raise MonitorResponseError(reply)\n return reply[\"return\"]\n \n def get_qmp_event(self, wait=False):\n","prefixes":["PULL","05/15"]}