{"id":814432,"url":"http://patchwork.ozlabs.org/api/patches/814432/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-10-ehabkost@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170915233739.26860-10-ehabkost@redhat.com>","list_archive_url":null,"date":"2017-09-15T23:37:33","name":"[PULL,09/15] qmp.py: Avoid overriding a builtin object","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d74132e70509ce01f35c5987288383b8203ca8ad","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/?format=json","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-10-ehabkost@redhat.com/mbox/","series":[{"id":3400,"url":"http://patchwork.ozlabs.org/api/series/3400/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3400","date":"2017-09-15T23:37:24","name":"[PULL,01/15] qemu.py: Pylint/style fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/3400/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814432/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814432/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvBnQ53Q1z9sPk\n\tfor ;\n\tSat, 16 Sep 2017 09:44:08 +1000 (AEST)","from localhost ([::1]:55375 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dt0HE-0001X6-Rt\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 19:44:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56491)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dt0Br-0005TB-NM\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dt0Bq-0001sE-RM\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:31 -0400","from mx1.redhat.com ([209.132.183.28]:52232)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dt0Bq-0001rz-Kw\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:30 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9E70FC0587ED;\n\tFri, 15 Sep 2017 23:38:29 +0000 (UTC)","from localhost (ovpn-116-24.gru2.redhat.com [10.97.116.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B434B179E4;\n\tFri, 15 Sep 2017 23:38:24 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9E70FC0587ED","From":"Eduardo Habkost ","To":"Peter Maydell ,\n\tqemu-devel@nongnu.org","Date":"Fri, 15 Sep 2017 20:37:33 -0300","Message-Id":"<20170915233739.26860-10-ehabkost@redhat.com>","In-Reply-To":"<20170915233739.26860-1-ehabkost@redhat.com>","References":"<20170915233739.26860-1-ehabkost@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tFri, 15 Sep 2017 23:38:29 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 09/15] qmp.py: Avoid overriding a builtin object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= ,\n\tAmador Pahim , Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Lukáš Doktor \n\nThe \"id\" is a builtin method to get object's identity and should not be\noverridden. This might bring some issues in case someone was directly\ncalling \"cmd(..., id=id)\" but I haven't found such usage on brief search\nfor \"cmd\\(.*id=\".\n\nSigned-off-by: Lukáš Doktor \nReviewed-by: Eduardo Habkost \nMessage-Id: <20170818142613.32394-10-ldoktor@redhat.com>\nSigned-off-by: Eduardo Habkost \n---\n scripts/qmp/qmp.py | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py\nindex f2f5a9b296..ef12e8a1a0 100644\n--- a/scripts/qmp/qmp.py\n+++ b/scripts/qmp/qmp.py\n@@ -177,19 +177,19 @@ class QEMUMonitorProtocol(object):\n print >>sys.stderr, \"QMP:<<< %s\" % resp\n return resp\n \n- def cmd(self, name, args=None, id=None):\n+ def cmd(self, name, args=None, cmd_id=None):\n \"\"\"\n Build a QMP command and send it to the QMP Monitor.\n \n @param name: command name (string)\n @param args: command arguments (dict)\n- @param id: command id (dict, list, string or int)\n+ @param cmd_id: command id (dict, list, string or int)\n \"\"\"\n qmp_cmd = {'execute': name}\n if args:\n qmp_cmd['arguments'] = args\n- if id:\n- qmp_cmd['id'] = id\n+ if cmd_id:\n+ qmp_cmd['id'] = cmd_id\n return self.cmd_obj(qmp_cmd)\n \n def command(self, cmd, **kwds):\n","prefixes":["PULL","09/15"]}