{"id":814428,"url":"http://patchwork.ozlabs.org/api/patches/814428/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-12-ehabkost@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170915233739.26860-12-ehabkost@redhat.com>","list_archive_url":null,"date":"2017-09-15T23:37:35","name":"[PULL,11/15] qemu.py: fix is_running() return before first launch()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e1eb9cbcfa4dcfef39f17ba485995a80a94d5b6b","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/?format=json","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-12-ehabkost@redhat.com/mbox/","series":[{"id":3400,"url":"http://patchwork.ozlabs.org/api/series/3400/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3400","date":"2017-09-15T23:37:24","name":"[PULL,01/15] qemu.py: Pylint/style fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/3400/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814428/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814428/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvBkC3ZX2z9sPk\n\tfor ;\n\tSat, 16 Sep 2017 09:41:23 +1000 (AEST)","from localhost ([::1]:55364 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dt0Eb-0007GE-Hq\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 19:41:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56573)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dt0C0-0005Yj-GZ\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:41 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dt0Bz-0002BS-3v\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:40 -0400","from mx1.redhat.com ([209.132.183.28]:52394)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dt0By-00029r-UI\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:39 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0B213C0587ED;\n\tFri, 15 Sep 2017 23:38:38 +0000 (UTC)","from localhost (ovpn-116-24.gru2.redhat.com [10.97.116.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 95495179FF;\n\tFri, 15 Sep 2017 23:38:37 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0B213C0587ED","From":"Eduardo Habkost ","To":"Peter Maydell ,\n\tqemu-devel@nongnu.org","Date":"Fri, 15 Sep 2017 20:37:35 -0300","Message-Id":"<20170915233739.26860-12-ehabkost@redhat.com>","In-Reply-To":"<20170915233739.26860-1-ehabkost@redhat.com>","References":"<20170915233739.26860-1-ehabkost@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tFri, 15 Sep 2017 23:38:38 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 11/15] qemu.py: fix is_running() return before\n\tfirst launch()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= ,\n\tAmador Pahim , Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Amador Pahim \n\nis_running() returns None when called before the first time we\ncall launch():\n\n >>> import qemu\n >>> vm = qemu.QEMUMachine('qemu-system-x86_64')\n >>> vm.is_running()\n >>>\n\nIt should return False instead. This patch fixes that.\n\nFor consistence, this patch removes the parenthesis from the\nsecond clause as it's not really needed.\n\nSigned-off-by: Amador Pahim \nMessage-Id: <20170901112829.2571-2-apahim@redhat.com>\nReviewed-by: Fam Zheng \nSigned-off-by: Eduardo Habkost \n---\n scripts/qemu.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/scripts/qemu.py b/scripts/qemu.py\nindex 7c6802609a..f80b008f7f 100644\n--- a/scripts/qemu.py\n+++ b/scripts/qemu.py\n@@ -131,7 +131,7 @@ class QEMUMachine(object):\n raise\n \n def is_running(self):\n- return self._popen and (self._popen.returncode is None)\n+ return self._popen is not None and self._popen.returncode is None\n \n def exitcode(self):\n if self._popen is None:\n","prefixes":["PULL","11/15"]}