{"id":814426,"url":"http://patchwork.ozlabs.org/api/patches/814426/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-4-ehabkost@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170915233739.26860-4-ehabkost@redhat.com>","list_archive_url":null,"date":"2017-09-15T23:37:27","name":"[PULL,03/15] qemu.py: Use iteritems rather than keys()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b2701c3ea63899ad1be6164794de41a132a78000","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/?format=json","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-4-ehabkost@redhat.com/mbox/","series":[{"id":3400,"url":"http://patchwork.ozlabs.org/api/series/3400/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3400","date":"2017-09-15T23:37:24","name":"[PULL,01/15] qemu.py: Pylint/style fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/3400/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814426/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814426/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvBgJ5l18z9sPk\n\tfor ;\n\tSat, 16 Sep 2017 09:38:52 +1000 (AEST)","from localhost ([::1]:55352 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dt0CA-000500-PJ\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 19:38:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56198)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dt0BO-0004yd-R7\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dt0BN-0001Dl-TB\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:02 -0400","from mx1.redhat.com ([209.132.183.28]:52992)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dt0BN-0001DX-Ni\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:38:01 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BE3AF356E3;\n\tFri, 15 Sep 2017 23:38:00 +0000 (UTC)","from localhost (ovpn-116-24.gru2.redhat.com [10.97.116.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BFE1D5C552;\n\tFri, 15 Sep 2017 23:37:55 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BE3AF356E3","From":"Eduardo Habkost ","To":"Peter Maydell ,\n\tqemu-devel@nongnu.org","Date":"Fri, 15 Sep 2017 20:37:27 -0300","Message-Id":"<20170915233739.26860-4-ehabkost@redhat.com>","In-Reply-To":"<20170915233739.26860-1-ehabkost@redhat.com>","References":"<20170915233739.26860-1-ehabkost@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 15 Sep 2017 23:38:00 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 03/15] qemu.py: Use iteritems rather than keys()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= ,\n\tAmador Pahim , Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Lukáš Doktor \n\nLet's avoid creating an in-memory list of keys and query for each value\nand use `iteritems` which is an iterator of key-value pairs.\n\nSigned-off-by: Lukáš Doktor \nReviewed-by: Eduardo Habkost \nReviewed-by: Philippe Mathieu-Daudé \nMessage-Id: <20170818142613.32394-4-ldoktor@redhat.com>\nReviewed-by: Cleber Rosa \nSigned-off-by: Eduardo Habkost \n---\n scripts/qemu.py | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/scripts/qemu.py b/scripts/qemu.py\nindex afd98a290e..d8c169b31e 100644\n--- a/scripts/qemu.py\n+++ b/scripts/qemu.py\n@@ -200,11 +200,11 @@ class QEMUMachine(object):\n def qmp(self, cmd, conv_keys=True, **args):\n '''Invoke a QMP command and return the response dict'''\n qmp_args = dict()\n- for key in args.keys():\n+ for key, value in args.iteritems():\n if conv_keys:\n- qmp_args[key.translate(self.underscore_to_dash)] = args[key]\n+ qmp_args[key.translate(self.underscore_to_dash)] = value\n else:\n- qmp_args[key] = args[key]\n+ qmp_args[key] = value\n \n return self._qmp.cmd(cmd, args=qmp_args)\n \n","prefixes":["PULL","03/15"]}