{"id":814389,"url":"http://patchwork.ozlabs.org/api/patches/814389/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1505504680-22167-1-git-send-email-srishtishar@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505504680-22167-1-git-send-email-srishtishar@gmail.com>","list_archive_url":null,"date":"2017-09-15T19:44:40","name":"[v2] Staging: irda: Don't use assignment inside if statement","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"2de44309031ca7c520f9df5761a9265043a16b46","submitter":{"id":72376,"url":"http://patchwork.ozlabs.org/api/people/72376/?format=json","name":"Srishti Sharma","email":"srishtishar@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1505504680-22167-1-git-send-email-srishtishar@gmail.com/mbox/","series":[{"id":3374,"url":"http://patchwork.ozlabs.org/api/series/3374/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3374","date":"2017-09-15T19:44:40","name":"[v2] Staging: irda: Don't use assignment inside if statement","version":2,"mbox":"http://patchwork.ozlabs.org/series/3374/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814389/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814389/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"u687Z++5\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv5TZ1ZSGz9s0Z\n\tfor ;\n\tSat, 16 Sep 2017 05:45:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751930AbdIOTow (ORCPT );\n\tFri, 15 Sep 2017 15:44:52 -0400","from mail-pf0-f195.google.com ([209.85.192.195]:36300 \"EHLO\n\tmail-pf0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751877AbdIOTou (ORCPT\n\t); Fri, 15 Sep 2017 15:44:50 -0400","by mail-pf0-f195.google.com with SMTP id f84so1656086pfj.3;\n\tFri, 15 Sep 2017 12:44:50 -0700 (PDT)","from srishti-PRODiiGY-945G ([122.168.202.126])\n\tby smtp.gmail.com with ESMTPSA id\n\tb8sm3668661pfl.62.2017.09.15.12.44.48\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 15 Sep 2017 12:44:48 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=aPZH2d+s4GEs8lcljLYq8J2cxbU4zDyrQk/1X/0wFBs=;\n\tb=u687Z++5aWnxCxiGRA0AIhBQZ5iG1HRgeNowWFDPqEYdEMSvXCfVpbN71t3eQ2VyLw\n\tTzYzLQY3a7t0n+gH8CPjPBA4dzmbsXdcFGWQJnMpb4tFoPhpSvLgjRlq1QXV1ki9jUGh\n\tXcz+0bn+uAe8GThYAdwdyhLmI1Xg3xgV3rMgZlVxdgJnO9THVYlOmafr5adBalWwRnGr\n\tHZU4oldbOIC4ptiGEMiKsGjhMktXLidpW2mx5LYscFFZ8W7k/5n55M7aJr/8ruZOlFeD\n\tlLtci3oudI/96v4YR0K0ORjMLXILc4ngJmiiCBBMBi2AS3ZSrQup0RXr/X6R+LGvipLE\n\tFjDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=aPZH2d+s4GEs8lcljLYq8J2cxbU4zDyrQk/1X/0wFBs=;\n\tb=ucEKDPEcIZ516j7G20RbeZ8p2QW2frPeRGJ16RwTAz7qBbXmvvxH23jlXXpb3MqAh7\n\tXzGuuwwsh9TBdX0uIG9GSoke4iOWRIJpkAwqa+KmoH9cE08gN8DJ+zcu5sLDrOl/Kwp7\n\tSRq6NL7oI/QIdqU77FSP49QwWoQx+5UcfxusW9dEkMIzHpSldFQr3zVAUvFfSBGdUDNT\n\tbd72qIH4vx3A4FJk71Y9OeN1gpEZCPmb9nXzK8BvBtJ/5WjAeSh++XNt1CYjoDjsUdA9\n\tzn6vDcgSaLOcGxpuUDZCi04tEO+Ow2EZhXZBJI8+LLXAbESG64Nk7YzJPwW1e9BAANJt\n\tIrSg==","X-Gm-Message-State":"AHPjjUjFreC56V2nty0Q/EJqezLnyoVio1WvoaaiL86s5eGS3rpp/sI6\n\t+ueeXhwF7/Usng==","X-Google-Smtp-Source":"ADKCNb6oZ5B4X01MKNwMyICx3OoW4HP97TOrY86IQWYpwo9d0K1AUU3OCoye25OXv6hLghaNOQWZyg==","X-Received":"by 10.98.157.139 with SMTP id a11mr22748297pfk.70.1505504689539; \n\tFri, 15 Sep 2017 12:44:49 -0700 (PDT)","From":"Srishti Sharma ","To":"samuel@sortiz.org","Cc":"gregkh@linuxfoundation.org, netdev@vger.kernel.org,\n\tdevel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,\n\toutreachy-kernel@googlegroups.com, Srishti Sharma ","Subject":"[PATCH v2] Staging: irda: Don't use assignment inside if statement","Date":"Sat, 16 Sep 2017 01:14:40 +0530","Message-Id":"<1505504680-22167-1-git-send-email-srishtishar@gmail.com>","X-Mailer":"git-send-email 2.7.4","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Write assignment statement outside the if statement. Done using\nthe following semantic patch by coccinelle.\n\n@@\nidentifier E;\nexpression F;\nstatement S;\n@@\n\n-if((E = F))\n+E = F;\n+if(E)\n S\n\nSigned-off-by: Srishti Sharma \n---\nChanges in v2:\n -Semicolon was missing in one of the statements of the \n semantic patch\n \n drivers/staging/irda/drivers/irda-usb.c | 4 ++--\n drivers/staging/irda/drivers/mcs7780.c | 9 ++++++---\n drivers/staging/irda/net/irqueue.c | 3 ++-\n 3 files changed, 10 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/staging/irda/drivers/irda-usb.c b/drivers/staging/irda/drivers/irda-usb.c\nindex 723e49b..82bfc05 100644\n--- a/drivers/staging/irda/drivers/irda-usb.c\n+++ b/drivers/staging/irda/drivers/irda-usb.c\n@@ -334,9 +334,9 @@ static void irda_usb_change_speed_xbofs(struct irda_usb_cb *self)\n \turb->transfer_flags = 0;\n \n \t/* Irq disabled -> GFP_ATOMIC */\n-\tif ((ret = usb_submit_urb(urb, GFP_ATOMIC))) {\n+\tret = usb_submit_urb(urb, GFP_ATOMIC);\n+\tif (ret)\n \t\tnet_warn_ratelimited(\"%s(), failed Speed URB\\n\", __func__);\n-\t}\n }\n \n /*------------------------------------------------------------------*/\ndiff --git a/drivers/staging/irda/drivers/mcs7780.c b/drivers/staging/irda/drivers/mcs7780.c\nindex c3f0b25..2b674d5 100644\n--- a/drivers/staging/irda/drivers/mcs7780.c\n+++ b/drivers/staging/irda/drivers/mcs7780.c\n@@ -605,19 +605,22 @@ static int mcs_speed_change(struct mcs_cb *mcs)\n \tif (mcs->new_speed <= 115200) {\n \t\trval &= ~MCS_FIR;\n \n-\t\tif ((rst = (mcs->speed > 115200)))\n+\t\trst = (mcs->speed > 115200);\n+\t\tif (rst)\n \t\t\tmcs_set_reg(mcs, MCS_MINRXPW_REG, 0);\n \n \t} else if (mcs->new_speed <= 1152000) {\n \t\trval &= ~MCS_FIR;\n \n-\t\tif ((rst = !(mcs->speed == 576000 || mcs->speed == 1152000)))\n+\t\trst = !(mcs->speed == 576000 || mcs->speed == 1152000);\n+\t\tif (rst)\n \t\t\tmcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n \n \t} else {\n \t\trval |= MCS_FIR;\n \n-\t\tif ((rst = (mcs->speed != 4000000)))\n+\t\trst = (mcs->speed != 4000000);\n+\t\tif (rst)\n \t\t\tmcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n \n \t}\ndiff --git a/drivers/staging/irda/net/irqueue.c b/drivers/staging/irda/net/irqueue.c\nindex 160dc89..5aab072 100644\n--- a/drivers/staging/irda/net/irqueue.c\n+++ b/drivers/staging/irda/net/irqueue.c\n@@ -217,7 +217,8 @@ static __u32 hash( const char* name)\n \n \twhile(*name) {\n \t\th = (h<<4) + *name++;\n-\t\tif ((g = (h & 0xf0000000)))\n+\t\tg = (h & 0xf0000000);\n+\t\tif (g)\n \t\t\th ^=g>>24;\n \t\th &=~g;\n \t}\n","prefixes":["v2"]}