{"id":814338,"url":"http://patchwork.ozlabs.org/api/patches/814338/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/28da60231eb848981e858fa33e3b7e33f8547111.1505494668.git.msuchanek@suse.de/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<28da60231eb848981e858fa33e3b7e33f8547111.1505494668.git.msuchanek@suse.de>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/28da60231eb848981e858fa33e3b7e33f8547111.1505494668.git.msuchanek@suse.de/","date":"2017-09-15T17:02:46","name":"[1/6] lib/cmdline.c: Add backslash support to kernel commandline parsing.","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"396a491e452f43e72c69606e1290458b05b45c3d","submitter":{"id":70348,"url":"http://patchwork.ozlabs.org/api/people/70348/?format=json","name":"Michal Suchánek","email":"msuchanek@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/28da60231eb848981e858fa33e3b7e33f8547111.1505494668.git.msuchanek@suse.de/mbox/","series":[{"id":3338,"url":"http://patchwork.ozlabs.org/api/series/3338/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=3338","date":"2017-09-15T17:02:47","name":"[1/6] lib/cmdline.c: Add backslash support to kernel commandline parsing.","version":1,"mbox":"http://patchwork.ozlabs.org/series/3338/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814338/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814338/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xv1yD33zvz9s7m\n\tfor ;\n\tSat, 16 Sep 2017 03:06:12 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xv1yD1yX9zDrpB\n\tfor ;\n\tSat, 16 Sep 2017 03:06:12 +1000 (AEST)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\t(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xv1td5KF9zDrYl\n\tfor ;\n\tSat, 16 Sep 2017 03:02:58 +1000 (AEST)","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id C69785CB15;\n\tFri, 15 Sep 2017 17:02:55 +0000 (UTC)"],"Authentication-Results":"ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=suse.de\n\t(client-ip=195.135.220.15; helo=mx1.suse.de;\n\tenvelope-from=msuchanek@suse.de; receiver=)","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","From":"Michal Suchanek ","To":"Jonathan Corbet ,\n\tBenjamin Herrenschmidt ,\n\tPaul Mackerras ,\n\tMichael Ellerman , \n\tMauro Carvalho Chehab ,\n\tJani Nikula ,\n\tMichal Suchanek , \n\tKamlakant Patel ,\n\tBamvor Jian Zhang ,\n\tTamara Diaconita ,\n\tTrond Myklebust ,\n\tHari Bathini ,\n\tMahesh Salgaonkar ,\n\tAndrew Morton ,\n\tNicholas Piggin , Baoquan He ,\n\tIlya Matveychikov ,\n\tIngo Molnar , \n\tlinux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org","Subject":"[PATCH 1/6] lib/cmdline.c: Add backslash support to kernel\n\tcommandline parsing.","Date":"Fri, 15 Sep 2017 19:02:46 +0200","Message-Id":"<28da60231eb848981e858fa33e3b7e33f8547111.1505494668.git.msuchanek@suse.de>","X-Mailer":"git-send-email 2.10.2","In-Reply-To":"<4fabdf584ad18d6aae61e331f783a5020567f634.1505231820.git.msuchanek@suse.de>","References":"<4fabdf584ad18d6aae61e331f783a5020567f634.1505231820.git.msuchanek@suse.de>","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"This allows passing quotes in kernel arguments. It is useful for passing\nfadump nested arguemnts in fadump_extra_args and might be useful if\nsomebody wanted to pass a double quote directly as part of an argument.\n\nIt is also useful to have quoting grammar more similar to shells and\nbootloaders.\n\nSigned-off-by: Michal Suchanek \n---\n lib/cmdline.c | 41 ++++++++++++++++++++---------------------\n 1 file changed, 20 insertions(+), 21 deletions(-)","diff":"diff --git a/lib/cmdline.c b/lib/cmdline.c\nindex 6d398a8b63fc..d98bdc017545 100644\n--- a/lib/cmdline.c\n+++ b/lib/cmdline.c\n@@ -193,30 +193,36 @@ bool parse_option_str(const char *str, const char *option)\n \n /*\n * Parse a string to get a param value pair.\n- * You can use \" around spaces, but can't escape \".\n+ * You can use \" around spaces, and you can escape with \\\n * Hyphens and underscores equivalent in parameter names.\n */\n char *next_arg(char *args, char **param, char **val)\n {\n \tunsigned int i, equals = 0;\n-\tint in_quote = 0, quoted = 0;\n+\tint in_quote = 0, backslash = 0;\n \tchar *next;\n \n-\tif (*args == '\"') {\n-\t\targs++;\n-\t\tin_quote = 1;\n-\t\tquoted = 1;\n-\t}\n-\n \tfor (i = 0; args[i]; i++) {\n-\t\tif (isspace(args[i]) && !in_quote)\n+\t\tif (isspace(args[i]) && !in_quote && !backslash)\n \t\t\tbreak;\n-\t\tif (equals == 0) {\n-\t\t\tif (args[i] == '=')\n-\t\t\t\tequals = i;\n+\n+\t\tif ((equals == 0) && (args[i] == '='))\n+\t\t\tequals = i;\n+\n+\t\tif (!backslash) {\n+\t\t\tif ((args[i] == '\"') || (args[i] == '\\\\')) {\n+\t\t\t\tif (args[i] == '\"')\n+\t\t\t\t\tin_quote = !in_quote;\n+\t\t\t\tif (args[i] == '\\\\')\n+\t\t\t\t\tbackslash = 1;\n+\n+\t\t\t\tmemmove(args + 1, args, i);\n+\t\t\t\targs++;\n+\t\t\t\ti--;\n+\t\t\t}\n+\t\t} else {\n+\t\t\tbackslash = 0;\n \t\t}\n-\t\tif (args[i] == '\"')\n-\t\t\tin_quote = !in_quote;\n \t}\n \n \t*param = args;\n@@ -225,13 +231,6 @@ char *next_arg(char *args, char **param, char **val)\n \telse {\n \t\targs[equals] = '\\0';\n \t\t*val = args + equals + 1;\n-\n-\t\t/* Don't include quotes in value. */\n-\t\tif ((args[i-1] == '\"') && ((quoted) || (**val == '\"'))) {\n-\t\t\targs[i-1] = '\\0';\n-\t\t\tif (!quoted)\n-\t\t\t\t(*val)++;\n-\t\t}\n \t}\n \n \tif (args[i]) {\n","prefixes":["1/6"]}