{"id":814293,"url":"http://patchwork.ozlabs.org/api/patches/814293/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pwm/patch/20170915140411.31716-2-romain.izard.pro@gmail.com/","project":{"id":38,"url":"http://patchwork.ozlabs.org/api/projects/38/?format=json","name":"Linux PWM development","link_name":"linux-pwm","list_id":"linux-pwm.vger.kernel.org","list_email":"linux-pwm@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170915140411.31716-2-romain.izard.pro@gmail.com>","list_archive_url":null,"date":"2017-09-15T14:04:03","name":"[v2,1/9] clk: at91: pmc: Wait for clocks when resuming","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3c0aefa7e09b25b04e247655ccad78b77581748f","submitter":{"id":8236,"url":"http://patchwork.ozlabs.org/api/people/8236/?format=json","name":"Romain Izard","email":"romain.izard.pro@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pwm/patch/20170915140411.31716-2-romain.izard.pro@gmail.com/mbox/","series":[{"id":3315,"url":"http://patchwork.ozlabs.org/api/series/3315/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pwm/list/?series=3315","date":"2017-09-15T14:04:06","name":"Various patches for SAMA5D2 backup mode","version":2,"mbox":"http://patchwork.ozlabs.org/series/3315/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814293/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814293/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"DHIV2a9T\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtxzt1jHrz9s7m\n\tfor ;\n\tSat, 16 Sep 2017 00:07:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751459AbdIOOEu (ORCPT );\n\tFri, 15 Sep 2017 10:04:50 -0400","from mail-wm0-f67.google.com ([74.125.82.67]:37809 \"EHLO\n\tmail-wm0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751364AbdIOOEq (ORCPT\n\t); Fri, 15 Sep 2017 10:04:46 -0400","by mail-wm0-f67.google.com with SMTP id f4so2877910wmh.4;\n\tFri, 15 Sep 2017 07:04:45 -0700 (PDT)","from localhost.localdomain (146.187.3.109.rev.sfr.net.\n\t[109.3.187.146]) by smtp.gmail.com with ESMTPSA id\n\t55sm1399225wrw.60.2017.09.15.07.04.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 07:04:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=QpAJytz+aiNN6ugMH0pd0IRk4M6Nw+EoUUnBnzUoU6Q=;\n\tb=DHIV2a9TdiWH89jWBKI6sRjXAfqJgVe5qYzlKSZf0hZO77U3hfHFvjgkfIatLK547Y\n\tIYWDXFZpkEqpTcNsTNZrbW+2X9oJ8Lh1W3CpzXP9A1zZ0MY1kBZ265Pag1WF7edMy6Xy\n\tP+eXosvsTFMwYycJ/cuvBTfKMKL6LnmGAa51VFJ5LY4LkU6d5xJiu1QTAKpJVbn4Jjon\n\t3j0rkBPnFtN6+FnXy86XoX9vB2fu7L9tUYCD//kRakcmf0j/1kEyBNIVOuvnyi5Jyleg\n\tQ2bbIhjcOqNzqih/ew3zUXwvEMuKHtX86oDyYwyltw5Gsk7Rnl5ZAdEMTKlGD500EyYU\n\t/khA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=QpAJytz+aiNN6ugMH0pd0IRk4M6Nw+EoUUnBnzUoU6Q=;\n\tb=K+2aqRcSobLpB6Thz84dx9mnmIQv0B5gKZSxCqspNcXHI+6lie8+eWnMF1Cb25vNpA\n\tTsnzuBWZzF5as5zUlWeQ6kHeWbO/u+VsjMcSPI95LE+7/Xp3C2Fe7lrcoL20yyRecmXA\n\tmWzJLyOeTa/stXDi5Op87cnTsCgcmV01CRKRKxDtaZgdTNotL16a+ISbFsgNOkFmvi5w\n\tmAZzs/+/vbZyilIFuNXric4zeePWDrz0XPhoHFooBEbe/jRQHANaKvDHIP6HGlwL9fOF\n\tFSjpBU0MrNvFhvPWkmyUSJrV02Kb3nRZZ3oEqxk/Wy9FqwMxuRVPCY4PGLXG0eqAYD9q\n\tnVzA==","X-Gm-Message-State":"AHPjjUjdk47dJjB4hZZARPxhaoGT4LuAIOb5GwwnySRzD0QbPguOfXLB\n\t68nuN+VivOkmdvQXdb4/Agg=","X-Google-Smtp-Source":"AOwi7QAl2xippvS5p8vsv7LTu8pczrn78LKP+GFjl6fUtAGFUh9arHyp+CJyMv/45ePzYEMy+yl89w==","X-Received":"by 10.28.185.195 with SMTP id j186mr2831376wmf.97.1505484285041; \n\tFri, 15 Sep 2017 07:04:45 -0700 (PDT)","From":"Romain Izard ","To":"Nicolas Ferre ,\n\tAlexandre Belloni ,\n\tBoris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tLudovic Desroches ,\n\tWenyou Yang , Josh Wu ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tAlan Stern ","Cc":"linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-mtd@lists.infradead.org, linux-pwm@vger.kernel.org,\n\tlinux-serial@vger.kernel.org, linux-usb@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tRomain Izard ","Subject":"[PATCH v2 1/9] clk: at91: pmc: Wait for clocks when resuming","Date":"Fri, 15 Sep 2017 16:04:03 +0200","Message-Id":"<20170915140411.31716-2-romain.izard.pro@gmail.com>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170915140411.31716-1-romain.izard.pro@gmail.com>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pwm@vger.kernel.org"},"content":"Wait for the syncronization of all clocks when resuming, not only the\nUPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG()\nwhen interrupts are masked, which is the case in here.\n\nSigned-off-by: Romain Izard \n---\n drivers/clk/at91/pmc.c | 24 ++++++++++++++++--------\n 1 file changed, 16 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\nindex 775af473fe11..5c2b26de303e 100644\n--- a/drivers/clk/at91/pmc.c\n+++ b/drivers/clk/at91/pmc.c\n@@ -107,10 +107,20 @@ static int pmc_suspend(void)\n \treturn 0;\n }\n \n+static bool pmc_ready(unsigned int mask)\n+{\n+\tunsigned int status;\n+\n+\tregmap_read(pmcreg, AT91_PMC_SR, &status);\n+\n+\treturn ((status & mask) == mask) ? 1 : 0;\n+}\n+\n static void pmc_resume(void)\n {\n-\tint i, ret = 0;\n+\tint i;\n \tu32 tmp;\n+\tu32 mask = AT91_PMC_MCKRDY | AT91_PMC_LOCKA;\n \n \tregmap_read(pmcreg, AT91_PMC_MCKR, &tmp);\n \tif (pmc_cache.mckr != tmp)\n@@ -134,13 +144,11 @@ static void pmc_resume(void)\n \t\t\t AT91_PMC_PCR_CMD);\n \t}\n \n-\tif (pmc_cache.uckr & AT91_PMC_UPLLEN) {\n-\t\tret = regmap_read_poll_timeout(pmcreg, AT91_PMC_SR, tmp,\n-\t\t\t\t\t !(tmp & AT91_PMC_LOCKU),\n-\t\t\t\t\t 10, 5000);\n-\t\tif (ret)\n-\t\t\tpr_crit(\"USB PLL didn't lock when resuming\\n\");\n-\t}\n+\tif (pmc_cache.uckr & AT91_PMC_UPLLEN)\n+\t\tmask |= AT91_PMC_LOCKU;\n+\n+\twhile (!pmc_ready(mask))\n+\t\tcpu_relax();\n }\n \n static struct syscore_ops pmc_syscore_ops = {\n","prefixes":["v2","1/9"]}