{"id":814283,"url":"http://patchwork.ozlabs.org/api/patches/814283/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pwm/patch/20170915140411.31716-6-romain.izard.pro@gmail.com/","project":{"id":38,"url":"http://patchwork.ozlabs.org/api/projects/38/?format=json","name":"Linux PWM development","link_name":"linux-pwm","list_id":"linux-pwm.vger.kernel.org","list_email":"linux-pwm@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170915140411.31716-6-romain.izard.pro@gmail.com>","list_archive_url":null,"date":"2017-09-15T14:04:07","name":"[v2,5/9] mtd: nand: atmel: Report PMECC failures as errors","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6e55509c1e4579dc3e4fb3dd7803ca05eb9665af","submitter":{"id":8236,"url":"http://patchwork.ozlabs.org/api/people/8236/?format=json","name":"Romain Izard","email":"romain.izard.pro@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pwm/patch/20170915140411.31716-6-romain.izard.pro@gmail.com/mbox/","series":[{"id":3315,"url":"http://patchwork.ozlabs.org/api/series/3315/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pwm/list/?series=3315","date":"2017-09-15T14:04:06","name":"Various patches for SAMA5D2 backup mode","version":2,"mbox":"http://patchwork.ozlabs.org/series/3315/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814283/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814283/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"OqgyhTsS\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtxxQ60lRz9s7m\n\tfor ;\n\tSat, 16 Sep 2017 00:05:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751701AbdIOOFN (ORCPT );\n\tFri, 15 Sep 2017 10:05:13 -0400","from mail-wm0-f66.google.com ([74.125.82.66]:38301 \"EHLO\n\tmail-wm0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751651AbdIOOFJ (ORCPT\n\t); Fri, 15 Sep 2017 10:05:09 -0400","by mail-wm0-f66.google.com with SMTP id x17so2862548wmd.5;\n\tFri, 15 Sep 2017 07:05:08 -0700 (PDT)","from localhost.localdomain (146.187.3.109.rev.sfr.net.\n\t[109.3.187.146]) by smtp.gmail.com with ESMTPSA id\n\t55sm1399225wrw.60.2017.09.15.07.04.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 07:05:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=aaNnsNahYIjh+1Ks16UeHfn5wML1ytVR6uApSlam0ak=;\n\tb=OqgyhTsSOUMP1mVjyu/obvgk3bNOtKuna5CRZtg9kBCdhq7TnEgjhGITEIisIEQAW7\n\tMut/LLFCccw82cWRFBQRWeWN9egZpx86KwadjaGsCrevoyWSCp3nnrpQIIkbnEg5iVgz\n\tU6K7wLmk9ApCXK2EyUySCYTAPIuICMYbKpNGC2lqX6+lY/rJL0V1aZWkzZKaz1eYJdQ9\n\tryBJ+fI+RurDDJoy2zGUcUtN+PqZqmuT1zq4twvNm1r9GKLuMKycO5hzY6m2B7h5M1xl\n\toUekFS6p52VqfHfHPARmjvjiVTDWbhmIRYdNhOYbu96axJ/Uh+UgpoyFKyMSbo1RtoRk\n\t/tbw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=aaNnsNahYIjh+1Ks16UeHfn5wML1ytVR6uApSlam0ak=;\n\tb=Qjew6ZqGW5nPoOhOqNiygixGz6O5tEMLZsdJYG2uBexWb0vJ8ncvaDxAHfmXxmkZUv\n\t0cesB6XVQT0cEXz9X1T7SDmDTH7tJnvnqExKIW1dl6sZ7m1Jj7VX8wY3U/SvKw7GGULY\n\thUacfwRfdtAIkRM7BBFvXQ8u6Xa8PnoX5oNLY0RNv3FtP3UOw7iyJaihnZfVrL8drSSw\n\t7YM6v5MBYTzcC4KB+4+MQAq+o9PoTJwYnn/lUQUa/2Oh8FxQBeJ63W2fA/6TwKF/4GGA\n\tZBC359Ynsxd/M/JIU6Fjx/531A2QD3VJc84yHb31zRUEglPexEEuye2TjFt6uym5yLzp\n\teRlg==","X-Gm-Message-State":"AHPjjUgF2X7qB33UImFXg14EzrKN7VySvHcm7o3aOQILIMImcxVKfImi\n\ttEAZ5H1/uDmFF6MRgiyHi/g=","X-Google-Smtp-Source":"AOwi7QBnCD+VHqUcD6q/tJCH+iN6CxlbVr6SP3fS133oqL63dNXiXTxV1nTYTt8BdvqglV3ugcBYFA==","X-Received":"by 10.28.30.133 with SMTP id e127mr2668086wme.8.1505484307983;\n\tFri, 15 Sep 2017 07:05:07 -0700 (PDT)","From":"Romain Izard ","To":"Nicolas Ferre ,\n\tAlexandre Belloni ,\n\tBoris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tLudovic Desroches ,\n\tWenyou Yang , Josh Wu ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tAlan Stern ","Cc":"linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-mtd@lists.infradead.org, linux-pwm@vger.kernel.org,\n\tlinux-serial@vger.kernel.org, linux-usb@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tRomain Izard ","Subject":"[PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors","Date":"Fri, 15 Sep 2017 16:04:07 +0200","Message-Id":"<20170915140411.31716-6-romain.izard.pro@gmail.com>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170915140411.31716-1-romain.izard.pro@gmail.com>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pwm@vger.kernel.org"},"content":"It is not normal for the PMECC to fail when trying to fix ECC errors.\nReport these cases as errors.\n\nSigned-off-by: Romain Izard \n---\n drivers/mtd/nand/atmel/pmecc.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c\nindex 8d1208f38025..2a23f1ff945f 100644\n--- a/drivers/mtd/nand/atmel/pmecc.c\n+++ b/drivers/mtd/nand/atmel/pmecc.c\n@@ -687,6 +687,8 @@ static int atmel_pmecc_err_location(struct atmel_pmecc_user *user)\n \t * Number of roots does not match the degree of smu\n \t * unable to correct error.\n \t */\n+\tdev_err(pmecc->dev,\n+\t\t\"PMECC: Impossible to calculate error location.\\n\");\n \treturn -EBADMSG;\n }\n \n@@ -729,7 +731,7 @@ int atmel_pmecc_correct_sector(struct atmel_pmecc_user *user, int sector,\n \t\t\tptr = ecc + byte - sectorsize;\n \t\t\tarea = \"ECC\";\n \t\t} else {\n-\t\t\tdev_dbg(pmecc->dev,\n+\t\t\tdev_err(pmecc->dev,\n \t\t\t\t\"Invalid errpos value (%d, max is %d)\\n\",\n \t\t\t\terrpos, (sectorsize + eccbytes) * 8);\n \t\t\treturn -EINVAL;\n","prefixes":["v2","5/9"]}