{"id":814235,"url":"http://patchwork.ozlabs.org/api/patches/814235/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/f02a2ddd-8469-4a17-99fe-620c690be7c2@messagesink.samelson.uni-hildesheim.de/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-15T11:33:51","name":"AW: [PATCH] PCI SUBSYSTEM allows inconsistent configuration, current Kernel version","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"795ef22976e81e1c597532311db926d4a2dfbd8d","submitter":{"id":72371,"url":"http://patchwork.ozlabs.org/api/people/72371/?format=json","name":"Sascha El-Sharkawy","email":"elscha@sse.uni-hildesheim.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/f02a2ddd-8469-4a17-99fe-620c690be7c2@messagesink.samelson.uni-hildesheim.de/mbox/","series":[{"id":3287,"url":"http://patchwork.ozlabs.org/api/series/3287/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=3287","date":"2017-09-15T11:33:51","name":"AW: [PATCH] PCI SUBSYSTEM allows inconsistent configuration, current Kernel version","version":1,"mbox":"http://patchwork.ozlabs.org/series/3287/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814235/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814235/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xttbb4qFBz9s82\n\tfor ;\n\tFri, 15 Sep 2017 21:34:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751226AbdIOLed convert rfc822-to-8bit (ORCPT\n\t);\n\tFri, 15 Sep 2017 07:34:33 -0400","from messagesink.samelson.uni-hildesheim.de ([147.172.172.66]:3658\n\t\"EHLO messagesink.samelson.uni-hildesheim.de\"\n\trhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751198AbdIOLed (ORCPT\n\t); Fri, 15 Sep 2017 07:34:33 -0400","from messagesink.samelson.uni-hildesheim.de ([147.172.172.66]) by\n\tmessagesink.samelson.uni-hildesheim.de ([147.172.172.66]) with\n\tmapi; Fri, 15 Sep 2017 13:34:14 +0200"],"From":"Sascha El-Sharkawy ","To":"\"linux-pci@vger.kernel.org\" ","CC":"Klaus Schmid ,\n\t\"bhelgaas@google.com\" ","Date":"Fri, 15 Sep 2017 13:33:51 +0200","Subject":"AW: [PATCH] PCI SUBSYSTEM allows inconsistent configuration,\n\tcurrent Kernel version","Thread-Topic":"[PATCH] PCI SUBSYSTEM allows inconsistent configuration,\n\tcurrent Kernel version","Thread-Index":"AdMuFnoGGKJ+jCE3RtiPgy/zfwEmHQ==","Message-ID":"","Accept-Language":"de-DE","Content-Language":"de-DE","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","acceptlanguage":"de-DE","Content-Type":"text/plain; charset=\"Windows-1252\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"},"content":"Dear Bjorn,\n\nThank you for your help. Blow you'll find the inline patch to ensure the correct Kconfig configuration when PCI_REALLOC_ENABLE_AUTO is selected.\n\nBest regards,\nSascha El-Sharkawy\n\nSigned-off-by: Sascha El-Sharkawy diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig index c32a77fc8b03..675d79c52709 100644\nUniversity of Hildesheim                    Tel.: +49 (0) 5121 / 883-40336 Institute of Computer Science               Fax: +49 (0) 5121 / 883-40337\nUniversitätsplatz 1                         elscha@sse.uni-hildesheim.de\nD-31141 Hildesheim, Germany               http://www.sse.uni-hildesheim.de\n\n\n> On Thu, 14 Sep 2017 10:01:17 +0200, Bjorn Helgaas wrote:\n> \n> Hi Sascha,\n> \n> On Wed, Aug 23, 2017 at 08:22:38AM +0200, Sascha El-Sharkawy wrote:\n> > We detected that the selection of \"PCI resource re-allocation detection\"\n> > (CONFIG_PCI_REALLOC_ENABLE_AUTO) is ignored in some situations. This \n> > can happen as the related functionality (drivers/pci/setup-bus.c, \n> > lines 1702\n> > - 1738) depends on CONFIG_PCI_REALLOC_ENABLE_AUTO and\n> CONFIG_PCI_IOV,\n> > while in Kconfig (drivers/pci/Kconfig, lines 42 - 53) this \n> > functionality is only controlled by CONFIG_PCI_REALLOC_ENABLE_AUTO.\n> >\n> > The dependency on CONFIG_PCI_IOV is only mentioned in the comment\n> of\n> > CONFIG_PCI_REALLOC_ENABLE_AUTO, but not checked by Kconfig. As \n> > CONFIG_PCI_IOV is selected by many other configuration options, we \n> > expect the failure to happen in very few configurations only, which \n> > makes it even harder to detect and fix. However, there exist \n> > configurations that will still be faulty. The suggested fix ensures \n> > that the re-allocation is always working as specified through an \n> > automated selection of CONFIG_PCI_IOV if\n> CONFIG_PCI_REALLOC_ENABLE_AUTO is selected.\n> \n> I'm sorry that I missed this patch. I normally work from patchwork \n> (https://patchwork.ozlabs.org/project/linux-pci/list/), and it \n> apparently doesn't pick up patches that are attached (or maybe it just \n> misses gzipped ones).\n> \n> Can you please repost this as plain-text email with the patch included \n> inline, with a changelog and Signed-off-by? Then patchwork should \n> pick it up and I won't forget about it.\n> \n> For details about Signed-off-by, etc, see \n> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tre\n> e/Docu mentation/process/submitting-patches.rst\n> \n> Bjorn","diff":"--- a/drivers/pci/Kconfig\n+++ b/drivers/pci/Kconfig\n@@ -42,13 +42,12 @@ config PCI_DEBUG\n config PCI_REALLOC_ENABLE_AUTO\n \tbool \"Enable PCI resource re-allocation detection\"\n \tdepends on PCI\n+\tselect PCI_IOV\n \thelp\n \t Say Y here if you want the PCI core to detect if PCI resource\n \t re-allocation needs to be enabled. You can always use pci=realloc=on\n- or pci=realloc=off to override it. Note this feature is a no-op\n- unless PCI_IOV support is also enabled; in that case it will\n- automatically re-allocate PCI resources if SR-IOV BARs have not\n- been allocated by the BIOS.\n+\t or pci=realloc=off to override it. It will automatically re-allocate\n+\t PCI resources if SR-IOV BARs have not been allocated by the BIOS.\n \n \t When in doubt, say N.\n-- -----------------------------------------------------------------------\nSascha El-Sharkawy, MSc\n","prefixes":[]}