{"id":814032,"url":"http://patchwork.ozlabs.org/api/patches/814032/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170915015921.4659-4-icenowy@aosc.io/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170915015921.4659-4-icenowy@aosc.io>","list_archive_url":null,"date":"2017-09-15T01:59:21","name":"[U-Boot,v4,3/3] sunxi: setup simplefb for Allwinner DE2","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1cb7e697e2edab56ea000061a201228790de99a8","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/?format=json","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"delegate":{"id":1700,"url":"http://patchwork.ozlabs.org/api/users/1700/?format=json","username":"ag","first_name":"Anatolij","last_name":"Gustschin","email":"agust@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170915015921.4659-4-icenowy@aosc.io/mbox/","series":[{"id":3195,"url":"http://patchwork.ozlabs.org/api/series/3195/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3195","date":"2017-09-15T01:59:18","name":"Allwinner DE2 HDMI SimpleFB support","version":4,"mbox":"http://patchwork.ozlabs.org/series/3195/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814032/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814032/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtdvw54lcz9s4s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 12:02:52 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 621F5C21FA0; Fri, 15 Sep 2017 02:02:11 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C9F86C21F18;\n\tFri, 15 Sep 2017 02:01:48 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid E6E88C21E7F; Fri, 15 Sep 2017 02:01:38 +0000 (UTC)","from nov-007-i592.relay.mailchannels.net\n\t(nov-007-i592.relay.mailchannels.net [46.232.183.146])\n\tby lists.denx.de (Postfix) with ESMTPS id 7E02FC21FAD\n\tfor <u-boot@lists.denx.de>; Fri, 15 Sep 2017 02:01:31 +0000 (UTC)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 1990A36846E;\n\tFri, 15 Sep 2017 02:01:29 +0000 (UTC)","from hermes.aosc.io (unknown [100.96.128.168])\n\t(Authenticated sender: lmn-TZDUIOWCRQMW)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id BDE0E3684F2;\n\tFri, 15 Sep 2017 02:01:27 +0000 (UTC)","from hermes.aosc.io (hermes.aosc.io [172.20.108.37])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Fri, 15 Sep 2017 02:01:29 +0000","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id 3411247497;\n\tFri, 15 Sep 2017 02:01:22 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Sender-Id":["lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","X-MailChannels-Auth-Id":"lmn-TZDUIOWCRQMW","X-Little-Gusty":"635b7e116abadfff_1505440888831_1029282498","X-MC-Loop-Signature":"1505440888831:2206285561","X-MC-Ingress-Time":"1505440888830","From":"Icenowy Zheng <icenowy@aosc.io>","To":"Jagan Teki <jagan@openedev.com>,\n\tMaxime Ripard <maxime.ripard@free-electrons.com>,\n\tJernej Skrabec <jernej.skrabec@siol.net>","Date":"Fri, 15 Sep 2017 09:59:21 +0800","Message-Id":"<20170915015921.4659-4-icenowy@aosc.io>","In-Reply-To":"<20170915015921.4659-1-icenowy@aosc.io>","References":"<20170915015921.4659-1-icenowy@aosc.io>","Cc":"u-boot@lists.denx.de, linux-sunxi@googlegroups.com,\n\tIcenowy Zheng <icenowy@aosc.io>","Subject":"[U-Boot] [PATCH v4 3/3] sunxi: setup simplefb for Allwinner DE2","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"As the support of EFI boot on Allwinner H3 is broken, we still need to\nuse simplefb to pass the framebuffer to Linux.\n\nAdd code to setup simplefb for Allwinner DE2 driver.\n\nSigned-off-by: Icenowy Zheng <icenowy@aosc.io>\nAcked-by: Maxime Ripard <maxime.ripard@free-electrons.com>\n---\nChanges in v4:\n- Imply CONFIG_VIDEO_DT_SIMPLEFB.\n\nChanges in v3:\n- Extract CONFIG_VIDEO_DT_SIMPLEFB to a Kconfig option.\n\nChanges in v2:\n- Extract the simplefb node searching code.\n\n arch/arm/mach-sunxi/Kconfig     |  1 +\n drivers/video/sunxi/Makefile    |  2 +-\n drivers/video/sunxi/sunxi_de2.c | 72 +++++++++++++++++++++++++++++++++++++++++\n 3 files changed, 74 insertions(+), 1 deletion(-)","diff":"diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig\nindex 2309f59999..6474b12b54 100644\n--- a/arch/arm/mach-sunxi/Kconfig\n+++ b/arch/arm/mach-sunxi/Kconfig\n@@ -768,6 +768,7 @@ config VIDEO_DE2\n \tdepends on SUNXI_DE2\n \tselect DM_VIDEO\n \tselect DISPLAY\n+\timply VIDEO_DT_SIMPLEFB\n \tdefault y\n \t---help---\n \tSay y here if you want to build DE2 video driver which is present on\ndiff --git a/drivers/video/sunxi/Makefile b/drivers/video/sunxi/Makefile\nindex 10862edaca..aec32b79b9 100644\n--- a/drivers/video/sunxi/Makefile\n+++ b/drivers/video/sunxi/Makefile\n@@ -6,4 +6,4 @@\n #\n \n obj-$(CONFIG_VIDEO_SUNXI) += sunxi_display.o simplefb_common.o lcdc.o tve_common.o ../videomodes.o\n-obj-$(CONFIG_VIDEO_DE2) += sunxi_de2.o sunxi_dw_hdmi.o lcdc.o ../dw_hdmi.o\n+obj-$(CONFIG_VIDEO_DE2) += sunxi_de2.o sunxi_dw_hdmi.o simplefb_common.o lcdc.o ../dw_hdmi.o\ndiff --git a/drivers/video/sunxi/sunxi_de2.c b/drivers/video/sunxi/sunxi_de2.c\nindex ee67764ac5..67b937098c 100644\n--- a/drivers/video/sunxi/sunxi_de2.c\n+++ b/drivers/video/sunxi/sunxi_de2.c\n@@ -10,6 +10,8 @@\n #include <display.h>\n #include <dm.h>\n #include <edid.h>\n+#include <fdtdec.h>\n+#include <fdt_support.h>\n #include <video.h>\n #include <asm/global_data.h>\n #include <asm/io.h>\n@@ -17,6 +19,7 @@\n #include <asm/arch/display2.h>\n #include <dm/device-internal.h>\n #include <dm/uclass-internal.h>\n+#include \"simplefb_common.h\"\n \n DECLARE_GLOBAL_DATA_PTR;\n \n@@ -292,3 +295,72 @@ U_BOOT_DRIVER(sunxi_de2) = {\n U_BOOT_DEVICE(sunxi_de2) = {\n \t.name = \"sunxi_de2\"\n };\n+\n+/*\n+ * Simplefb support.\n+ */\n+#if defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_VIDEO_DT_SIMPLEFB)\n+int sunxi_simplefb_setup(void *blob)\n+{\n+\tstruct udevice *de2, *hdmi;\n+\tstruct video_priv *de2_priv;\n+\tstruct video_uc_platdata *de2_plat;\n+\tint mux;\n+\tint offset, ret;\n+\tu64 start, size;\n+\tconst char *pipeline = NULL;\n+\n+\tdebug(\"Setting up simplefb\\n\");\n+\n+\tif (IS_ENABLED(CONFIG_MACH_SUNXI_H3_H5))\n+\t\tmux = 0;\n+\telse\n+\t\tmux = 1;\n+\n+\t/* Skip simplefb setting if DE2 / HDMI is not present */\n+\tret = uclass_find_device_by_name(UCLASS_VIDEO,\n+\t\t\t\t\t \"sunxi_de2\", &de2);\n+\tif (ret) {\n+\t\tdebug(\"DE2 not present\\n\");\n+\t\treturn 0;\n+\t}\n+\n+\tret = uclass_find_device_by_name(UCLASS_DISPLAY,\n+\t\t\t\t\t \"sunxi_dw_hdmi\", &hdmi);\n+\tif (ret) {\n+\t\tdebug(\"HDMI not present\\n\");\n+\t\treturn 0;\n+\t}\n+\n+\tif (mux == 0)\n+\t\tpipeline = \"mixer0-lcd0-hdmi\";\n+\telse\n+\t\tpipeline = \"mixer1-lcd1-hdmi\";\n+\n+\tde2_priv = dev_get_uclass_priv(de2);\n+\tde2_plat = dev_get_uclass_platdata(de2);\n+\n+\toffset = sunxi_simplefb_fdt_match(blob, pipeline);\n+\tif (offset < 0) {\n+\t\teprintf(\"Cannot setup simplefb: node not found\\n\");\n+\t\treturn 0; /* Keep older kernels working */\n+\t}\n+\n+\tstart = gd->bd->bi_dram[0].start;\n+\tsize = de2_plat->base - start;\n+\tret = fdt_fixup_memory_banks(blob, &start, &size, 1);\n+\tif (ret) {\n+\t\teprintf(\"Cannot setup simplefb: Error reserving memory\\n\");\n+\t\treturn ret;\n+\t}\n+\n+\tret = fdt_setup_simplefb_node(blob, offset, de2_plat->base,\n+\t\t\tde2_priv->xsize, de2_priv->ysize,\n+\t\t\tVNBYTES(de2_priv->bpix) * de2_priv->xsize,\n+\t\t\t\"x8r8g8b8\");\n+\tif (ret)\n+\t\teprintf(\"Cannot setup simplefb: Error setting properties\\n\");\n+\n+\treturn ret;\n+}\n+#endif /* CONFIG_OF_BOARD_SETUP && CONFIG_VIDEO_DT_SIMPLEFB */\n","prefixes":["U-Boot","v4","3/3"]}