{"id":814013,"url":"http://patchwork.ozlabs.org/api/patches/814013/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/CAELXzTMdH_scC+o3xFy2mBTakFDohccDLF8ZgX1AcSS03s7k7Q@mail.gmail.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-15T01:27:15","name":"[RFC,1/5] Add separate parms for rtl unroller","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"59b8faec1c107dad1a9e304e591d4b363d1010ef","submitter":{"id":25768,"url":"http://patchwork.ozlabs.org/api/people/25768/?format=json","name":"Kugan Vivekanandarajah","email":"kugan.vivekanandarajah@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/CAELXzTMdH_scC+o3xFy2mBTakFDohccDLF8ZgX1AcSS03s7k7Q@mail.gmail.com/mbox/","series":[{"id":3186,"url":"http://patchwork.ozlabs.org/api/series/3186/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=3186","date":"2017-09-15T01:24:36","name":"Loop unrolling and memory load streams","version":1,"mbox":"http://patchwork.ozlabs.org/series/3186/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814013/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814013/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462189-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"KpPGFZXq\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtd752sRzz9t2V\n\tfor ;\n\tFri, 15 Sep 2017 11:27:29 +1000 (AEST)","(qmail 104526 invoked by alias); 15 Sep 2017 01:27:21 -0000","(qmail 104517 invoked by uid 89); 15 Sep 2017 01:27:21 -0000","from mail-qt0-f182.google.com (HELO mail-qt0-f182.google.com)\n\t(209.85.216.182) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 15 Sep 2017 01:27:19 +0000","by mail-qt0-f182.google.com with SMTP id q4so982476qtq.8 for\n\t; Thu, 14 Sep 2017 18:27:19 -0700 (PDT)","by 10.237.37.211 with HTTP; Thu, 14 Sep 2017 18:27:15 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:from:date:message-id:subject:to:content-type; q=\n\tdns; s=default; b=dBPi72YLfV7yH8LJ+T2hT2D6KU1MXBp/HD9Zcdy2geV4m4\n\tYLMltOFf3uMAEHP+CswzMAuH2YS12NI7SEaue2RHO1JeYx857we61Jf1dx3D9pVQ\n\txShGQ5sHXci0AXLmV5SUJYaf4fFhuE/X3FE7wXbUkrbYHjDAi195I+WxE+BaA=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:from:date:message-id:subject:to:content-type; s=\n\tdefault; bh=JaUq8xBvOk0nCekCuniDeJs/7/8=; b=KpPGFZXqUrpUeYLq7OP7\n\tIrmLX+wgLvNr93+wnuV/cf/6yMy5Fs51kt+3jAFL6iy88jgda7IXCyC9ZNJJtV2m\n\tgOnJoJC8FuyYIRNaO8ry+cJhmJ1VDzi7vABF67vyokREc5BHsfrlaFSnIBTJIXCF\n\tKuTOqkP21l9boiNAZ81df0k=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-24.5 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tRCVD_IN_DNSWL_LOW, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mail-qt0-f182.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:mime-version:from:date:message-id:subject:to;\n\tbh=1CGfYS5m6hl48bwfiD8NOudEnkDWW99CkDLowbe7tMg=;\n\tb=DQT0dliMJ4l7mS+7R9dJ8yP0dnRKieWj8Bv5a2Jd9F3CcOz14YPtaLtITsvTGcAtwk\n\tbdsh6g9392s5s5F3wsqJJ2TvThQsse+w00RgORSNdKlFmsbTvBi6aiiHk5GdRQEdDVdw\n\tJ+BBh3yOK6BqidX6cLoRfzIQ50YR6y3h+bEyZBBYhHx2pyB0i0+KolZbqAWj2w9orU7s\n\t1skkXGcy4cUfAkCdGgBtKRzEhV1U7KlSAxd52uBZI2wCp6ZAzDydUPdbq3W1c1rrlccQ\n\tXtGfiooO7eczOZhrp80S2TM0yMgJfFHCK1SYxaOcHD0xpPGXAZ28nBmtOFZIE7SbSV+m\n\tNH8w==","X-Gm-Message-State":"AHPjjUjx9QwxZ4/WdFINpGbrb7xzjCdXe0Ng1cTT1SRDiTKnC3yGD52s\tZP/aZTZUt8XIlo5WqsrwuE/tdbKSltcEtFj3qzOCqY4pxNg=","X-Google-Smtp-Source":"AOwi7QDmlCgK3PFVNOsV3DbANvqV9lwDTpVhwTJEnwUnm0ZOwjUtCSn/WFSFj68EoVmwaA7Beuq63kEj4HyRO8q7evU=","X-Received":"by 10.237.37.228 with SMTP id y33mr25177351qtc.79.1505438837957;\n\tThu, 14 Sep 2017 18:27:17 -0700 (PDT)","MIME-Version":"1.0","From":"Kugan Vivekanandarajah ","Date":"Fri, 15 Sep 2017 11:27:15 +1000","Message-ID":"","Subject":"[RFC][PATCH 1/5] Add separate parms for rtl unroller","To":"\"gcc-patches@gcc.gnu.org\" ","Content-Type":"multipart/mixed; boundary=\"001a1140d9f42b3e7a0559304b0d\"","X-IsSubscribed":"yes"},"content":"This patch adds separate params for rtl unroller so that they can be\ntunned accordingly. Default values I have are based on some testing on\naarch64. I am happy to leave it as the current value and set them in\nthe back-end.\n\nThanks,\nKugan\n\n\ngcc/ChangeLog:\n\n2017-09-12 Kugan Vivekanandarajah \n\n * loop-unroll.c (decide_unroll_constant_iterations): Use new params.\n (decide_unroll_runtime_iterations): Likewise.\n (decide_unroll_stupid): Likewise.\n * params.def (DEFPARAM): Separate and add new params for rtl unroller.","diff":"From a899caf9f82767de3db556225b28dc52a81d5967 Mon Sep 17 00:00:00 2001\nFrom: Kugan Vivekanandarajah \nDate: Mon, 14 Aug 2017 10:12:09 +1000\nSubject: [PATCH 1/5] add parms for rtl unroller\n\n---\n gcc/loop-unroll.c | 24 ++++++++++++------------\n gcc/params.def | 17 +++++++++++++++++\n 2 files changed, 29 insertions(+), 12 deletions(-)\n\ndiff --git a/gcc/loop-unroll.c b/gcc/loop-unroll.c\nindex 84145bb..871558c 100644\n--- a/gcc/loop-unroll.c\n+++ b/gcc/loop-unroll.c\n@@ -360,13 +360,13 @@ decide_unroll_constant_iterations (struct loop *loop, int flags)\n \n /* nunroll = total number of copies of the original loop body in\n unrolled loop (i.e. if it is 2, we have to duplicate loop body once. */\n- nunroll = PARAM_VALUE (PARAM_MAX_UNROLLED_INSNS) / loop->ninsns;\n+ nunroll = PARAM_VALUE (PARAM_MAX_UNROLLEDP_INSNS) / loop->ninsns;\n nunroll_by_av\n- = PARAM_VALUE (PARAM_MAX_AVERAGE_UNROLLED_INSNS) / loop->av_ninsns;\n+ = PARAM_VALUE (PARAM_MAX_AVERAGE_UNROLLEDP_INSNS) / loop->av_ninsns;\n if (nunroll > nunroll_by_av)\n nunroll = nunroll_by_av;\n- if (nunroll > (unsigned) PARAM_VALUE (PARAM_MAX_UNROLL_TIMES))\n- nunroll = PARAM_VALUE (PARAM_MAX_UNROLL_TIMES);\n+ if (nunroll > (unsigned) PARAM_VALUE (PARAM_MAX_UNROLLP_TIMES))\n+ nunroll = PARAM_VALUE (PARAM_MAX_UNROLLP_TIMES);\n \n if (targetm.loop_unroll_adjust)\n nunroll = targetm.loop_unroll_adjust (nunroll, loop);\n@@ -664,12 +664,12 @@ decide_unroll_runtime_iterations (struct loop *loop, int flags)\n \n /* nunroll = total number of copies of the original loop body in\n unrolled loop (i.e. if it is 2, we have to duplicate loop body once. */\n- nunroll = PARAM_VALUE (PARAM_MAX_UNROLLED_INSNS) / loop->ninsns;\n- nunroll_by_av = PARAM_VALUE (PARAM_MAX_AVERAGE_UNROLLED_INSNS) / loop->av_ninsns;\n+ nunroll = PARAM_VALUE (PARAM_MAX_UNROLLEDP_INSNS) / loop->ninsns;\n+ nunroll_by_av = PARAM_VALUE (PARAM_MAX_AVERAGE_UNROLLEDP_INSNS) / loop->av_ninsns;\n if (nunroll > nunroll_by_av)\n nunroll = nunroll_by_av;\n- if (nunroll > (unsigned) PARAM_VALUE (PARAM_MAX_UNROLL_TIMES))\n- nunroll = PARAM_VALUE (PARAM_MAX_UNROLL_TIMES);\n+ if (nunroll > (unsigned) PARAM_VALUE (PARAM_MAX_UNROLLP_TIMES))\n+ nunroll = PARAM_VALUE (PARAM_MAX_UNROLLP_TIMES);\n \n if (targetm.loop_unroll_adjust)\n nunroll = targetm.loop_unroll_adjust (nunroll, loop);\n@@ -1158,13 +1158,13 @@ decide_unroll_stupid (struct loop *loop, int flags)\n \n /* nunroll = total number of copies of the original loop body in\n unrolled loop (i.e. if it is 2, we have to duplicate loop body once. */\n- nunroll = PARAM_VALUE (PARAM_MAX_UNROLLED_INSNS) / loop->ninsns;\n+ nunroll = PARAM_VALUE (PARAM_MAX_UNROLLEDP_INSNS) / loop->ninsns;\n nunroll_by_av\n- = PARAM_VALUE (PARAM_MAX_AVERAGE_UNROLLED_INSNS) / loop->av_ninsns;\n+ = PARAM_VALUE (PARAM_MAX_AVERAGE_UNROLLEDP_INSNS) / loop->av_ninsns;\n if (nunroll > nunroll_by_av)\n nunroll = nunroll_by_av;\n- if (nunroll > (unsigned) PARAM_VALUE (PARAM_MAX_UNROLL_TIMES))\n- nunroll = PARAM_VALUE (PARAM_MAX_UNROLL_TIMES);\n+ if (nunroll > (unsigned) PARAM_VALUE (PARAM_MAX_UNROLLP_TIMES))\n+ nunroll = PARAM_VALUE (PARAM_MAX_UNROLLP_TIMES);\n \n if (targetm.loop_unroll_adjust)\n nunroll = targetm.loop_unroll_adjust (nunroll, loop);\ndiff --git a/gcc/params.def b/gcc/params.def\nindex 805302b..c8b0a2b 100644\n--- a/gcc/params.def\n+++ b/gcc/params.def\n@@ -302,6 +302,23 @@ DEFPARAM(PARAM_MAX_PEELED_INSNS,\n \t\"max-peeled-insns\",\n \t\"The maximum number of insns of a peeled loop.\",\n \t100, 0, 0)\n+\n+DEFPARAM(PARAM_MAX_UNROLLEDP_INSNS,\n+\t \"max-partial-unrolled-insns\",\n+\t \"The maximum number of instructions to consider to unroll in a loop by rtl unroller.\",\n+\t 100, 0, 0)\n+/* This parameter limits how many times the loop is unrolled depending\n+ on number of insns really executed in each iteration. */\n+DEFPARAM(PARAM_MAX_AVERAGE_UNROLLEDP_INSNS,\n+\t \"max-partial-average-unrolled-insns\",\n+\t \"The maximum number of instructions to consider to unroll in a loop on average by rtl unroller.\",\n+\t 40, 0, 0)\n+/* The maximum number of unrollings of a single loop. */\n+DEFPARAM(PARAM_MAX_UNROLLP_TIMES,\n+\t\"max-partial-unroll-times\",\n+\t\"The maximum number of unrollings of a single loop by rtl unroller.\",\n+\t4, 0, 0)\n+\n /* The maximum number of peelings of a single loop. */\n DEFPARAM(PARAM_MAX_PEEL_TIMES,\n \t\"max-peel-times\",\n-- \n2.7.4\n\n","prefixes":["RFC","1/5"]}