{"id":813955,"url":"http://patchwork.ozlabs.org/api/patches/813955/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170914213450.28754-8-paul.burton@imgtec.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170914213450.28754-8-paul.burton@imgtec.com>","list_archive_url":null,"date":"2017-09-14T21:34:49","name":"[U-Boot,v2,7/8] test/py: hush_if_test: Use open() in place of file()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4cb1c05e2b8524f6d8f5f26ff148d6a158095a1b","submitter":{"id":33698,"url":"http://patchwork.ozlabs.org/api/people/33698/?format=json","name":"Paul Burton","email":"paul.burton@imgtec.com"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170914213450.28754-8-paul.burton@imgtec.com/mbox/","series":[{"id":3166,"url":"http://patchwork.ozlabs.org/api/series/3166/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3166","date":"2017-09-14T21:34:42","name":"test/py: Fixes for python 3.x","version":2,"mbox":"http://patchwork.ozlabs.org/series/3166/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813955/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813955/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtX4Z6z35z9s7B\n\tfor ;\n\tFri, 15 Sep 2017 07:39:58 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 8250BC21F0E; Thu, 14 Sep 2017 21:38:19 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A8991C21F0D;\n\tThu, 14 Sep 2017 21:38:16 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 45DDEC21F26; Thu, 14 Sep 2017 21:37:41 +0000 (UTC)","from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196])\n\tby lists.denx.de (Postfix) with ESMTP id 2849CC21F16\n\tfor ; Thu, 14 Sep 2017 21:37:41 +0000 (UTC)","from hhmail02.hh.imgtec.org (unknown [10.100.10.20])\n\tby Forcepoint Email with ESMTPS id 8BE23BD706490;\n\tThu, 14 Sep 2017 22:37:35 +0100 (IST)","from localhost (10.20.1.88) by hhmail02.hh.imgtec.org\n\t(10.100.10.21) with Microsoft SMTP Server (TLS) id 14.3.294.0;\n\tThu, 14 Sep 2017 22:37:40 +0100"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE\n\tautolearn=unavailable autolearn_force=no version=3.4.0","From":"Paul Burton ","To":"","Date":"Thu, 14 Sep 2017 14:34:49 -0700","Message-ID":"<20170914213450.28754-8-paul.burton@imgtec.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170914213450.28754-1-paul.burton@imgtec.com>","References":"<20170914213450.28754-1-paul.burton@imgtec.com>","MIME-Version":"1.0","X-Originating-IP":"[10.20.1.88]","Cc":"Stephen Warren ,\n\tMichal Simek ","Subject":"[U-Boot] [PATCH v2 7/8] test/py: hush_if_test: Use open() in place\n\tof file()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"In python 3.x the file() function has been removed. Use open() instead,\nwhich works on both python 2.x & 3.x, and is described as the preferred\nmethod of opening a file by python 2.x documentation anyway.\n\nSigned-off-by: Paul Burton \nReviewed-by: Stephen Warren \n---\n\nChanges in v2: None\n\n test/py/tests/test_hush_if_test.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/test/py/tests/test_hush_if_test.py b/test/py/tests/test_hush_if_test.py\nindex c8f4208d31..cdad22b429 100644\n--- a/test/py/tests/test_hush_if_test.py\n+++ b/test/py/tests/test_hush_if_test.py\n@@ -149,7 +149,7 @@ def test_hush_if_test_host_file_exists(u_boot_console):\n exec_hush_if(u_boot_console, expr, False)\n \n try:\n- with file(test_file, 'wb'):\n+ with open(test_file, 'wb'):\n pass\n assert os.path.exists(test_file)\n \n","prefixes":["U-Boot","v2","7/8"]}