{"id":813868,"url":"http://patchwork.ozlabs.org/api/patches/813868/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170914144032.14945-9-eblake@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170914144032.14945-9-eblake@redhat.com>","list_archive_url":null,"date":"2017-09-14T14:40:20","name":"[v3,08/20] null: Switch to .bdrv_co_block_status()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9512930c623283efd1bc13311931a217815bfc6b","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170914144032.14945-9-eblake@redhat.com/mbox/","series":[{"id":3114,"url":"http://patchwork.ozlabs.org/api/series/3114/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3114","date":"2017-09-14T14:40:12","name":"add byte-based block_status driver callbacks","version":3,"mbox":"http://patchwork.ozlabs.org/series/3114/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813868/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813868/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtMBH08QXz9s0Z\n\tfor ;\n\tFri, 15 Sep 2017 00:59:19 +1000 (AEST)","from localhost ([::1]:48272 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsVbp-0000ga-4K\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 10:59:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46513)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsVKM-0005rq-44\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:41:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsVKI-0002b0-5r\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:41:14 -0400","from mx1.redhat.com ([209.132.183.28]:47988)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsVKB-0002VW-30; Thu, 14 Sep 2017 10:41:03 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 21D6A356D9;\n\tThu, 14 Sep 2017 14:41:02 +0000 (UTC)","from red.redhat.com (ovpn-123-70.rdu2.redhat.com [10.10.123.70])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 035A560841;\n\tThu, 14 Sep 2017 14:41:00 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 21D6A356D9","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Thu, 14 Sep 2017 09:40:20 -0500","Message-Id":"<20170914144032.14945-9-eblake@redhat.com>","In-Reply-To":"<20170914144032.14945-1-eblake@redhat.com>","References":"<20170914144032.14945-1-eblake@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 14 Sep 2017 14:41:02 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 08/20] null: Switch to\n\t.bdrv_co_block_status()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, famz@redhat.com, jsnow@redhat.com,\n\tqemu-block@nongnu.org, Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"We are gradually moving away from sector-based interfaces, towards\nbyte-based. Update the null driver accordingly.\n\nSigned-off-by: Eric Blake \n\n---\nv2: rebase to mapping parameter\n---\n block/null.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)","diff":"diff --git a/block/null.c b/block/null.c\nindex dd9c13f9ba..d34c482066 100644\n--- a/block/null.c\n+++ b/block/null.c\n@@ -223,22 +223,22 @@ static int null_reopen_prepare(BDRVReopenState *reopen_state,\n return 0;\n }\n\n-static int64_t coroutine_fn null_co_get_block_status(BlockDriverState *bs,\n- int64_t sector_num,\n- int nb_sectors, int *pnum,\n- BlockDriverState **file)\n+static int64_t coroutine_fn null_co_block_status(BlockDriverState *bs,\n+ bool mapping,\n+ int64_t offset,\n+ int64_t bytes, int64_t *pnum,\n+ BlockDriverState **file)\n {\n BDRVNullState *s = bs->opaque;\n- off_t start = sector_num * BDRV_SECTOR_SIZE;\n+ int64_t ret = BDRV_BLOCK_OFFSET_VALID | (offset & BDRV_BLOCK_OFFSET_MASK);\n\n- *pnum = nb_sectors;\n+ *pnum = bytes;\n *file = bs;\n\n if (s->read_zeroes) {\n- return BDRV_BLOCK_OFFSET_VALID | start | BDRV_BLOCK_ZERO;\n- } else {\n- return BDRV_BLOCK_OFFSET_VALID | start;\n+ ret |= BDRV_BLOCK_ZERO;\n }\n+ return ret;\n }\n\n static void null_refresh_filename(BlockDriverState *bs, QDict *opts)\n@@ -270,7 +270,7 @@ static BlockDriver bdrv_null_co = {\n .bdrv_co_flush_to_disk = null_co_flush,\n .bdrv_reopen_prepare = null_reopen_prepare,\n\n- .bdrv_co_get_block_status = null_co_get_block_status,\n+ .bdrv_co_block_status = null_co_block_status,\n\n .bdrv_refresh_filename = null_refresh_filename,\n };\n@@ -290,7 +290,7 @@ static BlockDriver bdrv_null_aio = {\n .bdrv_aio_flush = null_aio_flush,\n .bdrv_reopen_prepare = null_reopen_prepare,\n\n- .bdrv_co_get_block_status = null_co_get_block_status,\n+ .bdrv_co_block_status = null_co_block_status,\n\n .bdrv_refresh_filename = null_refresh_filename,\n };\n","prefixes":["v3","08/20"]}