{"id":813857,"url":"http://patchwork.ozlabs.org/api/patches/813857/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170914144032.14945-16-eblake@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170914144032.14945-16-eblake@redhat.com>","list_archive_url":null,"date":"2017-09-14T14:40:27","name":"[v3,15/20] vdi: Avoid bitrot of debugging code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"296d294c82b02bfb2020950e1897c61977eee2a4","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170914144032.14945-16-eblake@redhat.com/mbox/","series":[{"id":3114,"url":"http://patchwork.ozlabs.org/api/series/3114/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3114","date":"2017-09-14T14:40:12","name":"add byte-based block_status driver callbacks","version":3,"mbox":"http://patchwork.ozlabs.org/series/3114/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813857/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813857/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtM0b0DGtz9s81\n\tfor ;\n\tFri, 15 Sep 2017 00:50:55 +1000 (AEST)","from localhost ([::1]:48223 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsVTh-0007DO-54\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 10:50:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46847)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsVKf-00069H-5f\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:41:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsVKe-0002vk-8h\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:41:33 -0400","from mx1.redhat.com ([209.132.183.28]:53214)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsVKZ-0002or-Dk; Thu, 14 Sep 2017 10:41:27 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 77BAC81DFC;\n\tThu, 14 Sep 2017 14:41:26 +0000 (UTC)","from red.redhat.com (ovpn-123-70.rdu2.redhat.com [10.10.123.70])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id EED3418240;\n\tThu, 14 Sep 2017 14:41:24 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 77BAC81DFC","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Thu, 14 Sep 2017 09:40:27 -0500","Message-Id":"<20170914144032.14945-16-eblake@redhat.com>","In-Reply-To":"<20170914144032.14945-1-eblake@redhat.com>","References":"<20170914144032.14945-1-eblake@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tThu, 14 Sep 2017 14:41:26 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 15/20] vdi: Avoid bitrot of debugging code","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org,\n\tStefan Weil , Max Reitz ,\n\tjsnow@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Rework the debug define so that we always get -Wformat checking,\neven when debugging is disabled.\n\nSigned-off-by: Eric Blake \nReviewed-by: Stefan Weil \nReviewed-by: Philippe Mathieu-Daudé \n\n---\nv2: no change\n---\n block/vdi.c | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)","diff":"diff --git a/block/vdi.c b/block/vdi.c\nindex 8da5dfc897..6f83221ddc 100644\n--- a/block/vdi.c\n+++ b/block/vdi.c\n@@ -86,12 +86,18 @@\n #define DEFAULT_CLUSTER_SIZE (1 * MiB)\n\n #if defined(CONFIG_VDI_DEBUG)\n-#define logout(fmt, ...) \\\n- fprintf(stderr, \"vdi\\t%-24s\" fmt, __func__, ##__VA_ARGS__)\n+#define VDI_DEBUG 1\n #else\n-#define logout(fmt, ...) ((void)0)\n+#define VDI_DEBUG 0\n #endif\n\n+#define logout(fmt, ...) \\\n+ do { \\\n+ if (VDI_DEBUG) { \\\n+ fprintf(stderr, \"vdi\\t%-24s\" fmt, __func__, ##__VA_ARGS__); \\\n+ } \\\n+ } while (0)\n+\n /* Image signature. */\n #define VDI_SIGNATURE 0xbeda107f\n\n","prefixes":["v3","15/20"]}