{"id":813852,"url":"http://patchwork.ozlabs.org/api/patches/813852/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170914144032.14945-13-eblake@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170914144032.14945-13-eblake@redhat.com>","list_archive_url":null,"date":"2017-09-14T14:40:24","name":"[v3,12/20] qed: Switch to .bdrv_co_block_status()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7fdb968c841e5046ef2463e0a3f96178bb36232a","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170914144032.14945-13-eblake@redhat.com/mbox/","series":[{"id":3114,"url":"http://patchwork.ozlabs.org/api/series/3114/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3114","date":"2017-09-14T14:40:12","name":"add byte-based block_status driver callbacks","version":3,"mbox":"http://patchwork.ozlabs.org/series/3114/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813852/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813852/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtLxQ2fQnz9sPt\n\tfor ;\n\tFri, 15 Sep 2017 00:48:10 +1000 (AEST)","from localhost ([::1]:48209 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsVR1-0003jV-Oi\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 10:48:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46751)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsVKb-00065B-5W\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:41:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsVKV-0002lj-9X\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:41:29 -0400","from mx1.redhat.com ([209.132.183.28]:49282)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsVKS-0002jO-RI; Thu, 14 Sep 2017 10:41:21 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D4964C04B310;\n\tThu, 14 Sep 2017 14:41:19 +0000 (UTC)","from red.redhat.com (ovpn-123-70.rdu2.redhat.com [10.10.123.70])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0BD2660841;\n\tThu, 14 Sep 2017 14:41:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D4964C04B310","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Thu, 14 Sep 2017 09:40:24 -0500","Message-Id":"<20170914144032.14945-13-eblake@redhat.com>","In-Reply-To":"<20170914144032.14945-1-eblake@redhat.com>","References":"<20170914144032.14945-1-eblake@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 14 Sep 2017 14:41:20 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 12/20] qed: Switch to .bdrv_co_block_status()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org,\n\tMax Reitz ,\n\tStefan Hajnoczi , jsnow@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"We are gradually moving away from sector-based interfaces, towards\nbyte-based. Update the qed driver accordingly. There is no intent\nto optimize based on the mapping flag for this format.\n\nSigned-off-by: Eric Blake \n\n---\nv2: rebase to mapping flag, fix mask in qed_is_allocated_cb\n---\n block/qed.c | 22 ++++++++++++----------\n 1 file changed, 12 insertions(+), 10 deletions(-)","diff":"diff --git a/block/qed.c b/block/qed.c\nindex 28e2ec89e8..16752e50c0 100644\n--- a/block/qed.c\n+++ b/block/qed.c\n@@ -693,7 +693,7 @@ typedef struct {\n Coroutine *co;\n uint64_t pos;\n int64_t status;\n- int *pnum;\n+ int64_t *pnum;\n BlockDriverState **file;\n } QEDIsAllocatedCB;\n\n@@ -702,10 +702,10 @@ static void qed_is_allocated_cb(void *opaque, int ret, uint64_t offset, size_t l\n {\n QEDIsAllocatedCB *cb = opaque;\n BDRVQEDState *s = cb->bs->opaque;\n- *cb->pnum = len / BDRV_SECTOR_SIZE;\n+ *cb->pnum = len;\n switch (ret) {\n case QED_CLUSTER_FOUND:\n- offset |= qed_offset_into_cluster(s, cb->pos);\n+ offset |= qed_offset_into_cluster(s, cb->pos) & BDRV_BLOCK_OFFSET_MASK;\n cb->status = BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID | offset;\n *cb->file = cb->bs->file->bs;\n break;\n@@ -727,16 +727,18 @@ static void qed_is_allocated_cb(void *opaque, int ret, uint64_t offset, size_t l\n }\n }\n\n-static int64_t coroutine_fn bdrv_qed_co_get_block_status(BlockDriverState *bs,\n- int64_t sector_num,\n- int nb_sectors, int *pnum,\n- BlockDriverState **file)\n+static int64_t coroutine_fn bdrv_qed_co_block_status(BlockDriverState *bs,\n+ bool mapping,\n+ int64_t pos,\n+ int64_t bytes,\n+ int64_t *pnum,\n+ BlockDriverState **file)\n {\n BDRVQEDState *s = bs->opaque;\n- size_t len = (size_t)nb_sectors * BDRV_SECTOR_SIZE;\n+ size_t len;\n QEDIsAllocatedCB cb = {\n .bs = bs,\n- .pos = (uint64_t)sector_num * BDRV_SECTOR_SIZE,\n+ .pos = pos,\n .status = BDRV_BLOCK_OFFSET_MASK,\n .pnum = pnum,\n .file = file,\n@@ -1595,7 +1597,7 @@ static BlockDriver bdrv_qed = {\n .bdrv_child_perm = bdrv_format_default_perms,\n .bdrv_create = bdrv_qed_create,\n .bdrv_has_zero_init = bdrv_has_zero_init_1,\n- .bdrv_co_get_block_status = bdrv_qed_co_get_block_status,\n+ .bdrv_co_block_status = bdrv_qed_co_block_status,\n .bdrv_co_readv = bdrv_qed_co_readv,\n .bdrv_co_writev = bdrv_qed_co_writev,\n .bdrv_co_pwrite_zeroes = bdrv_qed_co_pwrite_zeroes,\n","prefixes":["v3","12/20"]}