{"id":813767,"url":"http://patchwork.ozlabs.org/api/patches/813767/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>","list_archive_url":null,"date":"2017-09-14T10:40:06","name":"[v11,2/6] qmp: Use ThrottleLimits structure","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"815a95d28dac81a2a64d94f011b3f62c7418895f","submitter":{"id":69852,"url":"http://patchwork.ozlabs.org/api/people/69852/?format=json","name":"Pradeep Jagadeesh","email":"pradeepkiruvale@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com/mbox/","series":[{"id":3065,"url":"http://patchwork.ozlabs.org/api/series/3065/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3065","date":"2017-09-14T10:40:06","name":"fsdev: qmp interface for io throttling","version":11,"mbox":"http://patchwork.ozlabs.org/series/3065/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813767/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813767/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"M+uV3M5p\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtFSn2sGMz9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 20:41:26 +1000 (AEST)","from localhost ([::1]:46865 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dsRaG-0006sE-2F\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 06:41:24 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52183)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pradeepkiruvale@gmail.com>) id 1dsRZh-0006pr-IK\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 06:40:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pradeepkiruvale@gmail.com>) id 1dsRZd-0001wt-0I\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 06:40:49 -0400","from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:38267)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <pradeepkiruvale@gmail.com>)\n\tid 1dsRZc-0001vu-Gd\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 06:40:44 -0400","by mail-wm0-x242.google.com with SMTP id x17so2867582wmd.5\n\tfor <qemu-devel@nongnu.org>; Thu, 14 Sep 2017 03:40:44 -0700 (PDT)","from localhost.localdomain.localdomain ([217.110.131.66])\n\tby smtp.gmail.com with ESMTPSA id\n\tw14sm742801wmf.13.2017.09.14.03.40.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 14 Sep 2017 03:40:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=1x16PabO960ttIVHJ5euH4mKWmdMjRWOyXL9dHWHGcE=;\n\tb=M+uV3M5p5Z1XaUDjy6W+GeSAler1KB547bqLOYkvBya8aMVSdyAjTY4CELmCc4mYzR\n\tUUFUdWKZnhJFnqm48Xrj3i9ZTVdO489oFNvHRcyVutGexj5SxsRnKXhctn7CllBdPFfL\n\to3wOfEEjuDejucEAaV4pEKmp2kaFfTsX0wPBZL3OpmsBh27k2LyEClwtDaJi4r7Y5QZI\n\tZcR2uWFo7fWtvE3ZCMANYXpVX12rcUZ70eRuujcFTqKsPQGLmU6+NH3DId/gjzlOE8OH\n\tx7mj1/mH5hokooRJNu9QIiXeEP2QZSWS157lqulA3H7Jf9np0jv0OI1KkavFBn9d2e9G\n\twFqA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=1x16PabO960ttIVHJ5euH4mKWmdMjRWOyXL9dHWHGcE=;\n\tb=QjskGbCDPZidXtMMqg9YOPwNz7cCVinVVGEX8XP7fY76cyGHofUcxl2SKVJC4sb2S9\n\t3TMzmWVG81gHIItirUwpCBSRFGzd57rxPUIHAENs+aBPO9cNORWgvcML6ihD8NPQQ5pQ\n\tbSZ6k37gfqyiFjgyD9V8o7UFt7oWfF0QVhTe5CxCcUoIgNkzEtGQLWx2obkm+XGW85OW\n\tcjc0Dl3YN6RNkI7bEWnJi6BRtIMajaY9DwmRYMmWkNZfcBGa8Wx7GHVAKa4qtHWQsOrU\n\tfYPXmzt6LzE/msA9Cjo/D6UkmiARIN+NAMYwxSEMNYCSSpb3vheu4zmNrjeBPLOmrpov\n\tJjkw==","X-Gm-Message-State":"AHPjjUiTR2dR5s2jlnJTwYhGgpgBdZIDZK6yCL2gpYrkYpxZi3UBSrpk\n\t/ygOLsT5Ha0U7w==","X-Google-Smtp-Source":"AOwi7QAOIpTrJzLl4Z5ML1LMB4tT+0goeNCh/cXAvjT5lCrSiMMxhVbIBh7CaIZccNKk9WxzTTFv7A==","X-Received":"by 10.28.164.68 with SMTP id n65mr1463066wme.23.1505385643398;\n\tThu, 14 Sep 2017 03:40:43 -0700 (PDT)","From":"Pradeep Jagadeesh <pradeepkiruvale@gmail.com>","X-Google-Original-From":"Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>","To":"\"eric blake\" <eblake@redhat.com>,\n\t\"greg kurz\" <groug@kaod.org>","Date":"Thu, 14 Sep 2017 06:40:06 -0400","Message-Id":"<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>","X-Mailer":"git-send-email 1.8.3.1","In-Reply-To":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>","References":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::242","Subject":"[Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"jani kokkonen <jani.kokkonen@huawei.com>,\n\talberto garcia <berto@igalia.com>, \n\tPradeep Jagadeesh <pradeep.jagadeesh@huawei.com>, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"This patch factors out code to use the ThrottleLimits\nstrurcture.\n\nSigned-off-by: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>\nReviewed-by: Greg Kurz <groug@kaod.org>\nReviewed-by: Eric Blake <eblake@redhat.com>\nReviewed-by: Alberto Garcia <berto@igalia.com>\nReviewed-by: Markus Armbruster <armbru@redhat.com>\n---\n qapi/block-core.json | 78 +++-------------------------------------------------\n 1 file changed, 4 insertions(+), 74 deletions(-)","diff":"diff --git a/qapi/block-core.json b/qapi/block-core.json\nindex bb11815..d0ccfda 100644\n--- a/qapi/block-core.json\n+++ b/qapi/block-core.json\n@@ -1826,84 +1826,13 @@\n #\n # @device: Block device name (deprecated, use @id instead)\n #\n-# @id: The name or QOM path of the guest device (since: 2.8)\n-#\n-# @bps: total throughput limit in bytes per second\n-#\n-# @bps_rd: read throughput limit in bytes per second\n-#\n-# @bps_wr: write throughput limit in bytes per second\n-#\n-# @iops: total I/O operations per second\n-#\n-# @iops_rd: read I/O operations per second\n-#\n-# @iops_wr: write I/O operations per second\n-#\n-# @bps_max: total throughput limit during bursts,\n-#                     in bytes (Since 1.7)\n-#\n-# @bps_rd_max: read throughput limit during bursts,\n-#                        in bytes (Since 1.7)\n-#\n-# @bps_wr_max: write throughput limit during bursts,\n-#                        in bytes (Since 1.7)\n-#\n-# @iops_max: total I/O operations per second during bursts,\n-#                      in bytes (Since 1.7)\n-#\n-# @iops_rd_max: read I/O operations per second during bursts,\n-#                         in bytes (Since 1.7)\n-#\n-# @iops_wr_max: write I/O operations per second during bursts,\n-#                         in bytes (Since 1.7)\n-#\n-# @bps_max_length: maximum length of the @bps_max burst\n-#                            period, in seconds. It must only\n-#                            be set if @bps_max is set as well.\n-#                            Defaults to 1. (Since 2.6)\n-#\n-# @bps_rd_max_length: maximum length of the @bps_rd_max\n-#                               burst period, in seconds. It must only\n-#                               be set if @bps_rd_max is set as well.\n-#                               Defaults to 1. (Since 2.6)\n-#\n-# @bps_wr_max_length: maximum length of the @bps_wr_max\n-#                               burst period, in seconds. It must only\n-#                               be set if @bps_wr_max is set as well.\n-#                               Defaults to 1. (Since 2.6)\n-#\n-# @iops_max_length: maximum length of the @iops burst\n-#                             period, in seconds. It must only\n-#                             be set if @iops_max is set as well.\n-#                             Defaults to 1. (Since 2.6)\n-#\n-# @iops_rd_max_length: maximum length of the @iops_rd_max\n-#                                burst period, in seconds. It must only\n-#                                be set if @iops_rd_max is set as well.\n-#                                Defaults to 1. (Since 2.6)\n-#\n-# @iops_wr_max_length: maximum length of the @iops_wr_max\n-#                                burst period, in seconds. It must only\n-#                                be set if @iops_wr_max is set as well.\n-#                                Defaults to 1. (Since 2.6)\n-#\n-# @iops_size: an I/O size in bytes (Since 1.7)\n-#\n # @group: throttle group name (Since 2.4)\n #\n # Since: 1.1\n ##\n { 'struct': 'BlockIOThrottle',\n-  'data': { '*device': 'str', '*id': 'str', 'bps': 'int', 'bps_rd': 'int',\n-            'bps_wr': 'int', 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int',\n-            '*bps_max': 'int', '*bps_rd_max': 'int',\n-            '*bps_wr_max': 'int', '*iops_max': 'int',\n-            '*iops_rd_max': 'int', '*iops_wr_max': 'int',\n-            '*bps_max_length': 'int', '*bps_rd_max_length': 'int',\n-            '*bps_wr_max_length': 'int', '*iops_max_length': 'int',\n-            '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',\n-            '*iops_size': 'int', '*group': 'str' } }\n+  'base': 'ThrottleLimits',\n+  'data': { '*device': 'str', '*group': 'str' } }\n \n ##\n # @ThrottleLimits:\n@@ -1913,6 +1842,7 @@\n # transaction. All fields are optional. When setting limits, if a field is\n # missing the current value is not changed.\n #\n+# @id:                     device id\n # @iops-total:             limit total I/O operations per second\n # @iops-total-max:         I/O operations burst\n # @iops-total-max-length:  length of the iops-total-max burst period, in seconds\n@@ -1942,7 +1872,7 @@\n # Since: 2.11\n ##\n { 'struct': 'ThrottleLimits',\n-  'data': { '*iops-total' : 'int', '*iops-total-max' : 'int',\n+  'data': { '*id' : 'str', '*iops-total' : 'int', '*iops-total-max' : 'int',\n             '*iops-total-max-length' : 'int', '*iops-read' : 'int',\n             '*iops-read-max' : 'int', '*iops-read-max-length' : 'int',\n             '*iops-write' : 'int', '*iops-write-max' : 'int',\n","prefixes":["v11","2/6"]}